pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-19 20:19:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Feat: Enable warnings when values are overwritten in registries (#107)

Browse Source 
* enable warning

* add warning

* fix order
This commit is contained in:
Krist Wongsuphasawat 2019-02-19 15:41:00 -08:00 committed by Yongjie Zhao
parent 11378a4ea5
commit 0f5e88eb5a
7 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/registries/ChartBuildQueryRegistrySingleton.ts
View File

@ -1,8 +1,8 @@
import { Registry, makeSingleton } from '@superset-ui/core';
import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
class ChartBuildQueryRegistry extends Registry {
constructor() {
super({ name: 'ChartBuildQuery' });
super({ name: 'ChartBuildQuery', overwritePolicy: OverwritePolicy.WARN });
}
}

4
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/registries/ChartComponentRegistrySingleton.ts
View File

@ -1,8 +1,8 @@
import { Registry, makeSingleton } from '@superset-ui/core';
import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
class ChartComponentRegistry extends Registry {
constructor() {
super({ name: 'ChartComponent' });
super({ name: 'ChartComponent', overwritePolicy: OverwritePolicy.WARN });
}
}

4
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/registries/ChartMetadataRegistrySingleton.ts
View File

@ -1,8 +1,8 @@
import { Registry, makeSingleton } from '@superset-ui/core';
import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
class ChartMetadataRegistry extends Registry {
constructor() {
super({ name: 'ChartMetadata' });
super({ name: 'ChartMetadata', overwritePolicy: OverwritePolicy.WARN });
}
}

4
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/registries/ChartTransformPropsRegistrySingleton.ts
View File

@ -1,8 +1,8 @@
import { Registry, makeSingleton } from '@superset-ui/core';
import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
class ChartTransformPropsRegistry extends Registry {
constructor() {
super({ name: 'ChartTransformProps' });
super({ name: 'ChartTransformProps', overwritePolicy: OverwritePolicy.WARN });
}
}

3
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-color/src/ColorSchemeRegistry.ts
View File

@ -1,9 +1,10 @@
import { RegistryWithDefaultKey } from '@superset-ui/core';
import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
export default class ColorSchemeRegistry<T> extends RegistryWithDefaultKey<T> {
constructor() {
super({
name: 'ColorScheme',
overwritePolicy: OverwritePolicy.WARN,
setFirstItemAsDefault: true,
});
}

3
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts
View File

@ -1,4 +1,4 @@
import { RegistryWithDefaultKey } from '@superset-ui/core';
import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
import createD3NumberFormatter from './factories/createD3NumberFormatter';
import NumberFormats from './NumberFormats';
import NumberFormatter from './NumberFormatter';
@ -11,6 +11,7 @@ export default class NumberFormatterRegistry extends RegistryWithDefaultKey<
super({
initialDefaultKey: NumberFormats.SI,
name: 'NumberFormatter',
overwritePolicy: OverwritePolicy.WARN,
});
}

3
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-time-format/src/TimeFormatterRegistry.ts
View File

@ -1,4 +1,4 @@
import { RegistryWithDefaultKey } from '@superset-ui/core';
import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
import TimeFormats, { LOCAL_PREFIX } from './TimeFormats';
import createD3TimeFormatter from './factories/createD3TimeFormatter';
import TimeFormatter from './TimeFormatter';
@ -11,6 +11,7 @@ export default class TimeFormatterRegistry extends RegistryWithDefaultKey<
super({
initialDefaultKey: TimeFormats.DATABASE_DATETIME,
name: 'TimeFormatter',
overwritePolicy: OverwritePolicy.WARN,
});
}