mirror of
https://github.com/apache/superset.git
synced 2024-09-06 13:57:40 -04:00
fix: Support the Clipboard API in modern browsers (#20058)
* fix: Support the Clipboard API in modern browsers * fix tests * PR comment * Improvements
This commit is contained in:
parent
92057858c2
commit
0e38c686c6
@ -57,10 +57,10 @@ class CopyToClipboard extends React.Component {
|
||||
onClick() {
|
||||
if (this.props.getText) {
|
||||
this.props.getText(d => {
|
||||
this.copyToClipboard(d);
|
||||
this.copyToClipboard(Promise.resolve(d));
|
||||
});
|
||||
} else {
|
||||
this.copyToClipboard(this.props.text);
|
||||
this.copyToClipboard(Promise.resolve(this.props.text));
|
||||
}
|
||||
}
|
||||
|
||||
@ -72,7 +72,7 @@ class CopyToClipboard extends React.Component {
|
||||
}
|
||||
|
||||
copyToClipboard(textToCopy) {
|
||||
copyTextToClipboard(textToCopy)
|
||||
copyTextToClipboard(() => textToCopy)
|
||||
.then(() => {
|
||||
this.props.addSuccessToast(t('Copied to clipboard!'));
|
||||
})
|
||||
|
@ -102,9 +102,10 @@ test('Click on "Copy dashboard URL" and succeed', async () => {
|
||||
|
||||
userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
|
||||
|
||||
await waitFor(() => {
|
||||
await waitFor(async () => {
|
||||
expect(spy).toBeCalledTimes(1);
|
||||
expect(spy).toBeCalledWith('http://localhost/superset/dashboard/p/123/');
|
||||
const value = await spy.mock.calls[0][0]();
|
||||
expect(value).toBe('http://localhost/superset/dashboard/p/123/');
|
||||
expect(props.addSuccessToast).toBeCalledTimes(1);
|
||||
expect(props.addSuccessToast).toBeCalledWith('Copied to clipboard!');
|
||||
expect(props.addDangerToast).toBeCalledTimes(0);
|
||||
@ -128,9 +129,10 @@ test('Click on "Copy dashboard URL" and fail', async () => {
|
||||
|
||||
userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
|
||||
|
||||
await waitFor(() => {
|
||||
await waitFor(async () => {
|
||||
expect(spy).toBeCalledTimes(1);
|
||||
expect(spy).toBeCalledWith('http://localhost/superset/dashboard/p/123/');
|
||||
const value = await spy.mock.calls[0][0]();
|
||||
expect(value).toBe('http://localhost/superset/dashboard/p/123/');
|
||||
expect(props.addSuccessToast).toBeCalledTimes(0);
|
||||
expect(props.addDangerToast).toBeCalledTimes(1);
|
||||
expect(props.addDangerToast).toBeCalledWith(
|
||||
|
@ -64,8 +64,7 @@ const ShareMenuItems = (props: ShareMenuItemProps) => {
|
||||
|
||||
async function onCopyLink() {
|
||||
try {
|
||||
const url = await generateUrl();
|
||||
await copyTextToClipboard(url);
|
||||
await copyTextToClipboard(generateUrl);
|
||||
addSuccessToast(t('Copied to clipboard!'));
|
||||
} catch (error) {
|
||||
logging.error(error);
|
||||
|
@ -18,7 +18,7 @@
|
||||
*/
|
||||
import userEvent from '@testing-library/user-event';
|
||||
import React from 'react';
|
||||
import { render, screen } from 'spec/helpers/testing-library';
|
||||
import { render, screen, waitFor } from 'spec/helpers/testing-library';
|
||||
import { CopyToClipboardButton } from '.';
|
||||
|
||||
test('Render a button', () => {
|
||||
@ -28,14 +28,26 @@ test('Render a button', () => {
|
||||
expect(screen.getByRole('button')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('Should copy to clipboard', () => {
|
||||
document.execCommand = jest.fn();
|
||||
test('Should copy to clipboard', async () => {
|
||||
const callback = jest.fn();
|
||||
document.execCommand = callback;
|
||||
|
||||
const originalClipboard = { ...global.navigator.clipboard };
|
||||
// @ts-ignore
|
||||
global.navigator.clipboard = { write: callback, writeText: callback };
|
||||
|
||||
render(<CopyToClipboardButton data={{ copy: 'data', data: 'copy' }} />, {
|
||||
useRedux: true,
|
||||
});
|
||||
|
||||
expect(document.execCommand).toHaveBeenCalledTimes(0);
|
||||
expect(callback).toHaveBeenCalledTimes(0);
|
||||
userEvent.click(screen.getByRole('button'));
|
||||
expect(document.execCommand).toHaveBeenCalledWith('copy');
|
||||
|
||||
await waitFor(() => {
|
||||
expect(callback).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
jest.resetAllMocks();
|
||||
// @ts-ignore
|
||||
global.navigator.clipboard = originalClipboard;
|
||||
});
|
||||
|
@ -175,9 +175,9 @@ describe('DataTablesPane', () => {
|
||||
expect(await screen.findByText('1 row')).toBeVisible();
|
||||
|
||||
userEvent.click(screen.getByLabelText('Copy'));
|
||||
expect(copyToClipboardSpy).toHaveBeenCalledWith(
|
||||
'2009-01-01 00:00:00\tAction\n',
|
||||
);
|
||||
expect(copyToClipboardSpy).toHaveBeenCalledTimes(1);
|
||||
const value = await copyToClipboardSpy.mock.calls[0][0]();
|
||||
expect(value).toBe('2009-01-01 00:00:00\tAction\n');
|
||||
copyToClipboardSpy.mockRestore();
|
||||
fetchMock.restore();
|
||||
});
|
||||
|
@ -168,8 +168,7 @@ export const useExploreAdditionalActionsMenu = (
|
||||
if (!latestQueryFormData) {
|
||||
throw new Error();
|
||||
}
|
||||
const url = await getChartPermalink(latestQueryFormData);
|
||||
await copyTextToClipboard(url);
|
||||
await copyTextToClipboard(() => getChartPermalink(latestQueryFormData));
|
||||
addSuccessToast(t('Copied to clipboard!'));
|
||||
} catch (error) {
|
||||
addDangerToast(t('Sorry, something went wrong. Try again later.'));
|
||||
|
@ -94,7 +94,7 @@ export function prepareCopyToClipboardTabularData(data, columns) {
|
||||
for (let i = 0; i < data.length; i += 1) {
|
||||
const row = {};
|
||||
for (let j = 0; j < columns.length; j += 1) {
|
||||
// JavaScript does not mantain the order of a mixed set of keys (i.e integers and strings)
|
||||
// JavaScript does not maintain the order of a mixed set of keys (i.e integers and strings)
|
||||
// the below function orders the keys based on the column names.
|
||||
const key = columns[j].name || columns[j];
|
||||
if (data[i][key]) {
|
||||
@ -145,4 +145,10 @@ export const detectOS = () => {
|
||||
return 'Unknown OS';
|
||||
};
|
||||
|
||||
export const isSafari = () => {
|
||||
const { userAgent } = navigator;
|
||||
|
||||
return userAgent && /^((?!chrome|android).)*safari/i.test(userAgent);
|
||||
};
|
||||
|
||||
export const isNullish = value => value === null || value === undefined;
|
||||
|
@ -17,7 +17,44 @@
|
||||
* under the License.
|
||||
*/
|
||||
|
||||
const copyTextToClipboard = async (text: string) =>
|
||||
import { isSafari } from './common';
|
||||
|
||||
// Use the new Clipboard API if the browser supports it
|
||||
const copyTextWithClipboardApi = async (getText: () => Promise<string>) => {
|
||||
// Safari (WebKit) does not support delayed generation of clipboard.
|
||||
// This means that writing to the clipboard, from the moment the user
|
||||
// interacts with the app, must be instantaneous.
|
||||
// However, neither writeText nor write accepts a Promise, so
|
||||
// we need to create a ClipboardItem that accepts said Promise to
|
||||
// delay the text generation, as needed.
|
||||
// Source: https://bugs.webkit.org/show_bug.cgi?id=222262P
|
||||
if (isSafari()) {
|
||||
try {
|
||||
const clipboardItem = new ClipboardItem({
|
||||
'text/plain': getText(),
|
||||
});
|
||||
await navigator.clipboard.write([clipboardItem]);
|
||||
} catch {
|
||||
// Fallback to default clipboard API implementation
|
||||
const text = await getText();
|
||||
await navigator.clipboard.writeText(text);
|
||||
}
|
||||
} else {
|
||||
// For Blink, the above method won't work, but we can use the
|
||||
// default (intended) API, since the delayed generation of the
|
||||
// clipboard is now supported.
|
||||
// Source: https://bugs.chromium.org/p/chromium/issues/detail?id=1014310
|
||||
const text = await getText();
|
||||
await navigator.clipboard.writeText(text);
|
||||
}
|
||||
};
|
||||
|
||||
const copyTextToClipboard = (getText: () => Promise<string>) =>
|
||||
copyTextWithClipboardApi(getText)
|
||||
// If the Clipboard API is not supported, fallback to the older method.
|
||||
.catch(() =>
|
||||
getText().then(
|
||||
text =>
|
||||
new Promise<void>((resolve, reject) => {
|
||||
const selection: Selection | null = document.getSelection();
|
||||
if (selection) {
|
||||
@ -51,6 +88,8 @@ const copyTextToClipboard = async (text: string) =>
|
||||
}
|
||||
|
||||
resolve();
|
||||
});
|
||||
}),
|
||||
),
|
||||
);
|
||||
|
||||
export default copyTextToClipboard;
|
||||
|
@ -65,7 +65,7 @@ export default function SyntaxHighlighterCopy({
|
||||
language: 'sql' | 'markdown' | 'html' | 'json';
|
||||
}) {
|
||||
function copyToClipboard(textToCopy: string) {
|
||||
copyTextToClipboard(textToCopy)
|
||||
copyTextToClipboard(() => Promise.resolve(textToCopy))
|
||||
.then(() => {
|
||||
if (addSuccessToast) {
|
||||
addSuccessToast(t('SQL Copied!'));
|
||||
|
@ -210,8 +210,10 @@ function SavedQueryList({
|
||||
|
||||
const copyQueryLink = useCallback(
|
||||
(id: number) => {
|
||||
copyTextToClipboard(
|
||||
copyTextToClipboard(() =>
|
||||
Promise.resolve(
|
||||
`${window.location.origin}/superset/sqllab?savedQueryId=${id}`,
|
||||
),
|
||||
)
|
||||
.then(() => {
|
||||
addSuccessToast(t('Link Copied!'));
|
||||
|
@ -611,8 +611,10 @@ export const copyQueryLink = (
|
||||
addDangerToast: (arg0: string) => void,
|
||||
addSuccessToast: (arg0: string) => void,
|
||||
) => {
|
||||
copyTextToClipboard(
|
||||
copyTextToClipboard(() =>
|
||||
Promise.resolve(
|
||||
`${window.location.origin}/superset/sqllab?savedQueryId=${id}`,
|
||||
),
|
||||
)
|
||||
.then(() => {
|
||||
addSuccessToast(t('Link Copied!'));
|
||||
|
Loading…
Reference in New Issue
Block a user