pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Dashboard] Hide slice titles when they're empty (#8018)

This commit is contained in:
Erik Ritter 2019-08-12 21:55:46 -07:00 committed by John Bodley
parent 5375745193
commit 0754f294e9
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
superset/assets/src/components/EditableTitle.jsx
View File

@ -84,6 +84,8 @@ export default class EditableTitle extends React.PureComponent {
} }
handleBlur() { handleBlur() {
const title = this.state.title.trim();
if (!this.props.canEdit) { if (!this.props.canEdit) {
return; return;
} }
@ -92,7 +94,7 @@ export default class EditableTitle extends React.PureComponent {
isEditing: false, isEditing: false,
}); });
if (!this.state.title.length) { if (!title.length) {
this.setState({ this.setState({
title: this.state.lastTitle, title: this.state.lastTitle,
}); });
@ -100,14 +102,14 @@ export default class EditableTitle extends React.PureComponent {
return; return;
} }
if (this.state.lastTitle !== this.state.title) { if (this.state.lastTitle !== title) {
this.setState({ this.setState({
lastTitle: this.state.title, lastTitle: title,
}); });
} }
if (this.props.title !== this.state.title) { if (this.props.title !== title) {
this.props.onSaveTitle(this.state.title); this.props.onSaveTitle(title);
} }
} }

1
superset/assets/src/dashboard/components/SliceHeader.jsx
View File

@ -109,6 +109,7 @@ class SliceHeader extends React.PureComponent {
: '') : '')
} }
canEdit={editMode} canEdit={editMode}
emptyText=""
onSaveTitle={updateSliceName} onSaveTitle={updateSliceName}
showTooltip={false} showTooltip={false}
/> />