2019-01-15 18:53:27 -05:00
|
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
|
|
# or more contributor license agreements. See the NOTICE file
|
|
|
|
# distributed with this work for additional information
|
|
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
|
|
# to you under the Apache License, Version 2.0 (the
|
|
|
|
# "License"); you may not use this file except in compliance
|
|
|
|
# with the License. You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing,
|
|
|
|
# software distributed under the License is distributed on an
|
|
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
|
|
# KIND, either express or implied. See the License for the
|
|
|
|
# specific language governing permissions and limitations
|
|
|
|
# under the License.
|
2019-11-20 10:47:06 -05:00
|
|
|
# isort:skip_file
|
2016-11-10 02:08:22 -05:00
|
|
|
"""Unit tests for Superset"""
|
2019-11-12 14:10:36 -05:00
|
|
|
import cgi
|
2016-08-30 00:55:31 -04:00
|
|
|
import csv
|
2017-11-20 11:33:18 -05:00
|
|
|
import datetime
|
2016-02-10 12:34:09 -05:00
|
|
|
import doctest
|
2017-11-07 23:23:40 -05:00
|
|
|
import io
|
2016-08-30 00:55:31 -04:00
|
|
|
import json
|
2017-03-10 12:11:51 -05:00
|
|
|
import logging
|
2017-11-28 00:07:12 -05:00
|
|
|
import os
|
2020-01-03 11:55:39 -05:00
|
|
|
import pytz
|
2016-09-11 10:39:07 -04:00
|
|
|
import random
|
2018-06-02 14:08:43 -04:00
|
|
|
import re
|
2017-11-28 00:07:12 -05:00
|
|
|
import string
|
2020-01-16 00:51:13 -05:00
|
|
|
from typing import Any, Dict
|
2015-09-26 18:55:33 -04:00
|
|
|
import unittest
|
2019-03-27 17:08:36 -04:00
|
|
|
from unittest import mock
|
2016-03-28 11:09:46 -04:00
|
|
|
|
2017-11-20 11:33:18 -05:00
|
|
|
import pandas as pd
|
2017-09-13 23:59:03 -04:00
|
|
|
import sqlalchemy as sqla
|
2015-09-26 18:55:33 -04:00
|
|
|
|
2019-11-20 10:47:06 -05:00
|
|
|
from tests.test_app import app
|
|
|
|
from superset import dataframe, db, jinja_context, security_manager, sql_lab
|
2020-01-16 00:51:13 -05:00
|
|
|
from superset.common.query_context import QueryContext
|
|
|
|
from superset.connectors.connector_registry import ConnectorRegistry
|
2017-11-07 23:23:40 -05:00
|
|
|
from superset.connectors.sqla.models import SqlaTable
|
2019-06-08 14:27:13 -04:00
|
|
|
from superset.db_engine_specs.base import BaseEngineSpec
|
|
|
|
from superset.db_engine_specs.mssql import MssqlEngineSpec
|
2017-03-10 12:11:51 -05:00
|
|
|
from superset.models import core as models
|
2019-12-18 14:40:45 -05:00
|
|
|
from superset.models.dashboard import Dashboard
|
2019-12-17 19:17:49 -05:00
|
|
|
from superset.models.datasource_access_request import DatasourceAccessRequest
|
2019-12-18 14:40:45 -05:00
|
|
|
from superset.models.slice import Slice
|
2017-04-04 23:15:19 -04:00
|
|
|
from superset.models.sql_lab import Query
|
2020-01-03 11:55:39 -05:00
|
|
|
from superset.result_set import SupersetResultSet
|
2018-10-16 20:59:34 -04:00
|
|
|
from superset.utils import core as utils
|
2019-08-27 17:23:40 -04:00
|
|
|
from superset.views import core as views
|
2019-07-23 00:25:16 -04:00
|
|
|
from superset.views.database.views import DatabaseView
|
2019-10-18 17:44:27 -04:00
|
|
|
|
2016-11-10 02:08:22 -05:00
|
|
|
from .base_tests import SupersetTestCase
|
2016-03-28 11:09:46 -04:00
|
|
|
|
2015-09-26 18:55:33 -04:00
|
|
|
|
2016-11-10 02:08:22 -05:00
|
|
|
class CoreTests(SupersetTestCase):
|
2016-04-20 18:08:10 -04:00
|
|
|
def __init__(self, *args, **kwargs):
|
|
|
|
super(CoreTests, self).__init__(*args, **kwargs)
|
2016-06-12 14:01:16 -04:00
|
|
|
|
2015-09-26 18:55:33 -04:00
|
|
|
def setUp(self):
|
2017-04-04 23:15:19 -04:00
|
|
|
db.session.query(Query).delete()
|
2019-12-17 19:17:49 -05:00
|
|
|
db.session.query(DatasourceAccessRequest).delete()
|
2017-08-24 12:11:41 -04:00
|
|
|
db.session.query(models.Log).delete()
|
2019-11-20 10:47:06 -05:00
|
|
|
self.table_ids = {
|
|
|
|
tbl.table_name: tbl.id for tbl in (db.session.query(SqlaTable).all())
|
|
|
|
}
|
2015-09-26 18:55:33 -04:00
|
|
|
|
2016-03-28 11:09:46 -04:00
|
|
|
def tearDown(self):
|
2017-04-04 23:15:19 -04:00
|
|
|
db.session.query(Query).delete()
|
2015-09-22 14:36:54 -04:00
|
|
|
|
2017-02-10 04:17:49 -05:00
|
|
|
def test_login(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp("/login/", data=dict(username="admin", password="general"))
|
|
|
|
self.assertNotIn("User confirmation needed", resp)
|
2017-02-10 04:17:49 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp("/logout/", follow_redirects=True)
|
|
|
|
self.assertIn("User confirmation needed", resp)
|
2017-02-10 04:17:49 -05:00
|
|
|
|
|
|
|
resp = self.get_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/login/", data=dict(username="admin", password="wrongPassword")
|
|
|
|
)
|
|
|
|
self.assertIn("User confirmation needed", resp)
|
2017-02-10 04:17:49 -05:00
|
|
|
|
2018-11-12 13:08:20 -05:00
|
|
|
def test_dashboard_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.client.get("/superset/dashboard/-1/")
|
2018-11-12 13:08:20 -05:00
|
|
|
assert resp.status_code == 404
|
|
|
|
|
2016-10-07 19:24:39 -04:00
|
|
|
def test_slice_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
|
|
|
resp = self.get_resp("/superset/slice/{}/".format(slc.id))
|
|
|
|
assert "Time Column" in resp
|
|
|
|
assert "List Roles" in resp
|
2016-10-07 19:24:39 -04:00
|
|
|
|
|
|
|
# Testing overrides
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp("/superset/slice/{}/?standalone=true".format(slc.id))
|
2019-11-20 01:56:27 -05:00
|
|
|
assert '<div class="navbar' not in resp
|
2016-10-07 19:24:39 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.client.get("/superset/slice/-1/")
|
2018-11-12 13:08:20 -05:00
|
|
|
assert resp.status_code == 404
|
|
|
|
|
2020-01-16 00:51:13 -05:00
|
|
|
def _get_query_context_dict(self) -> Dict[str, Any]:
|
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girl Name Cloud", db.session)
|
|
|
|
return {
|
|
|
|
"datasource": {"id": slc.datasource_id, "type": slc.datasource_type},
|
|
|
|
"queries": [
|
|
|
|
{
|
|
|
|
"granularity": "ds",
|
|
|
|
"groupby": ["name"],
|
2020-01-28 01:28:42 -05:00
|
|
|
"metrics": [{"label": "sum__num"}],
|
2020-01-16 00:51:13 -05:00
|
|
|
"filters": [],
|
|
|
|
"row_limit": 100,
|
|
|
|
}
|
|
|
|
],
|
|
|
|
}
|
|
|
|
|
|
|
|
def test_viz_cache_key(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2018-01-28 12:46:13 -05:00
|
|
|
|
|
|
|
viz = slc.viz
|
|
|
|
qobj = viz.query_obj()
|
|
|
|
cache_key = viz.cache_key(qobj)
|
|
|
|
self.assertEqual(cache_key, viz.cache_key(qobj))
|
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
qobj["groupby"] = []
|
2018-01-28 12:46:13 -05:00
|
|
|
self.assertNotEqual(cache_key, viz.cache_key(qobj))
|
|
|
|
|
2020-01-16 00:51:13 -05:00
|
|
|
def test_cache_key_changes_when_datasource_is_updated(self):
|
|
|
|
qc_dict = self._get_query_context_dict()
|
|
|
|
|
|
|
|
# construct baseline cache_key
|
|
|
|
query_context = QueryContext(**qc_dict)
|
|
|
|
query_object = query_context.queries[0]
|
|
|
|
cache_key_original = query_context.cache_key(query_object)
|
|
|
|
|
|
|
|
# make temporary change and revert it to refresh the changed_on property
|
|
|
|
datasource = ConnectorRegistry.get_datasource(
|
|
|
|
datasource_type=qc_dict["datasource"]["type"],
|
|
|
|
datasource_id=qc_dict["datasource"]["id"],
|
|
|
|
session=db.session,
|
|
|
|
)
|
|
|
|
description_original = datasource.description
|
|
|
|
datasource.description = "temporary description"
|
|
|
|
db.session.commit()
|
|
|
|
datasource.description = description_original
|
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
# create new QueryContext with unchanged attributes and extract new cache_key
|
|
|
|
query_context = QueryContext(**qc_dict)
|
|
|
|
query_object = query_context.queries[0]
|
|
|
|
cache_key_new = query_context.cache_key(query_object)
|
|
|
|
|
|
|
|
# the new cache_key should be different due to updated datasource
|
|
|
|
self.assertNotEqual(cache_key_original, cache_key_new)
|
|
|
|
|
2018-11-07 20:23:52 -05:00
|
|
|
def test_api_v1_query_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2020-01-16 00:51:13 -05:00
|
|
|
qc_dict = self._get_query_context_dict()
|
|
|
|
data = json.dumps(qc_dict)
|
|
|
|
resp = json.loads(self.get_resp("/api/v1/query/", {"query_context": data}))
|
|
|
|
self.assertEqual(resp[0]["rowcount"], 100)
|
2018-11-07 20:23:52 -05:00
|
|
|
|
2018-02-27 18:08:06 -05:00
|
|
|
def test_old_slice_json_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2016-10-07 19:24:39 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
json_endpoint = "/superset/explore_json/{}/{}/".format(
|
|
|
|
slc.datasource_type, slc.datasource_id
|
|
|
|
)
|
|
|
|
resp = self.get_resp(
|
|
|
|
json_endpoint, {"form_data": json.dumps(slc.viz.form_data)}
|
2017-02-16 20:28:35 -05:00
|
|
|
)
|
2016-10-07 19:24:39 -04:00
|
|
|
assert '"Jennifer"' in resp
|
|
|
|
|
2018-02-27 18:08:06 -05:00
|
|
|
def test_slice_json_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2018-02-27 18:08:06 -05:00
|
|
|
resp = self.get_resp(slc.explore_json_url)
|
|
|
|
assert '"Jennifer"' in resp
|
|
|
|
|
|
|
|
def test_old_slice_csv_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2017-01-11 10:53:24 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
csv_endpoint = "/superset/explore_json/{}/{}/?csv=true".format(
|
|
|
|
slc.datasource_type, slc.datasource_id
|
2017-02-16 20:28:35 -05:00
|
|
|
)
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp(csv_endpoint, {"form_data": json.dumps(slc.viz.form_data)})
|
|
|
|
assert "Jennifer," in resp
|
2017-01-11 10:53:24 -05:00
|
|
|
|
2018-02-27 18:08:06 -05:00
|
|
|
def test_slice_csv_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2018-02-27 18:08:06 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
csv_endpoint = "/superset/explore_json/?csv=true"
|
2018-02-27 18:08:06 -05:00
|
|
|
resp = self.get_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
csv_endpoint, {"form_data": json.dumps({"slice_id": slc.id})}
|
|
|
|
)
|
|
|
|
assert "Jennifer," in resp
|
2018-02-27 18:08:06 -05:00
|
|
|
|
2016-09-22 12:53:14 -04:00
|
|
|
def test_admin_only_permissions(self):
|
|
|
|
def assert_admin_permission_in(role_name, assert_func):
|
2018-03-27 19:46:02 -04:00
|
|
|
role = security_manager.find_role(role_name)
|
2016-09-22 12:53:14 -04:00
|
|
|
permissions = [p.permission.name for p in role.permissions]
|
2019-06-25 16:34:48 -04:00
|
|
|
assert_func("can_sync_druid_source", permissions)
|
|
|
|
assert_func("can_approve", permissions)
|
2016-09-22 12:53:14 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
assert_admin_permission_in("Admin", self.assertIn)
|
|
|
|
assert_admin_permission_in("Alpha", self.assertNotIn)
|
|
|
|
assert_admin_permission_in("Gamma", self.assertNotIn)
|
2016-09-22 12:53:14 -04:00
|
|
|
|
|
|
|
def test_admin_only_menu_views(self):
|
|
|
|
def assert_admin_view_menus_in(role_name, assert_func):
|
2018-03-27 19:46:02 -04:00
|
|
|
role = security_manager.find_role(role_name)
|
2016-09-22 12:53:14 -04:00
|
|
|
view_menus = [p.view_menu.name for p in role.permissions]
|
2019-06-25 16:34:48 -04:00
|
|
|
assert_func("ResetPasswordView", view_menus)
|
|
|
|
assert_func("RoleModelView", view_menus)
|
|
|
|
assert_func("Security", view_menus)
|
|
|
|
assert_func("SQL Lab", view_menus)
|
2016-09-22 12:53:14 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
assert_admin_view_menus_in("Admin", self.assertIn)
|
|
|
|
assert_admin_view_menus_in("Alpha", self.assertNotIn)
|
|
|
|
assert_admin_view_menus_in("Gamma", self.assertNotIn)
|
2016-09-22 12:53:14 -04:00
|
|
|
|
2016-04-20 18:08:10 -04:00
|
|
|
def test_save_slice(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2019-11-20 10:47:06 -05:00
|
|
|
slice_name = f"Energy Sankey"
|
2016-11-17 14:58:33 -05:00
|
|
|
slice_id = self.get_slice(slice_name, db.session).id
|
2019-11-20 10:47:06 -05:00
|
|
|
copy_name = f"Test Sankey Save_{random.random()}"
|
2019-06-25 16:34:48 -04:00
|
|
|
tbl_id = self.table_ids.get("energy_usage")
|
2019-11-20 10:47:06 -05:00
|
|
|
new_slice_name = f"Test Sankey Overwrite_{random.random()}"
|
2016-04-20 18:08:10 -04:00
|
|
|
|
2017-02-16 20:28:35 -05:00
|
|
|
url = (
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/explore/table/{}/?slice_name={}&"
|
|
|
|
"action={}&datasource_name=energy_usage"
|
|
|
|
)
|
2017-02-16 20:28:35 -05:00
|
|
|
|
|
|
|
form_data = {
|
2019-06-25 16:34:48 -04:00
|
|
|
"viz_type": "sankey",
|
|
|
|
"groupby": "target",
|
|
|
|
"metric": "sum__value",
|
|
|
|
"row_limit": 5000,
|
|
|
|
"slice_id": slice_id,
|
2017-02-16 20:28:35 -05:00
|
|
|
}
|
|
|
|
# Changing name and save as a new slice
|
2019-11-20 10:47:06 -05:00
|
|
|
resp = self.client.post(
|
2019-06-25 16:34:48 -04:00
|
|
|
url.format(tbl_id, copy_name, "saveas"),
|
2019-11-20 10:47:06 -05:00
|
|
|
data={"form_data": json.dumps(form_data)},
|
2017-02-16 20:28:35 -05:00
|
|
|
)
|
2019-11-20 10:47:06 -05:00
|
|
|
db.session.expunge_all()
|
|
|
|
new_slice_id = resp.json["form_data"]["slice_id"]
|
2019-12-18 14:40:45 -05:00
|
|
|
slc = db.session.query(Slice).filter_by(id=new_slice_id).one()
|
2019-11-20 10:47:06 -05:00
|
|
|
|
|
|
|
self.assertEqual(slc.slice_name, copy_name)
|
|
|
|
form_data.pop("slice_id") # We don't save the slice id when saving as
|
|
|
|
self.assertEqual(slc.viz.form_data, form_data)
|
2017-02-16 20:28:35 -05:00
|
|
|
|
|
|
|
form_data = {
|
2019-06-25 16:34:48 -04:00
|
|
|
"viz_type": "sankey",
|
|
|
|
"groupby": "source",
|
|
|
|
"metric": "sum__value",
|
|
|
|
"row_limit": 5000,
|
|
|
|
"slice_id": new_slice_id,
|
|
|
|
"time_range": "now",
|
2017-02-16 20:28:35 -05:00
|
|
|
}
|
|
|
|
# Setting the name back to its original name by overwriting new slice
|
2019-11-20 10:47:06 -05:00
|
|
|
self.client.post(
|
2019-06-25 16:34:48 -04:00
|
|
|
url.format(tbl_id, new_slice_name, "overwrite"),
|
2019-11-20 10:47:06 -05:00
|
|
|
data={"form_data": json.dumps(form_data)},
|
2017-02-16 20:28:35 -05:00
|
|
|
)
|
2019-11-20 10:47:06 -05:00
|
|
|
db.session.expunge_all()
|
2019-12-18 14:40:45 -05:00
|
|
|
slc = db.session.query(Slice).filter_by(id=new_slice_id).one()
|
2019-11-20 10:47:06 -05:00
|
|
|
self.assertEqual(slc.slice_name, new_slice_name)
|
|
|
|
self.assertEqual(slc.viz.form_data, form_data)
|
|
|
|
|
|
|
|
# Cleanup
|
2017-02-16 20:28:35 -05:00
|
|
|
db.session.delete(slc)
|
2019-11-20 10:47:06 -05:00
|
|
|
db.session.commit()
|
2016-11-17 14:58:33 -05:00
|
|
|
|
2016-12-16 17:23:48 -05:00
|
|
|
def test_filter_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slice_name = "Energy Sankey"
|
2016-12-16 17:23:48 -05:00
|
|
|
slice_id = self.get_slice(slice_name, db.session).id
|
|
|
|
db.session.commit()
|
2019-06-25 16:34:48 -04:00
|
|
|
tbl_id = self.table_ids.get("energy_usage")
|
2017-03-10 12:11:51 -05:00
|
|
|
table = db.session.query(SqlaTable).filter(SqlaTable.id == tbl_id)
|
2016-12-16 17:23:48 -05:00
|
|
|
table.filter_select_enabled = True
|
|
|
|
url = (
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/filter/table/{}/target/?viz_type=sankey&groupby=source"
|
|
|
|
"&metric=sum__value&flt_col_0=source&flt_op_0=in&flt_eq_0=&"
|
|
|
|
"slice_id={}&datasource_name=energy_usage&"
|
|
|
|
"datasource_id=1&datasource_type=table"
|
|
|
|
)
|
2016-12-16 17:23:48 -05:00
|
|
|
|
|
|
|
# Changing name
|
|
|
|
resp = self.get_resp(url.format(tbl_id, slice_id))
|
|
|
|
assert len(resp) > 0
|
2019-06-25 16:34:48 -04:00
|
|
|
assert "Carbon Dioxide" in resp
|
2016-12-16 17:23:48 -05:00
|
|
|
|
[wip] dashboard builder v2 (#4528)
* [dashboard builder] Add dir structure for dashboard/v2, simplified Header, split pane, Draggable side panel
[grid] add <DashboardGrid />, <ResizableContainer />, and initial grid components.
[grid] gridComponents/ directory, add fixtures/ directory and test layout, add <Column />
[grid] working grid with gutters
[grid] design tweaks and polish, add <Tabs />
[header] add gradient header logo and favicon
[dnd] begin adding dnd functionality
[dnd] add util/isValidChild.js
[react-beautiful-dnd] iterate on dnd until blocked
[dnd] refactor to use react-dnd
[react-dnd] refactor to use composable <DashboardComponent /> structure
[dnd] factor out DashboardComponent, let components render dropInidcator and set draggableRef, add draggable tabs
[dnd] refactor to use redux, add DashboardComponent and DashboardGrid containers
[dragdroppable] rename horizontal/vertical => row/column
[builder] refactor into HoverMenu, add WithPopoverMenu
[builder] add editable header and disableDragDrop prop for Dragdroppable's
[builder] make tabs editable
[builder] add generic popover dropdown and header row style editability
[builder] add hover rowStyle dropdown, make row styles editable
[builder] add some new component icons, add popover with delete to charts
[builder] add preview icons, add popover menu to rows.
[builder] add IconButton and RowStyleDropdown
[resizable] use ResizableContainer instead of DimensionProvider, fix resize and delete bugs
[builder] fix bug with spacer
[builder] clean up, header.size => header.headerSize
[builder] support more drag/drop combinations by wrapping some components in rows upon drop. fix within list drop index. refactor some utils.
[builder][tabs] fix broken add tab button
[dashboard builder] don't pass dashboard layout to all dashboard components, improve drop indicator logic, fix delete component pure component bug
[dnd] refactor drop position logic
* fix rebase error, clean up css organization and use @less vars
* [dashboard-builder] add top-level tabs + undo-redo (#4626)
* [top-level-tabs] initial working version of top-level tabs
* [top-level-tabs] simplify redux and disable ability to displace top-level tabs with other tabs
* [top-level-tabs] improve tab drag and drop css
* [undo-redo] add redux undo redo
* [dnd] clean up dropResult shape, add new component source id + type, use css for drop indicator instead of styles and fix tab indicators.
* [top-level-tabs] add 'Collapse tab content' to delete tabs button
* [dnd] add depth validation to drag and drop logic
* [dashboard-builder] add resize action, enforce minimum width of columns, column children inherit column size when necessary, meta.rowStyle => meta.background, add background to columns
* [dashboard-builder] make sure getChildWidth returns a number
* [dashboard builder] static layout + toasts (#4763)
* [dashboard-builder] remove spacer component
* [dashboard-builder] better transparent indicator, better grid gutter logic, no dragging top-level tabs, headers are multiples of grid unit, fix row height granularity, update redux state key dashboard => dashboardLayout
* [dashboard-builder] don't blast column child dimensions on resize
* [dashboard-builder] ResizableContainer min size can't be smaller than size, fix row style, role=none on WithPopoverMenu container
* [edit mode] add edit mode to redux and propogate to all <DashboardComponent />s
* [toasts] add Toast component, ToastPresenter container and component, and toast redux actions + reducers
* [dashboard-builder] add info toast when dropResult overflows parent
* [dashboard builder] git mv to src/ post-rebase
* Dashboard builder rebased + linted (#4849)
* define dashboard redux state
* update dashboard state reducer
* dashboard layout converter + grid render
* builder pane + slice adder
* Dashboard header + slice header controls
* fix linting
* 2nd code review comments
* [dashboard builder] improve perf (#4855)
* address major perf + css issues
[dashboard builder] fix dashboard filters and some css
[dashboard builder] use VIZ_TYPES, move stricter .eslintrc to dashboard/, more css fixes
[builder] delete GridCell and GridLayout, remove some unused css. fix broken tabs.
* [builder] fix errors post-rebase
* [builder] add support for custom DragDroppable drag layer and add AddSliceDragPreview
* [AddSliceDragPreview] fix type check
* [dashboard builder] add prettier and update all files
* [dashboard builder] merge v2/ directory int dashboard/
* [dashboard builder] move component/*Container => containers/*
* add sticky tabs + sidepane, better tabs perf, better container hierarchy, better chart header (#4893)
* dashboard header, slice header UI improvement
* add slider and sticky
* dashboard header, slice header UI improvement
* make builder pane floating
* [dashboard builder] add sticky top-level tabs, refactor for performant tabs
* [dashboard builder] visually distinct containers, icons for undo-redo, fix some isValidChild bugs
* [dashboard builder] better undo redo <> save changes state, notify upon reaching undo limit
* [dashboard builder] hook up edit + create component actions to saved-state pop.
* [dashboard builder] visual refinement, refactor Dashboard header content and updates into layout for undo-redo, refactor save dashboard modal to use toasts instead of notify.
* [dashboard builder] refactor chart name update logic to use layout for undo redo, save slice name changes on dashboard save
* add slider and sticky
* [dashboard builder] fix layout converter slice_id + chartId type casting, don't change grid size upon edit (perf)
* [dashboard builder] don't set version key in getInitialState
* [dashboard builder] make top level tabs addition/removal undoable, fix double sticky tabs + side panel.
* [dashboard builder] fix sticky tabs offset bug
* [dashboard builder] fix drag preview width, css polish, fix rebase issue
* [dashboard builder] fix side pane labels and hove z-index
* Markdown for dashboard (#4962)
* fix dashboard server-side unit tests (#5009)
* Dashboard save button (#4979)
* save button
* fix slices list height
* save custom css
* merge save-dash changes from dashboard v1
https://github.com/apache/incubator-superset/pull/4900
https://github.com/apache/incubator-superset/pull/5051
* [dashboard v2] check for default_filters before json_loads-ing them (#5064)
[dashboard v2] check for default_filters before json-loads-ing them
* [dashboard v2] fix bugs from rebase
* [dashboard v2] tests! (#5066)
* [dashboard v2][tests] add tests for newComponentFactory, isValidChild, dropOverflowsParent, and dnd-reorder
* [dashboard v2][tests] add tests for componentIsResizable, findParentId, getChartIdsFromLayout, newEntitiesFromDrop, and getDropPosition
* [dashboard v2][tests] add mockStore, mockState, and tests for DragDroppable, DashboardBuilder, DashboardGrid, ToastPresenter, and Toast
* [dashboard builder][tests] separate files for state tree fixtures, add ChartHolder, Chart, Divider, Header, Row tests and WithDragDropContext helper
* [dashboard v2][tests] fix dragdrop context with util/getDragDropManager, add test for menu/* and resizable/*, and new components
* [dashboard v2][tests] fix and re-write Dashboard tests, add getFormDataWithExtraFilters_spec
* [dashboard v2][tests] add reducer tests, fix lint error
* [dashboard-v2][tests] add actions/dashboardLayout_spec
* [dashboard v2] fix some prop bugs, open side pane on edit, fix slice name bug
* [dashboard v2] fix slice name save bug
* [dashboard v2] fix lint errors
* [dashboard v2] fix filters bug and add test
* [dashboard v2] fix getFormDataWithExtraFilters_spec
* [dashboard v2] logging updates (#5087)
* [dashboard v2] initial logging refactor
* [dashboard v2] clean up logger
* [logger] update explore with new log events, add refresh dashboard + refresh dashboard chart actions
* [logging] add logger_spec.js, fix reducers/dashboardState_spec + gridComponents/Chart_spec
* [dashboard v2][logging] refactor for bulk logging in python
* [logging] tweak python, fix and remove dup start_offset entries
* [dashboard v2][logging] add dashboard_first_load event
* [dashboard v2][logging] add slice_ids to dashboard pane load event
* [tests] fix npm test script
* Fix: update slices list when add/remove multiple slices (#5138)
* [dashboard v2] add v1 switch (#5126)
* [dashboard] copy all dashboard v1 into working v1 switch
* [dashboard] add functional v1 <> v2 switch with messaging
* [dashboard] add v2 logging to v1 dashboard, add read-v2-changes link, add client logging to track v1 <> v2 switches
* [dashboard] Remove default values for feedback url + v2 auto convert date
* [dashboard v2] fix misc UI/UX issues
* [dashboard v2] fix Markdown persistance issues and css, fix copy dash title, don't enforce shallow hovering with drop indicator
* [dashboard v2] improve non-shallow drop target UX, fix Markdown drop indicator, clarify slice adder filter/sort
* [dashboard v2] delete empty rows on drag or delete events that leave them without children, add test
* [dashboard v2] improve v1<>v2 switch modals, add convert to v2 badge in v1, fix unsaved changes issue in preview mode, don't auto convert column child widths for now
* [dashboard v2][dnd] add drop position cache to fix non-shallow drops
* [dashboard] fix test script with glob instead of recurse, fix tests, add temp fix for tab nesting, ignore v1 lint errors
* [dashboard] v2 badge style tweaks, add back v1 _set_dash_metadata for v1 editing
* [dashboard] fix python linting and tests
* [dashboard] lint tests
* add slice from explore view (#5141)
* Fix dashboard position row data (#5131)
* add slice_name to markdown
(cherry picked from commit 14b01f1)
* set min grid width be 1 column
* remove empty column
* check total columns count <= 12
* scan position data and fix rows
* fix dashboard url with default_filters
* [dashboard v2] better grid drop ux, fix tab bugs 🐛 (#5151)
* [dashboard v2] add empty droptarget to dashboard grid for better ux and update test
* [dashboard] reset tab index upon top-level tab deletion, fix findparentid bug
* [dashboard] update v1<>v2 modal link for tracking
* Fix: Should pass slice_can_edit flag down (#5159)
* [dash builder fix] combine markdown and slice name, slice picker height (#5165)
* combine markdown code and markdown slice name
* allow dynamic height for slice picker cell
* add word break for long datasource name
* [fix] new dashboard state (#5213)
* [dashboard v2] ui + ux fixes (#5208)
* [dashboard v2] use <Loading /> throughout, small loading gif, improve row/column visual hierarchy, add cached data pop
* [dashboard v2] lots of polish
* [dashboard v2] remove markdown padding on edit, more opaque slice drag preview, unsavedChanges=true upon moving a component, fix initial load logging.
* [dashboard v2] gray loading.gif, sticky header, undo/redo keyboard shortcuts, fix move component saved changes update, v0 double scrollbar fix
* [dashboard v2] move UndoRedoKeylisteners into Header, render only in edit mode, show visual feedback for keyboard shortcut, hide hover menu in top-level tabs
* [dashboard v2] fix grid + sidepane height issues
* [dashboard v2] add auto-resize functionality, update tests. cache findParentId results.
* [dashboard v2][tests] add getDetailedComponentWidth_spec.js
* [dashboard v2] fix lint
* [fix] layout converter fix (#5218)
* [fix] layout converter fix
* add changed_on into initial sliceEntity data
* add unit tests for SliceAdder component
* remove old fixtures file
* [dashboard v2] remove webpack-cli, fresh yarn.lock post-rebase
* [dashboard v2] lint javascript
* [dashboard v2] fix python tests
* [Fix] import/export dash in V2 (#5273)
* [dashboard v2] add markdown tests (#5275)
* [dashboard v2] add Markdown tests
* [dashboard v2][mocks] fix markdown mock
2018-06-25 12:17:22 -04:00
|
|
|
def test_slice_data(self):
|
|
|
|
# slice data should have some required attributes
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
[wip] dashboard builder v2 (#4528)
* [dashboard builder] Add dir structure for dashboard/v2, simplified Header, split pane, Draggable side panel
[grid] add <DashboardGrid />, <ResizableContainer />, and initial grid components.
[grid] gridComponents/ directory, add fixtures/ directory and test layout, add <Column />
[grid] working grid with gutters
[grid] design tweaks and polish, add <Tabs />
[header] add gradient header logo and favicon
[dnd] begin adding dnd functionality
[dnd] add util/isValidChild.js
[react-beautiful-dnd] iterate on dnd until blocked
[dnd] refactor to use react-dnd
[react-dnd] refactor to use composable <DashboardComponent /> structure
[dnd] factor out DashboardComponent, let components render dropInidcator and set draggableRef, add draggable tabs
[dnd] refactor to use redux, add DashboardComponent and DashboardGrid containers
[dragdroppable] rename horizontal/vertical => row/column
[builder] refactor into HoverMenu, add WithPopoverMenu
[builder] add editable header and disableDragDrop prop for Dragdroppable's
[builder] make tabs editable
[builder] add generic popover dropdown and header row style editability
[builder] add hover rowStyle dropdown, make row styles editable
[builder] add some new component icons, add popover with delete to charts
[builder] add preview icons, add popover menu to rows.
[builder] add IconButton and RowStyleDropdown
[resizable] use ResizableContainer instead of DimensionProvider, fix resize and delete bugs
[builder] fix bug with spacer
[builder] clean up, header.size => header.headerSize
[builder] support more drag/drop combinations by wrapping some components in rows upon drop. fix within list drop index. refactor some utils.
[builder][tabs] fix broken add tab button
[dashboard builder] don't pass dashboard layout to all dashboard components, improve drop indicator logic, fix delete component pure component bug
[dnd] refactor drop position logic
* fix rebase error, clean up css organization and use @less vars
* [dashboard-builder] add top-level tabs + undo-redo (#4626)
* [top-level-tabs] initial working version of top-level tabs
* [top-level-tabs] simplify redux and disable ability to displace top-level tabs with other tabs
* [top-level-tabs] improve tab drag and drop css
* [undo-redo] add redux undo redo
* [dnd] clean up dropResult shape, add new component source id + type, use css for drop indicator instead of styles and fix tab indicators.
* [top-level-tabs] add 'Collapse tab content' to delete tabs button
* [dnd] add depth validation to drag and drop logic
* [dashboard-builder] add resize action, enforce minimum width of columns, column children inherit column size when necessary, meta.rowStyle => meta.background, add background to columns
* [dashboard-builder] make sure getChildWidth returns a number
* [dashboard builder] static layout + toasts (#4763)
* [dashboard-builder] remove spacer component
* [dashboard-builder] better transparent indicator, better grid gutter logic, no dragging top-level tabs, headers are multiples of grid unit, fix row height granularity, update redux state key dashboard => dashboardLayout
* [dashboard-builder] don't blast column child dimensions on resize
* [dashboard-builder] ResizableContainer min size can't be smaller than size, fix row style, role=none on WithPopoverMenu container
* [edit mode] add edit mode to redux and propogate to all <DashboardComponent />s
* [toasts] add Toast component, ToastPresenter container and component, and toast redux actions + reducers
* [dashboard-builder] add info toast when dropResult overflows parent
* [dashboard builder] git mv to src/ post-rebase
* Dashboard builder rebased + linted (#4849)
* define dashboard redux state
* update dashboard state reducer
* dashboard layout converter + grid render
* builder pane + slice adder
* Dashboard header + slice header controls
* fix linting
* 2nd code review comments
* [dashboard builder] improve perf (#4855)
* address major perf + css issues
[dashboard builder] fix dashboard filters and some css
[dashboard builder] use VIZ_TYPES, move stricter .eslintrc to dashboard/, more css fixes
[builder] delete GridCell and GridLayout, remove some unused css. fix broken tabs.
* [builder] fix errors post-rebase
* [builder] add support for custom DragDroppable drag layer and add AddSliceDragPreview
* [AddSliceDragPreview] fix type check
* [dashboard builder] add prettier and update all files
* [dashboard builder] merge v2/ directory int dashboard/
* [dashboard builder] move component/*Container => containers/*
* add sticky tabs + sidepane, better tabs perf, better container hierarchy, better chart header (#4893)
* dashboard header, slice header UI improvement
* add slider and sticky
* dashboard header, slice header UI improvement
* make builder pane floating
* [dashboard builder] add sticky top-level tabs, refactor for performant tabs
* [dashboard builder] visually distinct containers, icons for undo-redo, fix some isValidChild bugs
* [dashboard builder] better undo redo <> save changes state, notify upon reaching undo limit
* [dashboard builder] hook up edit + create component actions to saved-state pop.
* [dashboard builder] visual refinement, refactor Dashboard header content and updates into layout for undo-redo, refactor save dashboard modal to use toasts instead of notify.
* [dashboard builder] refactor chart name update logic to use layout for undo redo, save slice name changes on dashboard save
* add slider and sticky
* [dashboard builder] fix layout converter slice_id + chartId type casting, don't change grid size upon edit (perf)
* [dashboard builder] don't set version key in getInitialState
* [dashboard builder] make top level tabs addition/removal undoable, fix double sticky tabs + side panel.
* [dashboard builder] fix sticky tabs offset bug
* [dashboard builder] fix drag preview width, css polish, fix rebase issue
* [dashboard builder] fix side pane labels and hove z-index
* Markdown for dashboard (#4962)
* fix dashboard server-side unit tests (#5009)
* Dashboard save button (#4979)
* save button
* fix slices list height
* save custom css
* merge save-dash changes from dashboard v1
https://github.com/apache/incubator-superset/pull/4900
https://github.com/apache/incubator-superset/pull/5051
* [dashboard v2] check for default_filters before json_loads-ing them (#5064)
[dashboard v2] check for default_filters before json-loads-ing them
* [dashboard v2] fix bugs from rebase
* [dashboard v2] tests! (#5066)
* [dashboard v2][tests] add tests for newComponentFactory, isValidChild, dropOverflowsParent, and dnd-reorder
* [dashboard v2][tests] add tests for componentIsResizable, findParentId, getChartIdsFromLayout, newEntitiesFromDrop, and getDropPosition
* [dashboard v2][tests] add mockStore, mockState, and tests for DragDroppable, DashboardBuilder, DashboardGrid, ToastPresenter, and Toast
* [dashboard builder][tests] separate files for state tree fixtures, add ChartHolder, Chart, Divider, Header, Row tests and WithDragDropContext helper
* [dashboard v2][tests] fix dragdrop context with util/getDragDropManager, add test for menu/* and resizable/*, and new components
* [dashboard v2][tests] fix and re-write Dashboard tests, add getFormDataWithExtraFilters_spec
* [dashboard v2][tests] add reducer tests, fix lint error
* [dashboard-v2][tests] add actions/dashboardLayout_spec
* [dashboard v2] fix some prop bugs, open side pane on edit, fix slice name bug
* [dashboard v2] fix slice name save bug
* [dashboard v2] fix lint errors
* [dashboard v2] fix filters bug and add test
* [dashboard v2] fix getFormDataWithExtraFilters_spec
* [dashboard v2] logging updates (#5087)
* [dashboard v2] initial logging refactor
* [dashboard v2] clean up logger
* [logger] update explore with new log events, add refresh dashboard + refresh dashboard chart actions
* [logging] add logger_spec.js, fix reducers/dashboardState_spec + gridComponents/Chart_spec
* [dashboard v2][logging] refactor for bulk logging in python
* [logging] tweak python, fix and remove dup start_offset entries
* [dashboard v2][logging] add dashboard_first_load event
* [dashboard v2][logging] add slice_ids to dashboard pane load event
* [tests] fix npm test script
* Fix: update slices list when add/remove multiple slices (#5138)
* [dashboard v2] add v1 switch (#5126)
* [dashboard] copy all dashboard v1 into working v1 switch
* [dashboard] add functional v1 <> v2 switch with messaging
* [dashboard] add v2 logging to v1 dashboard, add read-v2-changes link, add client logging to track v1 <> v2 switches
* [dashboard] Remove default values for feedback url + v2 auto convert date
* [dashboard v2] fix misc UI/UX issues
* [dashboard v2] fix Markdown persistance issues and css, fix copy dash title, don't enforce shallow hovering with drop indicator
* [dashboard v2] improve non-shallow drop target UX, fix Markdown drop indicator, clarify slice adder filter/sort
* [dashboard v2] delete empty rows on drag or delete events that leave them without children, add test
* [dashboard v2] improve v1<>v2 switch modals, add convert to v2 badge in v1, fix unsaved changes issue in preview mode, don't auto convert column child widths for now
* [dashboard v2][dnd] add drop position cache to fix non-shallow drops
* [dashboard] fix test script with glob instead of recurse, fix tests, add temp fix for tab nesting, ignore v1 lint errors
* [dashboard] v2 badge style tweaks, add back v1 _set_dash_metadata for v1 editing
* [dashboard] fix python linting and tests
* [dashboard] lint tests
* add slice from explore view (#5141)
* Fix dashboard position row data (#5131)
* add slice_name to markdown
(cherry picked from commit 14b01f1)
* set min grid width be 1 column
* remove empty column
* check total columns count <= 12
* scan position data and fix rows
* fix dashboard url with default_filters
* [dashboard v2] better grid drop ux, fix tab bugs 🐛 (#5151)
* [dashboard v2] add empty droptarget to dashboard grid for better ux and update test
* [dashboard] reset tab index upon top-level tab deletion, fix findparentid bug
* [dashboard] update v1<>v2 modal link for tracking
* Fix: Should pass slice_can_edit flag down (#5159)
* [dash builder fix] combine markdown and slice name, slice picker height (#5165)
* combine markdown code and markdown slice name
* allow dynamic height for slice picker cell
* add word break for long datasource name
* [fix] new dashboard state (#5213)
* [dashboard v2] ui + ux fixes (#5208)
* [dashboard v2] use <Loading /> throughout, small loading gif, improve row/column visual hierarchy, add cached data pop
* [dashboard v2] lots of polish
* [dashboard v2] remove markdown padding on edit, more opaque slice drag preview, unsavedChanges=true upon moving a component, fix initial load logging.
* [dashboard v2] gray loading.gif, sticky header, undo/redo keyboard shortcuts, fix move component saved changes update, v0 double scrollbar fix
* [dashboard v2] move UndoRedoKeylisteners into Header, render only in edit mode, show visual feedback for keyboard shortcut, hide hover menu in top-level tabs
* [dashboard v2] fix grid + sidepane height issues
* [dashboard v2] add auto-resize functionality, update tests. cache findParentId results.
* [dashboard v2][tests] add getDetailedComponentWidth_spec.js
* [dashboard v2] fix lint
* [fix] layout converter fix (#5218)
* [fix] layout converter fix
* add changed_on into initial sliceEntity data
* add unit tests for SliceAdder component
* remove old fixtures file
* [dashboard v2] remove webpack-cli, fresh yarn.lock post-rebase
* [dashboard v2] lint javascript
* [dashboard v2] fix python tests
* [Fix] import/export dash in V2 (#5273)
* [dashboard v2] add markdown tests (#5275)
* [dashboard v2] add Markdown tests
* [dashboard v2][mocks] fix markdown mock
2018-06-25 12:17:22 -04:00
|
|
|
slc_data_attributes = slc.data.keys()
|
2019-06-25 16:34:48 -04:00
|
|
|
assert "changed_on" in slc_data_attributes
|
|
|
|
assert "modified" in slc_data_attributes
|
[wip] dashboard builder v2 (#4528)
* [dashboard builder] Add dir structure for dashboard/v2, simplified Header, split pane, Draggable side panel
[grid] add <DashboardGrid />, <ResizableContainer />, and initial grid components.
[grid] gridComponents/ directory, add fixtures/ directory and test layout, add <Column />
[grid] working grid with gutters
[grid] design tweaks and polish, add <Tabs />
[header] add gradient header logo and favicon
[dnd] begin adding dnd functionality
[dnd] add util/isValidChild.js
[react-beautiful-dnd] iterate on dnd until blocked
[dnd] refactor to use react-dnd
[react-dnd] refactor to use composable <DashboardComponent /> structure
[dnd] factor out DashboardComponent, let components render dropInidcator and set draggableRef, add draggable tabs
[dnd] refactor to use redux, add DashboardComponent and DashboardGrid containers
[dragdroppable] rename horizontal/vertical => row/column
[builder] refactor into HoverMenu, add WithPopoverMenu
[builder] add editable header and disableDragDrop prop for Dragdroppable's
[builder] make tabs editable
[builder] add generic popover dropdown and header row style editability
[builder] add hover rowStyle dropdown, make row styles editable
[builder] add some new component icons, add popover with delete to charts
[builder] add preview icons, add popover menu to rows.
[builder] add IconButton and RowStyleDropdown
[resizable] use ResizableContainer instead of DimensionProvider, fix resize and delete bugs
[builder] fix bug with spacer
[builder] clean up, header.size => header.headerSize
[builder] support more drag/drop combinations by wrapping some components in rows upon drop. fix within list drop index. refactor some utils.
[builder][tabs] fix broken add tab button
[dashboard builder] don't pass dashboard layout to all dashboard components, improve drop indicator logic, fix delete component pure component bug
[dnd] refactor drop position logic
* fix rebase error, clean up css organization and use @less vars
* [dashboard-builder] add top-level tabs + undo-redo (#4626)
* [top-level-tabs] initial working version of top-level tabs
* [top-level-tabs] simplify redux and disable ability to displace top-level tabs with other tabs
* [top-level-tabs] improve tab drag and drop css
* [undo-redo] add redux undo redo
* [dnd] clean up dropResult shape, add new component source id + type, use css for drop indicator instead of styles and fix tab indicators.
* [top-level-tabs] add 'Collapse tab content' to delete tabs button
* [dnd] add depth validation to drag and drop logic
* [dashboard-builder] add resize action, enforce minimum width of columns, column children inherit column size when necessary, meta.rowStyle => meta.background, add background to columns
* [dashboard-builder] make sure getChildWidth returns a number
* [dashboard builder] static layout + toasts (#4763)
* [dashboard-builder] remove spacer component
* [dashboard-builder] better transparent indicator, better grid gutter logic, no dragging top-level tabs, headers are multiples of grid unit, fix row height granularity, update redux state key dashboard => dashboardLayout
* [dashboard-builder] don't blast column child dimensions on resize
* [dashboard-builder] ResizableContainer min size can't be smaller than size, fix row style, role=none on WithPopoverMenu container
* [edit mode] add edit mode to redux and propogate to all <DashboardComponent />s
* [toasts] add Toast component, ToastPresenter container and component, and toast redux actions + reducers
* [dashboard-builder] add info toast when dropResult overflows parent
* [dashboard builder] git mv to src/ post-rebase
* Dashboard builder rebased + linted (#4849)
* define dashboard redux state
* update dashboard state reducer
* dashboard layout converter + grid render
* builder pane + slice adder
* Dashboard header + slice header controls
* fix linting
* 2nd code review comments
* [dashboard builder] improve perf (#4855)
* address major perf + css issues
[dashboard builder] fix dashboard filters and some css
[dashboard builder] use VIZ_TYPES, move stricter .eslintrc to dashboard/, more css fixes
[builder] delete GridCell and GridLayout, remove some unused css. fix broken tabs.
* [builder] fix errors post-rebase
* [builder] add support for custom DragDroppable drag layer and add AddSliceDragPreview
* [AddSliceDragPreview] fix type check
* [dashboard builder] add prettier and update all files
* [dashboard builder] merge v2/ directory int dashboard/
* [dashboard builder] move component/*Container => containers/*
* add sticky tabs + sidepane, better tabs perf, better container hierarchy, better chart header (#4893)
* dashboard header, slice header UI improvement
* add slider and sticky
* dashboard header, slice header UI improvement
* make builder pane floating
* [dashboard builder] add sticky top-level tabs, refactor for performant tabs
* [dashboard builder] visually distinct containers, icons for undo-redo, fix some isValidChild bugs
* [dashboard builder] better undo redo <> save changes state, notify upon reaching undo limit
* [dashboard builder] hook up edit + create component actions to saved-state pop.
* [dashboard builder] visual refinement, refactor Dashboard header content and updates into layout for undo-redo, refactor save dashboard modal to use toasts instead of notify.
* [dashboard builder] refactor chart name update logic to use layout for undo redo, save slice name changes on dashboard save
* add slider and sticky
* [dashboard builder] fix layout converter slice_id + chartId type casting, don't change grid size upon edit (perf)
* [dashboard builder] don't set version key in getInitialState
* [dashboard builder] make top level tabs addition/removal undoable, fix double sticky tabs + side panel.
* [dashboard builder] fix sticky tabs offset bug
* [dashboard builder] fix drag preview width, css polish, fix rebase issue
* [dashboard builder] fix side pane labels and hove z-index
* Markdown for dashboard (#4962)
* fix dashboard server-side unit tests (#5009)
* Dashboard save button (#4979)
* save button
* fix slices list height
* save custom css
* merge save-dash changes from dashboard v1
https://github.com/apache/incubator-superset/pull/4900
https://github.com/apache/incubator-superset/pull/5051
* [dashboard v2] check for default_filters before json_loads-ing them (#5064)
[dashboard v2] check for default_filters before json-loads-ing them
* [dashboard v2] fix bugs from rebase
* [dashboard v2] tests! (#5066)
* [dashboard v2][tests] add tests for newComponentFactory, isValidChild, dropOverflowsParent, and dnd-reorder
* [dashboard v2][tests] add tests for componentIsResizable, findParentId, getChartIdsFromLayout, newEntitiesFromDrop, and getDropPosition
* [dashboard v2][tests] add mockStore, mockState, and tests for DragDroppable, DashboardBuilder, DashboardGrid, ToastPresenter, and Toast
* [dashboard builder][tests] separate files for state tree fixtures, add ChartHolder, Chart, Divider, Header, Row tests and WithDragDropContext helper
* [dashboard v2][tests] fix dragdrop context with util/getDragDropManager, add test for menu/* and resizable/*, and new components
* [dashboard v2][tests] fix and re-write Dashboard tests, add getFormDataWithExtraFilters_spec
* [dashboard v2][tests] add reducer tests, fix lint error
* [dashboard-v2][tests] add actions/dashboardLayout_spec
* [dashboard v2] fix some prop bugs, open side pane on edit, fix slice name bug
* [dashboard v2] fix slice name save bug
* [dashboard v2] fix lint errors
* [dashboard v2] fix filters bug and add test
* [dashboard v2] fix getFormDataWithExtraFilters_spec
* [dashboard v2] logging updates (#5087)
* [dashboard v2] initial logging refactor
* [dashboard v2] clean up logger
* [logger] update explore with new log events, add refresh dashboard + refresh dashboard chart actions
* [logging] add logger_spec.js, fix reducers/dashboardState_spec + gridComponents/Chart_spec
* [dashboard v2][logging] refactor for bulk logging in python
* [logging] tweak python, fix and remove dup start_offset entries
* [dashboard v2][logging] add dashboard_first_load event
* [dashboard v2][logging] add slice_ids to dashboard pane load event
* [tests] fix npm test script
* Fix: update slices list when add/remove multiple slices (#5138)
* [dashboard v2] add v1 switch (#5126)
* [dashboard] copy all dashboard v1 into working v1 switch
* [dashboard] add functional v1 <> v2 switch with messaging
* [dashboard] add v2 logging to v1 dashboard, add read-v2-changes link, add client logging to track v1 <> v2 switches
* [dashboard] Remove default values for feedback url + v2 auto convert date
* [dashboard v2] fix misc UI/UX issues
* [dashboard v2] fix Markdown persistance issues and css, fix copy dash title, don't enforce shallow hovering with drop indicator
* [dashboard v2] improve non-shallow drop target UX, fix Markdown drop indicator, clarify slice adder filter/sort
* [dashboard v2] delete empty rows on drag or delete events that leave them without children, add test
* [dashboard v2] improve v1<>v2 switch modals, add convert to v2 badge in v1, fix unsaved changes issue in preview mode, don't auto convert column child widths for now
* [dashboard v2][dnd] add drop position cache to fix non-shallow drops
* [dashboard] fix test script with glob instead of recurse, fix tests, add temp fix for tab nesting, ignore v1 lint errors
* [dashboard] v2 badge style tweaks, add back v1 _set_dash_metadata for v1 editing
* [dashboard] fix python linting and tests
* [dashboard] lint tests
* add slice from explore view (#5141)
* Fix dashboard position row data (#5131)
* add slice_name to markdown
(cherry picked from commit 14b01f1)
* set min grid width be 1 column
* remove empty column
* check total columns count <= 12
* scan position data and fix rows
* fix dashboard url with default_filters
* [dashboard v2] better grid drop ux, fix tab bugs 🐛 (#5151)
* [dashboard v2] add empty droptarget to dashboard grid for better ux and update test
* [dashboard] reset tab index upon top-level tab deletion, fix findparentid bug
* [dashboard] update v1<>v2 modal link for tracking
* Fix: Should pass slice_can_edit flag down (#5159)
* [dash builder fix] combine markdown and slice name, slice picker height (#5165)
* combine markdown code and markdown slice name
* allow dynamic height for slice picker cell
* add word break for long datasource name
* [fix] new dashboard state (#5213)
* [dashboard v2] ui + ux fixes (#5208)
* [dashboard v2] use <Loading /> throughout, small loading gif, improve row/column visual hierarchy, add cached data pop
* [dashboard v2] lots of polish
* [dashboard v2] remove markdown padding on edit, more opaque slice drag preview, unsavedChanges=true upon moving a component, fix initial load logging.
* [dashboard v2] gray loading.gif, sticky header, undo/redo keyboard shortcuts, fix move component saved changes update, v0 double scrollbar fix
* [dashboard v2] move UndoRedoKeylisteners into Header, render only in edit mode, show visual feedback for keyboard shortcut, hide hover menu in top-level tabs
* [dashboard v2] fix grid + sidepane height issues
* [dashboard v2] add auto-resize functionality, update tests. cache findParentId results.
* [dashboard v2][tests] add getDetailedComponentWidth_spec.js
* [dashboard v2] fix lint
* [fix] layout converter fix (#5218)
* [fix] layout converter fix
* add changed_on into initial sliceEntity data
* add unit tests for SliceAdder component
* remove old fixtures file
* [dashboard v2] remove webpack-cli, fresh yarn.lock post-rebase
* [dashboard v2] lint javascript
* [dashboard v2] fix python tests
* [Fix] import/export dash in V2 (#5273)
* [dashboard v2] add markdown tests (#5275)
* [dashboard v2] add Markdown tests
* [dashboard v2][mocks] fix markdown mock
2018-06-25 12:17:22 -04:00
|
|
|
|
2015-09-26 18:55:33 -04:00
|
|
|
def test_slices(self):
|
2016-06-20 12:18:03 -04:00
|
|
|
# Testing by hitting the two supported end points for all slices
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2019-12-18 14:40:45 -05:00
|
|
|
Slc = Slice
|
2016-03-28 11:09:46 -04:00
|
|
|
urls = []
|
2015-09-26 18:55:33 -04:00
|
|
|
for slc in db.session.query(Slc).all():
|
2016-03-28 11:09:46 -04:00
|
|
|
urls += [
|
2019-06-25 16:34:48 -04:00
|
|
|
(slc.slice_name, "explore", slc.slice_url),
|
|
|
|
(slc.slice_name, "explore_json", slc.explore_json_url),
|
2016-03-28 11:09:46 -04:00
|
|
|
]
|
2016-06-09 21:05:58 -04:00
|
|
|
for name, method, url in urls:
|
2019-06-25 16:34:48 -04:00
|
|
|
logging.info(f"[{name}]/[{method}]: {url}")
|
2019-08-19 01:36:27 -04:00
|
|
|
print(f"[{name}]/[{method}]: {url}")
|
2019-07-04 16:23:02 -04:00
|
|
|
resp = self.client.get(url)
|
|
|
|
self.assertEqual(resp.status_code, 200)
|
2015-09-26 18:55:33 -04:00
|
|
|
|
2017-06-13 12:44:26 -04:00
|
|
|
def test_tablemodelview_list(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2017-02-10 04:17:49 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/tablemodelview/list/"
|
2017-02-10 04:17:49 -05:00
|
|
|
resp = self.get_resp(url)
|
|
|
|
|
2017-06-13 12:44:26 -04:00
|
|
|
# assert that a table is listed
|
2017-03-10 12:11:51 -05:00
|
|
|
table = db.session.query(SqlaTable).first()
|
2017-02-10 04:17:49 -05:00
|
|
|
assert table.name in resp
|
2019-06-25 16:34:48 -04:00
|
|
|
assert "/superset/explore/table/{}".format(table.id) in resp
|
2017-02-10 04:17:49 -05:00
|
|
|
|
2017-06-13 12:44:26 -04:00
|
|
|
def test_add_slice(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2018-08-03 15:46:48 -04:00
|
|
|
# assert that /chart/add responds with 200
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/chart/add"
|
2017-06-13 12:44:26 -04:00
|
|
|
resp = self.client.get(url)
|
|
|
|
self.assertEqual(resp.status_code, 200)
|
|
|
|
|
2018-02-06 15:38:07 -05:00
|
|
|
def test_get_user_slices(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
userid = security_manager.find_user("admin").id
|
2020-01-23 11:25:15 -05:00
|
|
|
url = f"/sliceasync/api/read?_flt_0_created_by={userid}"
|
2018-02-06 15:38:07 -05:00
|
|
|
resp = self.client.get(url)
|
|
|
|
self.assertEqual(resp.status_code, 200)
|
|
|
|
|
2016-12-12 19:42:38 -05:00
|
|
|
def test_slices_V2(self):
|
|
|
|
# Add explore-v2-beta role to admin user
|
|
|
|
# Test all slice urls as user with with explore-v2-beta role
|
2019-06-25 16:34:48 -04:00
|
|
|
security_manager.add_role("explore-v2-beta")
|
2016-12-12 19:42:38 -05:00
|
|
|
|
2018-03-27 19:46:02 -04:00
|
|
|
security_manager.add_user(
|
2019-06-25 16:34:48 -04:00
|
|
|
"explore_beta",
|
|
|
|
"explore_beta",
|
|
|
|
" user",
|
|
|
|
"explore_beta@airbnb.com",
|
|
|
|
security_manager.find_role("explore-v2-beta"),
|
|
|
|
password="general",
|
|
|
|
)
|
|
|
|
self.login(username="explore_beta", password="general")
|
2016-12-12 19:42:38 -05:00
|
|
|
|
2019-12-18 14:40:45 -05:00
|
|
|
Slc = Slice
|
2016-12-12 19:42:38 -05:00
|
|
|
urls = []
|
|
|
|
for slc in db.session.query(Slc).all():
|
2019-06-25 16:34:48 -04:00
|
|
|
urls += [(slc.slice_name, "slice_url", slc.slice_url)]
|
2016-12-12 19:42:38 -05:00
|
|
|
for name, method, url in urls:
|
2019-06-25 16:34:48 -04:00
|
|
|
print(f"[{name}]/[{method}]: {url}")
|
2018-12-02 16:50:49 -05:00
|
|
|
self.client.get(url)
|
2016-12-12 19:42:38 -05:00
|
|
|
|
2016-02-10 12:34:09 -05:00
|
|
|
def test_doctests(self):
|
2016-12-01 22:53:23 -05:00
|
|
|
modules = [utils, models, sql_lab]
|
2016-02-10 12:34:09 -05:00
|
|
|
for mod in modules:
|
|
|
|
failed, tests = doctest.testmod(mod)
|
|
|
|
if failed:
|
2019-06-25 16:34:48 -04:00
|
|
|
raise Exception("Failed a doctest")
|
2016-02-10 12:34:09 -05:00
|
|
|
|
2016-03-28 11:09:46 -04:00
|
|
|
def test_misc(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
assert self.get_resp("/health") == "OK"
|
|
|
|
assert self.get_resp("/healthcheck") == "OK"
|
|
|
|
assert self.get_resp("/ping") == "OK"
|
2016-03-27 17:23:33 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
def test_testconn(self, username="admin"):
|
2017-10-16 23:15:16 -04:00
|
|
|
self.login(username=username)
|
2019-09-08 13:18:09 -04:00
|
|
|
database = utils.get_example_database()
|
2016-09-19 18:14:00 -04:00
|
|
|
|
|
|
|
# validate that the endpoint works with the password-masked sqlalchemy uri
|
2019-06-25 16:34:48 -04:00
|
|
|
data = json.dumps(
|
|
|
|
{
|
|
|
|
"uri": database.safe_sqlalchemy_uri(),
|
2019-09-08 13:18:09 -04:00
|
|
|
"name": "examples",
|
2019-06-25 16:34:48 -04:00
|
|
|
"impersonate_user": False,
|
|
|
|
}
|
|
|
|
)
|
2017-11-12 14:09:22 -05:00
|
|
|
response = self.client.post(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/testconn", data=data, content_type="application/json"
|
|
|
|
)
|
2016-09-17 15:32:41 -04:00
|
|
|
assert response.status_code == 200
|
2019-06-25 16:34:48 -04:00
|
|
|
assert response.headers["Content-Type"] == "application/json"
|
2016-09-17 15:32:41 -04:00
|
|
|
|
2016-09-19 18:14:00 -04:00
|
|
|
# validate that the endpoint works with the decrypted sqlalchemy uri
|
2019-06-25 16:34:48 -04:00
|
|
|
data = json.dumps(
|
|
|
|
{
|
|
|
|
"uri": database.sqlalchemy_uri_decrypted,
|
2019-09-08 13:18:09 -04:00
|
|
|
"name": "examples",
|
2019-06-25 16:34:48 -04:00
|
|
|
"impersonate_user": False,
|
|
|
|
}
|
|
|
|
)
|
2017-11-12 14:09:22 -05:00
|
|
|
response = self.client.post(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/testconn", data=data, content_type="application/json"
|
|
|
|
)
|
2016-09-17 15:32:41 -04:00
|
|
|
assert response.status_code == 200
|
2019-06-25 16:34:48 -04:00
|
|
|
assert response.headers["Content-Type"] == "application/json"
|
2016-09-17 15:32:41 -04:00
|
|
|
|
2017-09-13 23:59:03 -04:00
|
|
|
def test_custom_password_store(self):
|
2019-09-08 13:18:09 -04:00
|
|
|
database = utils.get_example_database()
|
2017-09-13 23:59:03 -04:00
|
|
|
conn_pre = sqla.engine.url.make_url(database.sqlalchemy_uri_decrypted)
|
|
|
|
|
|
|
|
def custom_password_store(uri):
|
2019-06-25 16:34:48 -04:00
|
|
|
return "password_store_test"
|
2017-09-13 23:59:03 -04:00
|
|
|
|
2018-01-09 16:14:20 -05:00
|
|
|
models.custom_password_store = custom_password_store
|
2017-09-13 23:59:03 -04:00
|
|
|
conn = sqla.engine.url.make_url(database.sqlalchemy_uri_decrypted)
|
|
|
|
if conn_pre.password:
|
2019-06-25 16:34:48 -04:00
|
|
|
assert conn.password == "password_store_test"
|
2017-09-13 23:59:03 -04:00
|
|
|
assert conn.password != conn_pre.password
|
2018-01-09 16:14:20 -05:00
|
|
|
# Disable for password store for later tests
|
|
|
|
models.custom_password_store = None
|
2017-09-13 23:59:03 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
def test_databaseview_edit(self, username="admin"):
|
2017-11-12 14:09:22 -05:00
|
|
|
# validate that sending a password-masked uri does not over-write the decrypted
|
|
|
|
# uri
|
2016-10-11 19:49:40 -04:00
|
|
|
self.login(username=username)
|
2019-09-08 13:18:09 -04:00
|
|
|
database = utils.get_example_database()
|
2016-10-11 19:49:40 -04:00
|
|
|
sqlalchemy_uri_decrypted = database.sqlalchemy_uri_decrypted
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "databaseview/edit/{}".format(database.id)
|
2016-10-11 19:49:40 -04:00
|
|
|
data = {k: database.__getattribute__(k) for k in DatabaseView.add_columns}
|
2019-06-25 16:34:48 -04:00
|
|
|
data["sqlalchemy_uri"] = database.safe_sqlalchemy_uri()
|
2016-10-19 12:17:08 -04:00
|
|
|
self.client.post(url, data=data)
|
2019-09-08 13:18:09 -04:00
|
|
|
database = utils.get_example_database()
|
2016-10-11 19:49:40 -04:00
|
|
|
self.assertEqual(sqlalchemy_uri_decrypted, database.sqlalchemy_uri_decrypted)
|
2016-09-19 18:14:00 -04:00
|
|
|
|
2019-11-20 10:47:06 -05:00
|
|
|
# Need to clean up after ourselves
|
|
|
|
database.impersonate_user = False
|
|
|
|
database.allow_dml = False
|
|
|
|
database.allow_run_async = False
|
|
|
|
db.session.commit()
|
|
|
|
|
2016-09-06 16:58:09 -04:00
|
|
|
def test_warm_up_cache(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
slc = self.get_slice("Girls", db.session)
|
|
|
|
data = self.get_json_resp("/superset/warm_up_cache?slice_id={}".format(slc.id))
|
2019-11-20 10:47:06 -05:00
|
|
|
self.assertEqual(data, [{"slice_id": slc.id, "slice_name": slc.slice_name}])
|
2016-09-06 16:58:09 -04:00
|
|
|
|
2016-10-19 12:17:08 -04:00
|
|
|
data = self.get_json_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/warm_up_cache?table_name=energy_usage&db_name=main"
|
|
|
|
)
|
2018-10-16 20:59:34 -04:00
|
|
|
assert len(data) > 0
|
2016-09-06 16:58:09 -04:00
|
|
|
|
2016-04-20 18:08:10 -04:00
|
|
|
def test_shortner(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2016-08-30 00:55:31 -04:00
|
|
|
data = (
|
2019-06-25 16:34:48 -04:00
|
|
|
"//superset/explore/table/1/?viz_type=sankey&groupby=source&"
|
|
|
|
"groupby=target&metric=sum__value&row_limit=5000&where=&having=&"
|
|
|
|
"flt_col_0=source&flt_op_0=in&flt_eq_0=&slice_id=78&slice_name="
|
|
|
|
"Energy+Sankey&collapsed_fieldsets=&action=&datasource_name="
|
|
|
|
"energy_usage&datasource_id=1&datasource_type=table&"
|
|
|
|
"previous_viz_type=sankey"
|
2016-09-22 12:53:14 -04:00
|
|
|
)
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.client.post("/r/shortner/", data=dict(data=data))
|
|
|
|
assert re.search(r"\/r\/[0-9]+", resp.data.decode("utf-8"))
|
2016-04-20 18:08:10 -04:00
|
|
|
|
2017-01-27 13:20:24 -05:00
|
|
|
def test_kv(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2017-01-27 13:20:24 -05:00
|
|
|
|
2019-11-20 10:47:06 -05:00
|
|
|
resp = self.client.get("/kv/10001/")
|
|
|
|
self.assertEqual(404, resp.status_code)
|
2017-01-27 13:20:24 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
value = json.dumps({"data": "this is a test"})
|
|
|
|
resp = self.client.post("/kv/store/", data=dict(data=value))
|
2017-01-27 13:20:24 -05:00
|
|
|
self.assertEqual(resp.status_code, 200)
|
|
|
|
kv = db.session.query(models.KeyValue).first()
|
|
|
|
kv_value = kv.value
|
|
|
|
self.assertEqual(json.loads(value), json.loads(kv_value))
|
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.client.get("/kv/{}/".format(kv.id))
|
2017-01-27 13:20:24 -05:00
|
|
|
self.assertEqual(resp.status_code, 200)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual(json.loads(value), json.loads(resp.data.decode("utf-8")))
|
2017-01-27 13:20:24 -05:00
|
|
|
|
2016-04-26 19:44:51 -04:00
|
|
|
def test_gamma(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="gamma")
|
|
|
|
assert "Charts" in self.get_resp("/chart/list/")
|
|
|
|
assert "Dashboards" in self.get_resp("/dashboard/list/")
|
2016-04-26 19:44:51 -04:00
|
|
|
|
2016-08-30 00:55:31 -04:00
|
|
|
def test_csv_endpoint(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login("admin")
|
2016-09-11 10:39:07 -04:00
|
|
|
sql = """
|
2019-09-08 13:18:09 -04:00
|
|
|
SELECT name
|
|
|
|
FROM birth_names
|
|
|
|
WHERE name = 'James'
|
|
|
|
LIMIT 1
|
2016-09-11 10:39:07 -04:00
|
|
|
"""
|
2019-06-25 16:34:48 -04:00
|
|
|
client_id = "{}".format(random.getrandbits(64))[:10]
|
2017-01-25 21:06:29 -05:00
|
|
|
self.run_sql(sql, client_id, raise_on_error=True)
|
2016-07-30 01:39:33 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp("/superset/csv/{}".format(client_id))
|
2016-10-02 21:03:19 -04:00
|
|
|
data = csv.reader(io.StringIO(resp))
|
2019-09-08 13:18:09 -04:00
|
|
|
expected_data = csv.reader(io.StringIO("name\nJames\n"))
|
2016-08-30 00:55:31 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
client_id = "{}".format(random.getrandbits(64))[:10]
|
2018-07-21 15:01:26 -04:00
|
|
|
self.run_sql(sql, client_id, raise_on_error=True)
|
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
resp = self.get_resp("/superset/csv/{}".format(client_id))
|
2018-07-21 15:01:26 -04:00
|
|
|
data = csv.reader(io.StringIO(resp))
|
2019-09-08 13:18:09 -04:00
|
|
|
expected_data = csv.reader(io.StringIO("name\nJames\n"))
|
2018-07-21 15:01:26 -04:00
|
|
|
|
2016-08-30 00:55:31 -04:00
|
|
|
self.assertEqual(list(expected_data), list(data))
|
|
|
|
self.logout()
|
|
|
|
|
2016-10-19 12:17:08 -04:00
|
|
|
def test_extra_table_metadata(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login("admin")
|
2019-09-08 13:18:09 -04:00
|
|
|
dbid = utils.get_example_database().id
|
2016-10-19 12:17:08 -04:00
|
|
|
self.get_json_resp(
|
2019-09-08 13:18:09 -04:00
|
|
|
f"/superset/extra_table_metadata/{dbid}/birth_names/superset/"
|
2019-06-25 16:34:48 -04:00
|
|
|
)
|
2016-10-19 12:17:08 -04:00
|
|
|
|
2016-10-26 14:09:27 -04:00
|
|
|
def test_process_template(self):
|
2019-09-08 13:18:09 -04:00
|
|
|
maindb = utils.get_example_database()
|
2016-10-26 14:09:27 -04:00
|
|
|
sql = "SELECT '{{ datetime(2017, 1, 1).isoformat() }}'"
|
2016-11-02 16:22:07 -04:00
|
|
|
tp = jinja_context.get_template_processor(database=maindb)
|
|
|
|
rendered = tp.process_template(sql)
|
2016-10-26 14:09:27 -04:00
|
|
|
self.assertEqual("SELECT '2017-01-01T00:00:00'", rendered)
|
2017-03-14 16:23:20 -04:00
|
|
|
|
|
|
|
def test_get_template_kwarg(self):
|
2019-09-08 13:18:09 -04:00
|
|
|
maindb = utils.get_example_database()
|
2019-06-25 16:34:48 -04:00
|
|
|
s = "{{ foo }}"
|
|
|
|
tp = jinja_context.get_template_processor(database=maindb, foo="bar")
|
2017-03-14 16:23:20 -04:00
|
|
|
rendered = tp.process_template(s)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual("bar", rendered)
|
2017-03-14 16:23:20 -04:00
|
|
|
|
|
|
|
def test_template_kwarg(self):
|
2019-09-08 13:18:09 -04:00
|
|
|
maindb = utils.get_example_database()
|
2019-06-25 16:34:48 -04:00
|
|
|
s = "{{ foo }}"
|
2017-03-14 16:23:20 -04:00
|
|
|
tp = jinja_context.get_template_processor(database=maindb)
|
2019-06-25 16:34:48 -04:00
|
|
|
rendered = tp.process_template(s, foo="bar")
|
|
|
|
self.assertEqual("bar", rendered)
|
2016-10-26 14:09:27 -04:00
|
|
|
|
|
|
|
def test_templated_sql_json(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login("admin")
|
2016-10-26 14:09:27 -04:00
|
|
|
sql = "SELECT '{{ datetime(2017, 1, 1).isoformat() }}' as test"
|
2019-06-25 16:34:48 -04:00
|
|
|
data = self.run_sql(sql, "fdaklj3ws")
|
|
|
|
self.assertEqual(data["data"][0]["test"], "2017-01-01T00:00:00")
|
2016-10-26 14:09:27 -04:00
|
|
|
|
2016-11-01 02:52:37 -04:00
|
|
|
def test_table_metadata(self):
|
2019-09-08 13:18:09 -04:00
|
|
|
maindb = utils.get_example_database()
|
|
|
|
data = self.get_json_resp(f"/superset/table/{maindb.id}/birth_names/null/")
|
|
|
|
self.assertEqual(data["name"], "birth_names")
|
2019-06-25 16:34:48 -04:00
|
|
|
assert len(data["columns"]) > 5
|
|
|
|
assert data.get("selectStar").startswith("SELECT")
|
2016-11-01 02:52:37 -04:00
|
|
|
|
2016-11-08 18:55:49 -05:00
|
|
|
def test_fetch_datasource_metadata(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
url = "/superset/fetch_datasource_metadata?" "datasourceKey=1__table"
|
2017-01-06 15:38:44 -05:00
|
|
|
resp = self.get_json_resp(url)
|
|
|
|
keys = [
|
2019-06-25 16:34:48 -04:00
|
|
|
"name",
|
|
|
|
"type",
|
|
|
|
"order_by_choices",
|
|
|
|
"granularity_sqla",
|
|
|
|
"time_grain_sqla",
|
|
|
|
"id",
|
2017-01-06 15:38:44 -05:00
|
|
|
]
|
|
|
|
for k in keys:
|
|
|
|
self.assertIn(k, resp.keys())
|
2016-11-01 02:52:37 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
def test_user_profile(self, username="admin"):
|
2017-04-24 23:48:25 -04:00
|
|
|
self.login(username=username)
|
2019-06-25 16:34:48 -04:00
|
|
|
slc = self.get_slice("Girls", db.session)
|
2016-12-01 18:21:18 -05:00
|
|
|
|
|
|
|
# Setting some faves
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/superset/favstar/Slice/{}/select/".format(slc.id)
|
2016-12-01 18:21:18 -05:00
|
|
|
resp = self.get_json_resp(url)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual(resp["count"], 1)
|
2016-12-01 18:21:18 -05:00
|
|
|
|
2019-12-18 14:40:45 -05:00
|
|
|
dash = db.session.query(Dashboard).filter_by(slug="births").first()
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/superset/favstar/Dashboard/{}/select/".format(dash.id)
|
2016-12-01 18:21:18 -05:00
|
|
|
resp = self.get_json_resp(url)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual(resp["count"], 1)
|
2016-12-01 18:21:18 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
userid = security_manager.find_user("admin").id
|
|
|
|
resp = self.get_resp("/superset/profile/admin/")
|
2016-11-20 00:23:44 -05:00
|
|
|
self.assertIn('"app"', resp)
|
2019-06-25 16:34:48 -04:00
|
|
|
data = self.get_json_resp("/superset/recent_activity/{}/".format(userid))
|
|
|
|
self.assertNotIn("message", data)
|
|
|
|
data = self.get_json_resp("/superset/created_slices/{}/".format(userid))
|
|
|
|
self.assertNotIn("message", data)
|
|
|
|
data = self.get_json_resp("/superset/created_dashboards/{}/".format(userid))
|
|
|
|
self.assertNotIn("message", data)
|
|
|
|
data = self.get_json_resp("/superset/fave_slices/{}/".format(userid))
|
|
|
|
self.assertNotIn("message", data)
|
|
|
|
data = self.get_json_resp("/superset/fave_dashboards/{}/".format(userid))
|
|
|
|
self.assertNotIn("message", data)
|
2017-11-12 14:09:22 -05:00
|
|
|
data = self.get_json_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/fave_dashboards_by_username/{}/".format(username)
|
|
|
|
)
|
|
|
|
self.assertNotIn("message", data)
|
2016-11-20 00:23:44 -05:00
|
|
|
|
2017-08-24 12:11:41 -04:00
|
|
|
def test_slice_id_is_always_logged_correctly_on_web_request(self):
|
|
|
|
# superset/explore case
|
2019-12-18 14:40:45 -05:00
|
|
|
slc = db.session.query(Slice).filter_by(slice_name="Girls").one()
|
2017-08-24 12:11:41 -04:00
|
|
|
qry = db.session.query(models.Log).filter_by(slice_id=slc.id)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.get_resp(slc.slice_url, {"form_data": json.dumps(slc.form_data)})
|
2017-08-24 12:11:41 -04:00
|
|
|
self.assertEqual(1, qry.count())
|
|
|
|
|
|
|
|
def test_slice_id_is_always_logged_correctly_on_ajax_request(self):
|
|
|
|
# superset/explore_json case
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2019-12-18 14:40:45 -05:00
|
|
|
slc = db.session.query(Slice).filter_by(slice_name="Girls").one()
|
2017-08-24 12:11:41 -04:00
|
|
|
qry = db.session.query(models.Log).filter_by(slice_id=slc.id)
|
2019-06-25 16:34:48 -04:00
|
|
|
slc_url = slc.slice_url.replace("explore", "explore_json")
|
|
|
|
self.get_json_resp(slc_url, {"form_data": json.dumps(slc.form_data)})
|
2017-08-24 12:11:41 -04:00
|
|
|
self.assertEqual(1, qry.count())
|
|
|
|
|
2017-09-26 12:03:03 -04:00
|
|
|
def test_slice_query_endpoint(self):
|
|
|
|
# API endpoint for query string
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
|
|
|
resp = self.get_resp("/superset/slice_query/{}/".format(slc.id))
|
|
|
|
assert "query" in resp
|
|
|
|
assert "language" in resp
|
2017-11-09 23:23:59 -05:00
|
|
|
self.logout()
|
2016-11-01 02:52:37 -04:00
|
|
|
|
2017-11-28 00:07:12 -05:00
|
|
|
def test_import_csv(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
table_name = "".join(random.choice(string.ascii_uppercase) for _ in range(5))
|
|
|
|
|
2019-11-07 13:03:42 -05:00
|
|
|
filename_1 = "testCSV.csv"
|
|
|
|
test_file_1 = open(filename_1, "w+")
|
|
|
|
test_file_1.write("a,b\n")
|
|
|
|
test_file_1.write("john,1\n")
|
|
|
|
test_file_1.write("paul,2\n")
|
|
|
|
test_file_1.close()
|
|
|
|
|
|
|
|
filename_2 = "testCSV2.csv"
|
|
|
|
test_file_2 = open(filename_2, "w+")
|
|
|
|
test_file_2.write("b,c,d\n")
|
|
|
|
test_file_2.write("john,1,x\n")
|
|
|
|
test_file_2.write("paul,2,y\n")
|
|
|
|
test_file_2.close()
|
|
|
|
|
2019-07-17 00:36:56 -04:00
|
|
|
example_db = utils.get_example_database()
|
|
|
|
example_db.allow_csv_upload = True
|
|
|
|
db_id = example_db.id
|
|
|
|
db.session.commit()
|
2017-11-28 00:07:12 -05:00
|
|
|
form_data = {
|
2019-11-07 13:03:42 -05:00
|
|
|
"csv_file": open(filename_1, "rb"),
|
2019-06-25 16:34:48 -04:00
|
|
|
"sep": ",",
|
|
|
|
"name": table_name,
|
2019-07-17 00:36:56 -04:00
|
|
|
"con": db_id,
|
2019-11-07 13:03:42 -05:00
|
|
|
"if_exists": "fail",
|
2019-06-25 16:34:48 -04:00
|
|
|
"index_label": "test_label",
|
|
|
|
"mangle_dupe_cols": False,
|
2018-02-03 23:22:06 -05:00
|
|
|
}
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/databaseview/list/"
|
2017-11-28 00:07:12 -05:00
|
|
|
add_datasource_page = self.get_resp(url)
|
2019-11-07 13:03:42 -05:00
|
|
|
self.assertIn("Upload a CSV", add_datasource_page)
|
2017-11-28 00:07:12 -05:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
url = "/csvtodatabaseview/form"
|
2017-11-28 00:07:12 -05:00
|
|
|
form_get = self.get_resp(url)
|
2019-11-07 13:03:42 -05:00
|
|
|
self.assertIn("CSV to Database configuration", form_get)
|
2017-11-28 00:07:12 -05:00
|
|
|
|
|
|
|
try:
|
2019-11-07 13:03:42 -05:00
|
|
|
# initial upload with fail mode
|
|
|
|
resp = self.get_resp(url, data=form_data)
|
|
|
|
self.assertIn(
|
|
|
|
f'CSV file "{filename_1}" uploaded to table "{table_name}"', resp
|
|
|
|
)
|
|
|
|
|
|
|
|
# upload again with fail mode; should fail
|
|
|
|
form_data["csv_file"] = open(filename_1, "rb")
|
|
|
|
resp = self.get_resp(url, data=form_data)
|
|
|
|
self.assertIn(
|
|
|
|
f'Unable to upload CSV file "{filename_1}" to table "{table_name}"',
|
|
|
|
resp,
|
|
|
|
)
|
|
|
|
|
|
|
|
# upload again with append mode
|
|
|
|
form_data["csv_file"] = open(filename_1, "rb")
|
|
|
|
form_data["if_exists"] = "append"
|
|
|
|
resp = self.get_resp(url, data=form_data)
|
|
|
|
self.assertIn(
|
|
|
|
f'CSV file "{filename_1}" uploaded to table "{table_name}"', resp
|
|
|
|
)
|
|
|
|
|
|
|
|
# upload again with replace mode
|
|
|
|
form_data["csv_file"] = open(filename_1, "rb")
|
|
|
|
form_data["if_exists"] = "replace"
|
|
|
|
resp = self.get_resp(url, data=form_data)
|
|
|
|
self.assertIn(
|
|
|
|
f'CSV file "{filename_1}" uploaded to table "{table_name}"', resp
|
|
|
|
)
|
|
|
|
|
|
|
|
# try to append to table from file with different schema
|
|
|
|
form_data["csv_file"] = open(filename_2, "rb")
|
|
|
|
form_data["if_exists"] = "append"
|
|
|
|
resp = self.get_resp(url, data=form_data)
|
|
|
|
self.assertIn(
|
|
|
|
f'Unable to upload CSV file "{filename_2}" to table "{table_name}"',
|
|
|
|
resp,
|
|
|
|
)
|
|
|
|
|
|
|
|
# replace table from file with different schema
|
|
|
|
form_data["csv_file"] = open(filename_2, "rb")
|
|
|
|
form_data["if_exists"] = "replace"
|
2019-07-17 00:36:56 -04:00
|
|
|
resp = self.get_resp(url, data=form_data)
|
2019-11-07 13:03:42 -05:00
|
|
|
self.assertIn(
|
|
|
|
f'CSV file "{filename_2}" uploaded to table "{table_name}"', resp
|
|
|
|
)
|
|
|
|
table = (
|
|
|
|
db.session.query(SqlaTable)
|
|
|
|
.filter_by(table_name=table_name, database_id=db_id)
|
|
|
|
.first()
|
|
|
|
)
|
|
|
|
# make sure the new column name is reflected in the table metadata
|
|
|
|
self.assertIn("d", table.column_names)
|
2017-11-28 00:07:12 -05:00
|
|
|
finally:
|
2019-11-07 13:03:42 -05:00
|
|
|
os.remove(filename_1)
|
|
|
|
os.remove(filename_2)
|
2017-11-28 00:07:12 -05:00
|
|
|
|
2017-11-20 11:33:18 -05:00
|
|
|
def test_dataframe_timezone(self):
|
2020-01-03 11:55:39 -05:00
|
|
|
tz = pytz.FixedOffset(60)
|
2018-01-02 23:21:33 -05:00
|
|
|
data = [
|
|
|
|
(datetime.datetime(2017, 11, 18, 21, 53, 0, 219225, tzinfo=tz),),
|
2020-01-03 11:55:39 -05:00
|
|
|
(datetime.datetime(2017, 11, 18, 22, 6, 30, tzinfo=tz),),
|
2018-01-02 23:21:33 -05:00
|
|
|
]
|
2020-01-03 11:55:39 -05:00
|
|
|
results = SupersetResultSet(list(data), [["data"]], BaseEngineSpec)
|
|
|
|
df = results.to_pandas_df()
|
|
|
|
data = dataframe.df_to_records(df)
|
|
|
|
json_str = json.dumps(data, default=utils.pessimistic_json_iso_dttm_ser)
|
2017-11-20 11:33:18 -05:00
|
|
|
self.assertDictEqual(
|
2019-06-25 16:34:48 -04:00
|
|
|
data[0], {"data": pd.Timestamp("2017-11-18 21:53:00.219225+0100", tz=tz)}
|
2017-11-20 11:33:18 -05:00
|
|
|
)
|
|
|
|
self.assertDictEqual(
|
2020-01-03 11:55:39 -05:00
|
|
|
data[1], {"data": pd.Timestamp("2017-11-18 22:06:30+0100", tz=tz)}
|
|
|
|
)
|
|
|
|
self.assertEqual(
|
|
|
|
json_str,
|
|
|
|
'[{"data": "2017-11-18T21:53:00.219225+01:00"}, {"data": "2017-11-18T22:06:30+01:00"}]',
|
2017-11-20 11:33:18 -05:00
|
|
|
)
|
|
|
|
|
2019-01-13 12:30:05 -05:00
|
|
|
def test_mssql_engine_spec_pymssql(self):
|
|
|
|
# Test for case when tuple is returned (pymssql)
|
2019-06-25 16:34:48 -04:00
|
|
|
data = [
|
|
|
|
(1, 1, datetime.datetime(2017, 10, 19, 23, 39, 16, 660000)),
|
|
|
|
(2, 2, datetime.datetime(2018, 10, 19, 23, 39, 16, 660000)),
|
|
|
|
]
|
2020-01-03 11:55:39 -05:00
|
|
|
results = SupersetResultSet(
|
2019-06-25 16:34:48 -04:00
|
|
|
list(data), [["col1"], ["col2"], ["col3"]], MssqlEngineSpec
|
|
|
|
)
|
2020-01-03 11:55:39 -05:00
|
|
|
df = results.to_pandas_df()
|
|
|
|
data = dataframe.df_to_records(df)
|
2019-01-13 12:30:05 -05:00
|
|
|
self.assertEqual(len(data), 2)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual(
|
|
|
|
data[0],
|
|
|
|
{"col1": 1, "col2": 1, "col3": pd.Timestamp("2017-10-19 23:39:16.660000")},
|
|
|
|
)
|
2019-01-13 12:30:05 -05:00
|
|
|
|
2018-02-18 19:30:11 -05:00
|
|
|
def test_comments_in_sqlatable_query(self):
|
|
|
|
clean_query = "SELECT '/* val 1 */' as c1, '-- val 2' as c2 FROM tbl"
|
2019-06-25 16:34:48 -04:00
|
|
|
commented_query = "/* comment 1 */" + clean_query + "-- comment 2"
|
2019-10-15 19:51:04 -04:00
|
|
|
table = SqlaTable(
|
|
|
|
table_name="test_comments_in_sqlatable_query_table", sql=commented_query
|
|
|
|
)
|
2018-10-13 12:38:46 -04:00
|
|
|
rendered_query = str(table.get_from_clause())
|
2018-02-18 19:30:11 -05:00
|
|
|
self.assertEqual(clean_query, rendered_query)
|
|
|
|
|
2018-02-27 18:11:01 -05:00
|
|
|
def test_slice_payload_no_data(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
|
|
|
json_endpoint = "/superset/explore_json/"
|
2018-08-15 14:25:06 -04:00
|
|
|
form_data = slc.form_data
|
2019-08-19 01:36:27 -04:00
|
|
|
form_data.update(
|
|
|
|
{
|
|
|
|
"adhoc_filters": [
|
|
|
|
{
|
|
|
|
"clause": "WHERE",
|
|
|
|
"comparator": "NA",
|
|
|
|
"expressionType": "SIMPLE",
|
|
|
|
"operator": "==",
|
|
|
|
"subject": "gender",
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
)
|
2019-06-25 16:34:48 -04:00
|
|
|
data = self.get_json_resp(json_endpoint, {"form_data": json.dumps(form_data)})
|
|
|
|
self.assertEqual(data["status"], utils.QueryStatus.SUCCESS)
|
|
|
|
self.assertEqual(data["error"], "No data")
|
2018-02-27 18:11:01 -05:00
|
|
|
|
|
|
|
def test_slice_payload_invalid_query(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
slc = self.get_slice("Girls", db.session)
|
2018-08-15 14:25:06 -04:00
|
|
|
form_data = slc.form_data
|
2019-06-25 16:34:48 -04:00
|
|
|
form_data.update({"groupby": ["N/A"]})
|
2018-02-27 18:11:01 -05:00
|
|
|
|
2018-08-15 14:25:06 -04:00
|
|
|
data = self.get_json_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
"/superset/explore_json/", {"form_data": json.dumps(form_data)}
|
2018-02-27 18:11:01 -05:00
|
|
|
)
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertEqual(data["status"], utils.QueryStatus.FAILED)
|
2018-02-27 18:11:01 -05:00
|
|
|
|
2019-07-01 14:55:25 -04:00
|
|
|
def test_slice_payload_no_datasource(self):
|
|
|
|
self.login(username="admin")
|
|
|
|
data = self.get_json_resp("/superset/explore_json/", raise_on_error=False)
|
|
|
|
|
|
|
|
self.assertEqual(
|
|
|
|
data["error"], "The datasource associated with this chart no longer exists"
|
|
|
|
)
|
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
@mock.patch("superset.security.SupersetSecurityManager.schemas_accessible_by_user")
|
|
|
|
@mock.patch("superset.security.SupersetSecurityManager.database_access")
|
|
|
|
@mock.patch("superset.security.SupersetSecurityManager.all_datasource_access")
|
|
|
|
def test_schemas_access_for_csv_upload_endpoint(
|
|
|
|
self, mock_all_datasource_access, mock_database_access, mock_schemas_accessible
|
|
|
|
):
|
2019-09-08 13:18:09 -04:00
|
|
|
self.login(username="admin")
|
|
|
|
dbobj = self.create_fake_db()
|
2018-09-20 14:21:11 -04:00
|
|
|
mock_all_datasource_access.return_value = False
|
|
|
|
mock_database_access.return_value = False
|
2019-06-25 16:34:48 -04:00
|
|
|
mock_schemas_accessible.return_value = ["this_schema_is_allowed_too"]
|
2018-09-20 14:21:11 -04:00
|
|
|
data = self.get_json_resp(
|
2019-06-25 16:34:48 -04:00
|
|
|
url="/superset/schemas_access_for_csv_upload?db_id={db_id}".format(
|
|
|
|
db_id=dbobj.id
|
|
|
|
)
|
|
|
|
)
|
|
|
|
assert data == ["this_schema_is_allowed_too"]
|
2019-11-20 10:47:06 -05:00
|
|
|
self.delete_fake_db()
|
2018-09-20 14:21:11 -04:00
|
|
|
|
2018-10-08 13:32:40 -04:00
|
|
|
def test_select_star(self):
|
2019-06-25 16:34:48 -04:00
|
|
|
self.login(username="admin")
|
2019-07-17 00:36:56 -04:00
|
|
|
examples_db = utils.get_example_database()
|
|
|
|
resp = self.get_resp(f"/superset/select_star/{examples_db.id}/birth_names")
|
2019-06-25 16:34:48 -04:00
|
|
|
self.assertIn("gender", resp)
|
2018-10-08 13:32:40 -04:00
|
|
|
|
2019-10-25 13:22:16 -04:00
|
|
|
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
|
|
|
|
@mock.patch("superset.views.core.results_backend")
|
|
|
|
@mock.patch("superset.views.core.db")
|
|
|
|
def test_display_limit(self, mock_superset_db, mock_results_backend):
|
|
|
|
query_mock = mock.Mock()
|
|
|
|
query_mock.sql = "SELECT *"
|
|
|
|
query_mock.database = 1
|
|
|
|
query_mock.schema = "superset"
|
|
|
|
mock_superset_db.session.query().filter_by().one_or_none.return_value = (
|
|
|
|
query_mock
|
|
|
|
)
|
|
|
|
|
|
|
|
data = [{"col_0": i} for i in range(100)]
|
|
|
|
payload = {
|
|
|
|
"status": utils.QueryStatus.SUCCESS,
|
|
|
|
"query": {"rows": 100},
|
|
|
|
"data": data,
|
|
|
|
}
|
|
|
|
# do not apply msgpack serialization
|
|
|
|
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
|
|
|
|
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
|
|
|
|
serialized_payload = sql_lab._serialize_payload(payload, False)
|
|
|
|
compressed = utils.zlib_compress(serialized_payload)
|
|
|
|
mock_results_backend.get.return_value = compressed
|
|
|
|
|
|
|
|
# get all results
|
|
|
|
result = json.loads(self.get_resp("/superset/results/key/"))
|
|
|
|
expected = {"status": "success", "query": {"rows": 100}, "data": data}
|
|
|
|
self.assertEqual(result, expected)
|
|
|
|
|
|
|
|
# limit results to 1
|
|
|
|
limited_data = data[:1]
|
|
|
|
result = json.loads(self.get_resp("/superset/results/key/?rows=1"))
|
|
|
|
expected = {
|
|
|
|
"status": "success",
|
|
|
|
"query": {"rows": 100},
|
|
|
|
"data": limited_data,
|
|
|
|
"displayLimitReached": True,
|
|
|
|
}
|
|
|
|
self.assertEqual(result, expected)
|
|
|
|
|
|
|
|
app.config["RESULTS_BACKEND_USE_MSGPACK"] = use_msgpack
|
|
|
|
|
2019-08-27 17:23:40 -04:00
|
|
|
def test_results_default_deserialization(self):
|
|
|
|
use_new_deserialization = False
|
|
|
|
data = [("a", 4, 4.0, "2019-08-18T16:39:16.660000")]
|
|
|
|
cursor_descr = (
|
|
|
|
("a", "string"),
|
|
|
|
("b", "int"),
|
|
|
|
("c", "float"),
|
|
|
|
("d", "datetime"),
|
|
|
|
)
|
|
|
|
db_engine_spec = BaseEngineSpec()
|
2020-01-03 11:55:39 -05:00
|
|
|
results = SupersetResultSet(data, cursor_descr, db_engine_spec)
|
2019-08-27 17:23:40 -04:00
|
|
|
query = {
|
|
|
|
"database_id": 1,
|
|
|
|
"sql": "SELECT * FROM birth_names LIMIT 100",
|
|
|
|
"status": utils.QueryStatus.PENDING,
|
|
|
|
}
|
|
|
|
serialized_data, selected_columns, all_columns, expanded_columns = sql_lab._serialize_and_expand_data(
|
2020-01-03 11:55:39 -05:00
|
|
|
results, db_engine_spec, use_new_deserialization
|
2019-08-27 17:23:40 -04:00
|
|
|
)
|
|
|
|
payload = {
|
|
|
|
"query_id": 1,
|
|
|
|
"status": utils.QueryStatus.SUCCESS,
|
|
|
|
"state": utils.QueryStatus.SUCCESS,
|
|
|
|
"data": serialized_data,
|
|
|
|
"columns": all_columns,
|
|
|
|
"selected_columns": selected_columns,
|
|
|
|
"expanded_columns": expanded_columns,
|
|
|
|
"query": query,
|
|
|
|
}
|
|
|
|
|
|
|
|
serialized_payload = sql_lab._serialize_payload(
|
|
|
|
payload, use_new_deserialization
|
|
|
|
)
|
|
|
|
self.assertIsInstance(serialized_payload, str)
|
|
|
|
|
|
|
|
query_mock = mock.Mock()
|
|
|
|
deserialized_payload = views._deserialize_results_payload(
|
|
|
|
serialized_payload, query_mock, use_new_deserialization
|
|
|
|
)
|
|
|
|
|
|
|
|
self.assertDictEqual(deserialized_payload, payload)
|
|
|
|
query_mock.assert_not_called()
|
|
|
|
|
|
|
|
def test_results_msgpack_deserialization(self):
|
|
|
|
use_new_deserialization = True
|
|
|
|
data = [("a", 4, 4.0, "2019-08-18T16:39:16.660000")]
|
|
|
|
cursor_descr = (
|
|
|
|
("a", "string"),
|
|
|
|
("b", "int"),
|
|
|
|
("c", "float"),
|
|
|
|
("d", "datetime"),
|
|
|
|
)
|
|
|
|
db_engine_spec = BaseEngineSpec()
|
2020-01-03 11:55:39 -05:00
|
|
|
results = SupersetResultSet(data, cursor_descr, db_engine_spec)
|
2019-08-27 17:23:40 -04:00
|
|
|
query = {
|
|
|
|
"database_id": 1,
|
|
|
|
"sql": "SELECT * FROM birth_names LIMIT 100",
|
|
|
|
"status": utils.QueryStatus.PENDING,
|
|
|
|
}
|
|
|
|
serialized_data, selected_columns, all_columns, expanded_columns = sql_lab._serialize_and_expand_data(
|
2020-01-03 11:55:39 -05:00
|
|
|
results, db_engine_spec, use_new_deserialization
|
2019-08-27 17:23:40 -04:00
|
|
|
)
|
|
|
|
payload = {
|
|
|
|
"query_id": 1,
|
|
|
|
"status": utils.QueryStatus.SUCCESS,
|
|
|
|
"state": utils.QueryStatus.SUCCESS,
|
|
|
|
"data": serialized_data,
|
|
|
|
"columns": all_columns,
|
|
|
|
"selected_columns": selected_columns,
|
|
|
|
"expanded_columns": expanded_columns,
|
|
|
|
"query": query,
|
|
|
|
}
|
|
|
|
|
|
|
|
serialized_payload = sql_lab._serialize_payload(
|
|
|
|
payload, use_new_deserialization
|
|
|
|
)
|
|
|
|
self.assertIsInstance(serialized_payload, bytes)
|
|
|
|
|
|
|
|
with mock.patch.object(
|
|
|
|
db_engine_spec, "expand_data", wraps=db_engine_spec.expand_data
|
|
|
|
) as expand_data:
|
|
|
|
query_mock = mock.Mock()
|
|
|
|
query_mock.database.db_engine_spec.expand_data = expand_data
|
|
|
|
|
|
|
|
deserialized_payload = views._deserialize_results_payload(
|
|
|
|
serialized_payload, query_mock, use_new_deserialization
|
|
|
|
)
|
2020-01-03 11:55:39 -05:00
|
|
|
df = results.to_pandas_df()
|
|
|
|
payload["data"] = dataframe.df_to_records(df)
|
2019-08-27 17:23:40 -04:00
|
|
|
|
|
|
|
self.assertDictEqual(deserialized_payload, payload)
|
|
|
|
expand_data.assert_called_once()
|
|
|
|
|
2019-11-20 10:47:06 -05:00
|
|
|
@mock.patch.dict(
|
|
|
|
"superset.extensions.feature_flag_manager._feature_flags",
|
|
|
|
{"FOO": lambda x: 1},
|
|
|
|
clear=True,
|
|
|
|
)
|
2019-11-12 14:10:36 -05:00
|
|
|
def test_feature_flag_serialization(self):
|
|
|
|
"""
|
|
|
|
Functions in feature flags don't break bootstrap data serialization.
|
|
|
|
"""
|
|
|
|
self.login()
|
|
|
|
|
|
|
|
encoded = json.dumps(
|
|
|
|
{"FOO": lambda x: 1, "super": "set"},
|
|
|
|
default=utils.pessimistic_json_iso_dttm_ser,
|
|
|
|
)
|
|
|
|
html = cgi.escape(encoded).replace("'", "'").replace('"', """)
|
|
|
|
|
2019-11-14 13:01:57 -05:00
|
|
|
urls = [
|
|
|
|
"/superset/sqllab",
|
|
|
|
"/superset/welcome",
|
|
|
|
"/superset/dashboard/1/",
|
|
|
|
"/superset/profile/admin/",
|
|
|
|
"/superset/explore/table/1",
|
|
|
|
]
|
|
|
|
for url in urls:
|
|
|
|
data = self.get_resp(url)
|
|
|
|
self.assertTrue(html in data)
|
2019-11-12 14:10:36 -05:00
|
|
|
|
2019-12-09 19:12:40 -05:00
|
|
|
@mock.patch.dict(
|
|
|
|
"superset.extensions.feature_flag_manager._feature_flags",
|
|
|
|
{"SQLLAB_BACKEND_PERSISTENCE": True},
|
|
|
|
clear=True,
|
|
|
|
)
|
|
|
|
def test_sqllab_backend_persistence_payload(self):
|
|
|
|
username = "admin"
|
|
|
|
self.login(username)
|
|
|
|
user_id = security_manager.find_user(username).id
|
|
|
|
|
|
|
|
# create a tab
|
|
|
|
data = {
|
|
|
|
"queryEditor": json.dumps(
|
|
|
|
{
|
|
|
|
"title": "Untitled Query 1",
|
|
|
|
"dbId": 1,
|
|
|
|
"schema": None,
|
|
|
|
"autorun": False,
|
|
|
|
"sql": "SELECT ...",
|
|
|
|
"queryLimit": 1000,
|
|
|
|
}
|
|
|
|
)
|
|
|
|
}
|
|
|
|
resp = self.get_json_resp("/tabstateview/", data=data)
|
|
|
|
tab_state_id = resp["id"]
|
|
|
|
|
|
|
|
# run a query in the created tab
|
|
|
|
self.run_sql(
|
|
|
|
"SELECT name FROM birth_names",
|
|
|
|
"client_id_1",
|
|
|
|
user_name=username,
|
|
|
|
raise_on_error=True,
|
|
|
|
sql_editor_id=tab_state_id,
|
|
|
|
)
|
|
|
|
# run an orphan query (no tab)
|
|
|
|
self.run_sql(
|
|
|
|
"SELECT name FROM birth_names",
|
|
|
|
"client_id_2",
|
|
|
|
user_name=username,
|
|
|
|
raise_on_error=True,
|
|
|
|
)
|
|
|
|
|
|
|
|
# we should have only 1 query returned, since the second one is not
|
|
|
|
# associated with any tabs
|
|
|
|
payload = views.Superset._get_sqllab_payload(user_id=user_id)
|
|
|
|
self.assertEqual(len(payload["queries"]), 1)
|
|
|
|
|
2017-09-27 20:51:04 -04:00
|
|
|
|
2019-06-25 16:34:48 -04:00
|
|
|
if __name__ == "__main__":
|
2015-09-26 18:55:33 -04:00
|
|
|
unittest.main()
|