2020-07-01 21:32:27 -04:00
|
|
|
/**
|
|
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
|
|
* or more contributor license agreements. See the NOTICE file
|
|
|
|
* distributed with this work for additional information
|
|
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
|
|
* to you under the Apache License, Version 2.0 (the
|
|
|
|
* "License"); you may not use this file except in compliance
|
|
|
|
* with the License. You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing,
|
|
|
|
* software distributed under the License is distributed on an
|
|
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
|
|
* KIND, either express or implied. See the License for the
|
|
|
|
* specific language governing permissions and limitations
|
|
|
|
* under the License.
|
|
|
|
*/
|
|
|
|
describe('AdhocMetrics', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
cy.login();
|
|
|
|
cy.server();
|
|
|
|
cy.route('GET', '/superset/explore_json/**').as('getJson');
|
|
|
|
cy.route('POST', '/superset/explore_json/**').as('postJson');
|
2020-10-28 13:06:16 -04:00
|
|
|
cy.visitChartByName('Num Births Trend');
|
|
|
|
cy.verifySliceSuccess({ waitAlias: '@postJson' });
|
2020-07-01 21:32:27 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
it('Clear metric and set simple adhoc metric', () => {
|
|
|
|
const metric = 'sum(sum_girls)';
|
2020-07-29 21:49:32 -04:00
|
|
|
const metricName = 'Sum Girls';
|
|
|
|
cy.get('[data-test=metrics]').find('.Select__clear-indicator').click();
|
2020-07-01 21:32:27 -04:00
|
|
|
|
2020-07-29 21:49:32 -04:00
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('.Select__control input')
|
|
|
|
.type('sum_girls', { force: true });
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('.Select__option--is-focused')
|
|
|
|
.trigger('mousedown')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
cy.get('[data-test="AdhocMetricEditTitle#trigger"]').click();
|
|
|
|
cy.get('[data-test="AdhocMetricEditTitle#input"]').type(metricName);
|
|
|
|
cy.get('[data-test="AdhocMetricEdit#save"]').contains('Save').click();
|
|
|
|
|
|
|
|
cy.get('.metrics-select .metric-option').contains(metricName);
|
2020-07-01 21:32:27 -04:00
|
|
|
|
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint :sparkles:
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 20:34:28 -04:00
|
|
|
cy.get('button[data-test="run-query-button"]').click();
|
2020-07-01 21:32:27 -04:00
|
|
|
cy.verifySliceSuccess({
|
|
|
|
waitAlias: '@postJson',
|
|
|
|
querySubstring: `${metric} AS "${metricName}"`, // SQL statement
|
|
|
|
chartSelector: 'svg',
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2020-10-28 17:41:39 -04:00
|
|
|
xit('Switch from simple to custom sql', () => {
|
2020-10-28 13:06:16 -04:00
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('[data-test="metric-option"]')
|
|
|
|
.should('have.length', 1);
|
2020-07-01 21:32:27 -04:00
|
|
|
|
|
|
|
// select column "num"
|
2020-07-29 21:49:32 -04:00
|
|
|
cy.get('[data-test=metrics]').find('.Select__clear-indicator').click();
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics]').find('.Select__control').click();
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics]').find('.Select__control input').type('num');
|
|
|
|
|
2020-10-28 13:06:16 -04:00
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('.option-label')
|
|
|
|
.first()
|
|
|
|
.should('have.text', 'num')
|
|
|
|
.click();
|
|
|
|
|
2020-07-01 21:32:27 -04:00
|
|
|
// add custom SQL
|
2020-07-29 21:49:32 -04:00
|
|
|
cy.get('#adhoc-metric-edit-tabs-tab-SQL').click();
|
2020-10-28 13:06:16 -04:00
|
|
|
cy.get('[data-test=metrics-edit-popover]').within(() => {
|
|
|
|
cy.get('.ace_content').click();
|
|
|
|
cy.get('.ace_text-input').type('/COUNT(DISTINCT name)', { force: true });
|
|
|
|
cy.get('[data-test="AdhocMetricEdit#save"]').contains('Save').click();
|
|
|
|
});
|
2020-07-01 21:32:27 -04:00
|
|
|
|
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint :sparkles:
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 20:34:28 -04:00
|
|
|
cy.get('button[data-test="run-query-button"]').click();
|
2020-07-01 21:32:27 -04:00
|
|
|
|
|
|
|
const metric = 'SUM(num)/COUNT(DISTINCT name)';
|
|
|
|
cy.verifySliceSuccess({
|
|
|
|
waitAlias: '@postJson',
|
|
|
|
querySubstring: `${metric} AS "${metric}"`,
|
|
|
|
chartSelector: 'svg',
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2020-10-28 17:41:39 -04:00
|
|
|
xit('Switch from custom sql tabs to simple', () => {
|
2020-07-01 21:32:27 -04:00
|
|
|
cy.get('[data-test=metrics]').within(() => {
|
|
|
|
cy.get('.Select__dropdown-indicator').click();
|
|
|
|
cy.get('input[type=text]').type('sum_girls{enter}');
|
|
|
|
});
|
2020-10-28 13:06:16 -04:00
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('[data-test="metric-option"]')
|
|
|
|
.should('have.length', 2);
|
2020-07-01 21:32:27 -04:00
|
|
|
|
|
|
|
cy.get('#metrics-edit-popover').within(() => {
|
|
|
|
cy.get('#adhoc-metric-edit-tabs-tab-SQL').click();
|
|
|
|
cy.get('.ace_identifier').contains('sum_girls');
|
|
|
|
cy.get('.ace_content').click();
|
|
|
|
cy.get('.ace_text-input').type('{selectall}{backspace}SUM(num)');
|
|
|
|
cy.get('#adhoc-metric-edit-tabs-tab-SIMPLE').click();
|
|
|
|
cy.get('.Select__single-value').contains(/^num$/);
|
|
|
|
cy.get('button').contains('Save').click();
|
|
|
|
});
|
|
|
|
|
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint :sparkles:
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 20:34:28 -04:00
|
|
|
cy.get('button[data-test="run-query-button"]').click();
|
2020-07-01 21:32:27 -04:00
|
|
|
|
|
|
|
const metric = 'SUM(num)';
|
|
|
|
cy.verifySliceSuccess({
|
|
|
|
waitAlias: '@postJson',
|
|
|
|
querySubstring: `${metric} AS "${metric}"`,
|
|
|
|
chartSelector: 'svg',
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2020-10-28 13:06:16 -04:00
|
|
|
it('Typing starts with aggregate function name', () => {
|
2020-07-01 21:32:27 -04:00
|
|
|
// select column "num"
|
|
|
|
cy.get('[data-test=metrics]').within(() => {
|
|
|
|
cy.get('.Select__dropdown-indicator').click();
|
|
|
|
cy.get('.Select__control input[type=text]').type('avg(');
|
|
|
|
cy.get('.Select__option').contains('ds');
|
|
|
|
cy.get('.Select__option').contains('name');
|
|
|
|
cy.get('.Select__option').contains('sum_boys').click();
|
|
|
|
});
|
|
|
|
|
|
|
|
const metric = 'AVG(sum_boys)';
|
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint :sparkles:
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 20:34:28 -04:00
|
|
|
cy.get('button[data-test="run-query-button"]').click();
|
2020-07-01 21:32:27 -04:00
|
|
|
cy.verifySliceSuccess({
|
|
|
|
waitAlias: '@postJson',
|
|
|
|
querySubstring: `${metric} AS "${metric}"`,
|
|
|
|
chartSelector: 'svg',
|
|
|
|
});
|
|
|
|
});
|
2020-11-06 17:23:12 -05:00
|
|
|
|
|
|
|
it('Click save without making any changes', () => {
|
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('.Select__control input')
|
|
|
|
.type('sum_girls', { force: true });
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics]')
|
|
|
|
.find('.Select__option--is-focused')
|
|
|
|
.trigger('mousedown')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics-edit-popover]').should('be.visible');
|
|
|
|
cy.get('[data-test="AdhocMetricEdit#save"]').click();
|
|
|
|
|
|
|
|
cy.wait(1000);
|
|
|
|
|
|
|
|
cy.get('[data-test=metrics-edit-popover]').should('not.be.visible');
|
|
|
|
});
|
2020-07-01 21:32:27 -04:00
|
|
|
});
|