2019-01-15 18:53:27 -05:00
|
|
|
/**
|
|
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
|
|
* or more contributor license agreements. See the NOTICE file
|
|
|
|
* distributed with this work for additional information
|
|
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
|
|
* to you under the Apache License, Version 2.0 (the
|
|
|
|
* "License"); you may not use this file except in compliance
|
|
|
|
* with the License. You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing,
|
|
|
|
* software distributed under the License is distributed on an
|
|
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
|
|
* KIND, either express or implied. See the License for the
|
|
|
|
* specific language governing permissions and limitations
|
|
|
|
* under the License.
|
|
|
|
*/
|
2018-08-06 18:30:13 -04:00
|
|
|
import React from 'react';
|
2020-07-28 18:53:20 -04:00
|
|
|
import { act } from 'react-dom/test-utils';
|
2018-08-06 18:30:13 -04:00
|
|
|
import configureStore from 'redux-mock-store';
|
2020-07-28 18:53:20 -04:00
|
|
|
import { mount } from 'enzyme';
|
2020-12-09 14:58:42 -05:00
|
|
|
import { Provider } from 'react-redux';
|
2018-10-19 14:41:11 -04:00
|
|
|
import fetchMock from 'fetch-mock';
|
|
|
|
import thunk from 'redux-thunk';
|
2018-08-06 18:30:13 -04:00
|
|
|
import sinon from 'sinon';
|
2020-09-09 16:18:55 -04:00
|
|
|
import { supersetTheme, ThemeProvider } from '@superset-ui/core';
|
2018-08-06 18:30:13 -04:00
|
|
|
|
2020-07-28 18:53:20 -04:00
|
|
|
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
|
2020-10-28 17:42:13 -04:00
|
|
|
import Modal from 'src/common/components/Modal';
|
2020-05-07 17:18:10 -04:00
|
|
|
import DatasourceModal from 'src/datasource/DatasourceModal';
|
|
|
|
import DatasourceEditor from 'src/datasource/DatasourceEditor';
|
2020-10-26 20:31:29 -04:00
|
|
|
import * as featureFlags from 'src/featureFlags';
|
2020-11-30 17:23:56 -05:00
|
|
|
import mockDatasource from 'spec/fixtures/mockDatasource';
|
2018-08-06 18:30:13 -04:00
|
|
|
|
2020-07-28 18:53:20 -04:00
|
|
|
const mockStore = configureStore([thunk]);
|
|
|
|
const store = mockStore({});
|
|
|
|
const datasource = mockDatasource['7__table'];
|
|
|
|
|
|
|
|
const SAVE_ENDPOINT = 'glob:*/api/v1/dataset/7';
|
|
|
|
const SAVE_PAYLOAD = { new: 'data' };
|
2021-01-26 02:35:57 -05:00
|
|
|
const SAVE_DATASOURCE_ENDPOINT = 'glob:*/datasource/save/';
|
2020-07-28 18:53:20 -04:00
|
|
|
|
|
|
|
const mockedProps = {
|
|
|
|
datasource,
|
2018-08-06 18:30:13 -04:00
|
|
|
addSuccessToast: () => {},
|
|
|
|
addDangerToast: () => {},
|
2018-10-19 14:41:11 -04:00
|
|
|
onChange: () => {},
|
2018-08-06 18:30:13 -04:00
|
|
|
onHide: () => {},
|
2020-07-28 18:53:20 -04:00
|
|
|
show: true,
|
2018-10-19 14:41:11 -04:00
|
|
|
onDatasourceSave: sinon.spy(),
|
2018-08-06 18:30:13 -04:00
|
|
|
};
|
|
|
|
|
2020-07-28 18:53:20 -04:00
|
|
|
async function mountAndWait(props = mockedProps) {
|
2020-12-09 14:58:42 -05:00
|
|
|
const mounted = mount(
|
|
|
|
<Provider store={store}>
|
|
|
|
<DatasourceModal {...props} />
|
|
|
|
</Provider>,
|
|
|
|
{
|
|
|
|
wrappingComponent: ThemeProvider,
|
|
|
|
wrappingComponentProps: { theme: supersetTheme },
|
|
|
|
},
|
|
|
|
);
|
2020-07-28 18:53:20 -04:00
|
|
|
await waitForComponentToPaint(mounted);
|
|
|
|
|
|
|
|
return mounted;
|
|
|
|
}
|
2018-10-19 14:41:11 -04:00
|
|
|
|
2018-08-06 18:30:13 -04:00
|
|
|
describe('DatasourceModal', () => {
|
|
|
|
let wrapper;
|
2020-10-26 20:31:29 -04:00
|
|
|
let isFeatureEnabledMock;
|
2020-07-28 18:53:20 -04:00
|
|
|
beforeEach(async () => {
|
2020-10-26 20:31:29 -04:00
|
|
|
isFeatureEnabledMock = jest
|
|
|
|
.spyOn(featureFlags, 'isFeatureEnabled')
|
|
|
|
.mockReturnValue(true);
|
2020-09-28 14:16:03 -04:00
|
|
|
fetchMock.reset();
|
2020-07-28 18:53:20 -04:00
|
|
|
wrapper = await mountAndWait();
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|
|
|
|
|
2020-10-26 20:31:29 -04:00
|
|
|
afterAll(() => {
|
|
|
|
isFeatureEnabledMock.restore();
|
|
|
|
});
|
|
|
|
|
2020-07-28 18:53:20 -04:00
|
|
|
it('renders', () => {
|
2020-07-29 13:53:06 -04:00
|
|
|
expect(wrapper.find(DatasourceModal)).toExist();
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
it('renders a Modal', () => {
|
2020-10-28 17:42:13 -04:00
|
|
|
expect(wrapper.find(Modal)).toExist();
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
it('renders a DatasourceEditor', () => {
|
2020-07-29 13:53:06 -04:00
|
|
|
expect(wrapper.find(DatasourceEditor)).toExist();
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|
|
|
|
|
2020-07-28 18:53:20 -04:00
|
|
|
it('saves on confirm', async () => {
|
2020-09-28 14:16:03 -04:00
|
|
|
const callsP = fetchMock.post(SAVE_ENDPOINT, SAVE_PAYLOAD);
|
2021-01-26 02:35:57 -05:00
|
|
|
fetchMock.post(SAVE_DATASOURCE_ENDPOINT, {});
|
2020-07-28 18:53:20 -04:00
|
|
|
act(() => {
|
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint :sparkles:
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 20:34:28 -04:00
|
|
|
wrapper
|
|
|
|
.find('button[data-test="datasource-modal-save"]')
|
|
|
|
.props()
|
|
|
|
.onClick();
|
2020-07-28 18:53:20 -04:00
|
|
|
});
|
|
|
|
await waitForComponentToPaint(wrapper);
|
|
|
|
act(() => {
|
2020-11-04 01:07:21 -05:00
|
|
|
const okButton = wrapper.find(
|
|
|
|
'.ant-modal-confirm .ant-modal-confirm-btns .ant-btn-primary',
|
|
|
|
);
|
2020-07-28 18:53:20 -04:00
|
|
|
okButton.simulate('click');
|
2020-06-29 00:37:04 -04:00
|
|
|
});
|
2020-07-28 18:53:20 -04:00
|
|
|
await waitForComponentToPaint(wrapper);
|
2020-09-28 14:16:03 -04:00
|
|
|
const expected = ['http://localhost/datasource/save/'];
|
|
|
|
expect(callsP._calls.map(call => call[0])).toEqual(
|
|
|
|
expected,
|
|
|
|
); /* eslint no-underscore-dangle: 0 */
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|
2020-10-26 20:31:29 -04:00
|
|
|
|
|
|
|
it('renders a legacy data source btn', () => {
|
|
|
|
expect(
|
|
|
|
wrapper.find('button[data-test="datasource-modal-legacy-edit"]'),
|
|
|
|
).toExist();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('DatasourceModal without legacy data btn', () => {
|
|
|
|
let wrapper;
|
|
|
|
let isFeatureEnabledMock;
|
|
|
|
beforeEach(async () => {
|
|
|
|
isFeatureEnabledMock = jest
|
|
|
|
.spyOn(featureFlags, 'isFeatureEnabled')
|
|
|
|
.mockReturnValue(false);
|
|
|
|
fetchMock.reset();
|
|
|
|
wrapper = await mountAndWait();
|
|
|
|
});
|
|
|
|
|
|
|
|
afterAll(() => {
|
|
|
|
isFeatureEnabledMock.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('hides legacy data source btn', () => {
|
|
|
|
isFeatureEnabledMock = jest
|
|
|
|
.spyOn(featureFlags, 'isFeatureEnabled')
|
|
|
|
.mockReturnValue(false);
|
|
|
|
expect(
|
|
|
|
wrapper.find('button[data-test="datasource-modal-legacy-edit"]'),
|
|
|
|
).not.toExist();
|
|
|
|
});
|
2018-08-06 18:30:13 -04:00
|
|
|
});
|