2023-09-29 12:34:04 -04:00
name : Prefer TypeScript
2021-01-07 03:47:00 -05:00
on :
push :
2024-01-23 23:30:53 -05:00
branches :
- 'master'
paths :
- "superset-frontend/src/**"
2021-01-07 03:47:00 -05:00
pull_request :
2024-01-23 23:30:53 -05:00
types : [ synchronize, opened, reopened, ready_for_review]
paths :
- "superset-frontend/src/**"
2021-01-07 03:47:00 -05:00
jobs :
prefer_typescript :
if : github.ref == 'ref/heads/master' && github.event_name == 'pull_request'
2023-09-29 12:34:04 -04:00
name : Prefer TypeScript
2021-01-07 03:47:00 -05:00
runs-on : ubuntu-latest
2023-04-14 11:23:00 -04:00
permissions :
contents : read
pull-requests : write
2021-01-07 03:47:00 -05:00
steps :
2021-01-24 02:10:16 -05:00
- name : "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
2023-04-14 11:23:00 -04:00
uses : actions/checkout@v3
2021-01-24 02:10:16 -05:00
with :
persist-credentials : false
submodules : recursive
2021-01-07 03:47:00 -05:00
- name : Get changed files
id : changed
uses : ./.github/actions/file-changes-action
with :
2023-04-14 11:23:00 -04:00
githubToken : ${{ github.token }}
2021-01-07 03:47:00 -05:00
- name : Determine if a .js or .jsx file was added
id : check
run : |
js_files_added() {
jq -r '
map(
select(
endswith(".js") or endswith(".jsx")
)
) | join("\n")
' ${HOME}/files_added.json
}
2024-01-31 13:40:07 -05:00
echo "js_files_added=$(js_files_added)" >> $GITHUB_OUTPUT
2021-01-07 03:47:00 -05:00
- if : steps.check.outputs.js_files_added
name : Add Comment to PR
uses : ./.github/actions/comment-on-pr
continue-on-error : true
env :
2023-04-14 11:23:00 -04:00
GITHUB_TOKEN : ${{ github.token }}
2021-01-07 03:47:00 -05:00
with :
msg : |
### WARNING: Prefer TypeScript
Looks like your PR contains new `.js` or `.jsx` files :
```
${{steps.check.outputs.js_files_added}}
```
As decided in [SIP-36](https://github.com/apache/superset/issues/9101), all new frontend code should be written in TypeScript. Please convert above files to TypeScript then re-request review.