pf_app
Paul Trowbridge
8f96fa3f7f
A selection of five AOP rows cloned nothing, with no explanation. The cause was exclude_iters, which clone applied along with scale and recode. It should not. That exclusion exists to stop operations *modifying* reference rows: scale distributes an increment across its pool, so including reference would attribute forecast movement to prior-year rows, and recode writes negative rows that zero the original out. Clone does neither -- it reads rows and inserts new pf_iter = 'clone' rows, leaving the source untouched. Copying a plan or a prior year out of reference and into adjustments is the operation doing exactly what it is for. So from_logid stops being the only way to reach those rows and becomes what it should be: a narrowing, for a selection spanning AOP and Prior Year where only one is wanted. The "would just duplicate the rows" guard no longer fires when the selection is entirely non-adjustable, since moving rows from reference into adjustments changes what they are even at factor 1 with no shift. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| lib | ||
| public | ||
| routes | ||
| setup_sql | ||
| ui | ||
| .env.example | ||
| .gitignore | ||
| CLAUDE.md | ||
| install.sh | ||
| package-lock.json | ||
| package.json | ||
| PERSPECTIVE.md | ||
| pf_perspective_options.md | ||
| pf_spec.md | ||
| pf.sh | ||
| server.js | ||