Paul Trowbridge
915981b4a7
Nav. The source and version dropdowns sat in a status bar that is otherwise read-only, so they did not read as the controls they were. The forecasts are now listed in the sidebar above the three steps, each row carrying its status and a star for the default. Not nested under the Forecast button, which is where this started: Baseline works on the same version, so hanging the list off one step would either misrepresent the scope or duplicate it under two. The source is gone from the nav entirely -- gs.osm_skinny means nothing to someone editing a forecast. The sidebar lists every source's versions and sets the source from the one picked, since a version carries its source_id; `versions` stays scoped to the selected source, because Baseline and Forecast are, so the sidebar gets its own list rather than widening what versions means everywhere. The picker only appears on Setup now, which is the one place the raw table name is the right label. The status bar keeps what follows FROM the selection -- the forecast's name and its row count. The table it writes to moved into the hover panel, still click-to-copy, since pasting it into psql is why it was ever on screen. Permissions. requireAdmin existed in lib/auth.js and was applied to nothing, so all 26 non-admin accounts could call every Setup and Baseline endpoint directly. It is now on source register/deregister, col_meta writes, Generate SQL, dim refresh, version create/delete/ close/reopen, PUT /versions/:id, all of plans.js, and the baseline and reference loads. Deliberately not on any read, nor on the forecast operations, which carry their own owner and territory rules. Both pages stay visible and go read-only, via one <fieldset disabled> each rather than a flag threaded through forty-five controls, with a banner saying why. The Tags panel on Baseline is excluded: its permission is ownership, not admin, and a rep may rename the initiatives they named themselves. The table browser reads are open to everyone, because gating what a page needs in order to render turned Setup into a 403 -- which it then rendered as a crash, since the error body was passed to .map during render and unmounting React blanks the app. Setup's list fetches now coerce to an array, so an unexpected response costs an empty panel and not the session. That fragility predated the gating. Toolbar. The zone labels were the same visual weight as the buttons they name, and the rules between groups were the same weight as the zone borders, so nothing separated at the level it belonged to. Labels are heavier and darker, group rules are stronger and taller, and the forecast zone has a container of its own instead of floating. Fit widths is removed, button and function. It measured the leaf header over viewport rows only, so anything below the fold never counted; it passed an option draw() does not have and raced draw()'s throttle, leaving columns cleared but unmeasured at their floor widths; and the persist that followed saved nothing, because saveColumnSizes returns only overrides, which resetAutoSize had just emptied. Recoverable from git if it is ever worth fixing rather than dropping. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
57 lines
2.2 KiB
JavaScript
57 lines
2.2 KiB
JavaScript
const express = require('express');
|
|
const { RELATION_COLUMNS_SQL } = require('../lib/utils');
|
|
|
|
// Reads, deliberately open to everyone: Setup is visible read-only to
|
|
// non-admins, so gating what the page needs in order to render turned it into
|
|
// a 403 the client rendered as a crash. The writes it leads to are gated.
|
|
module.exports = function(pool) {
|
|
const router = express.Router();
|
|
|
|
// list all non-system tables with row estimates
|
|
router.get('/tables', async (req, res) => {
|
|
try {
|
|
const result = await pool.query(`
|
|
-- pg_class, not information_schema.tables, which omits
|
|
-- materialized views: gs.osm_skinny is one, and the browser
|
|
-- could not offer what the app is already built on.
|
|
SELECT
|
|
n.nspname AS schema,
|
|
c.relname AS tname,
|
|
c.reltuples::bigint AS row_estimate
|
|
FROM pg_class c
|
|
JOIN pg_namespace n ON n.oid = c.relnamespace
|
|
WHERE c.relkind IN ('r', 'v', 'm', 'f', 'p')
|
|
AND n.nspname NOT IN ('pg_catalog', 'information_schema', 'pf')
|
|
ORDER BY n.nspname, c.relname
|
|
`);
|
|
res.json(result.rows);
|
|
} catch (err) {
|
|
console.error(err);
|
|
res.status(500).json({ error: err.message });
|
|
}
|
|
});
|
|
|
|
// preview a table: column list + 5 sample rows
|
|
router.get('/tables/:schema/:tname/preview', async (req, res) => {
|
|
const { schema, tname } = req.params;
|
|
if (!/^\w+$/.test(schema) || !/^\w+$/.test(tname)) {
|
|
return res.status(400).json({ error: 'Invalid schema or table name' });
|
|
}
|
|
try {
|
|
const cols = await pool.query(
|
|
`${RELATION_COLUMNS_SQL} ORDER BY ordinal_position`, [schema, tname]);
|
|
|
|
const rows = await pool.query(
|
|
`SELECT * FROM ${schema}.${tname} LIMIT 5`
|
|
);
|
|
|
|
res.json({ columns: cols.rows, rows: rows.rows });
|
|
} catch (err) {
|
|
console.error(err);
|
|
res.status(500).json({ error: err.message });
|
|
}
|
|
});
|
|
|
|
return router;
|
|
};
|