pt/pf_app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Recount the ledger after an undo, and after every operation

Browse Source 
The effect that recounts the selection is keyed on `slices`, and neither an
undo nor an operation changes the selection -- so the panel went on showing
totals that included rows it had just removed, or excluded rows it had just
written. Only scale refreshed, and only for itself.

Undo now re-reads the log as well, since the walk lines come from there: an
undone entry has to leave the ledger and not just the table. It runs after
the remove resolves, because fetchCurrentTotals counts through the table's
own views and would otherwise count what was being deleted. It reads
slicesRef rather than slices, being inside a handler registered once.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Trowbridge 2026-09-21 23:37:30 -04:00
parent b1d6e5e627
commit 4020a8b78e
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ui/src/views/Forecast.jsx
View File

@ -1622,7 +1622,13 @@ export default function Forecast({ sources = [], sourceId, versions = [], versio
window.dispatchEvent(new CustomEvent('pf-data-changed'))
refreshLogMeta(versionId)
if (opTag.trim()) refreshTags(versionId)
if (op === 'scale') { setScaleInputs({}); setScaleNote(''); fetchCurrentTotals(slices) }
// Every operation changes what the selection holds, so every operation
// has to re-count it. This used to fire for scale alone, and a recode or
// clone left the ledger showing the totals from before it ran -- the
// effect that normally recounts is keyed on `slices`, and none of these
// change the selection.
fetchCurrentTotals(slices)
if (op === 'scale') { setScaleInputs({}); setScaleNote('') }
if (op === 'recode') { setRecodeNote('') }
if (op === 'clone') { setCloneNote(''); setCloneScale('1') }
} catch (err) {
@ -1821,6 +1827,15 @@ export default function Forecast({ sources = [], sourceId, versions = [], versio
if (removed?.length && tableRef.current) {
await tableRef.current.remove(removed)
}
// Recount the selection, now the rows are actually gone. Undone after the
// remove, not beside it: fetchCurrentTotals reads the table through its
// own views, so running it first would count what was just deleted.
//
// The walk lines come from the log, so that is re-read too -- an undone
// entry has to leave the ledger as well as the table.
window.dispatchEvent(new CustomEvent('pf-data-changed'))
refreshLogMeta(versionId)
if (slicesRef.current.length) fetchCurrentTotals(slicesRef.current)
flash(`Undone — ${data.rows_deleted} rows removed`)
} catch (err) {
flash(err.message, 'error')