pt/pf_app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Define sliceUnits, which recode and clone have always called

Browse Source 
55814ee introduced calls to sliceUnits() in the recode and clone routes
without ever defining it, so both have thrown "sliceUnits is not defined"
since that commit. Scale worked only because it inlined the same three lines
rather than calling the helper.

Defined from scale's copy, and scale now calls it too. Recode and clone
passed req.body.apply_mode straight through, where scale normalised it
first, so an absent or unrecognised value would have fallen to the 'each'
branch by accident; they normalise the same way now.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Trowbridge 2026-09-17 00:11:35 -04:00
parent 812678bb7f
commit 401b6b9b42
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
routes/operations.js
View File

@ -32,6 +32,22 @@ module.exports = function(pool) {
return clean; return clean;
} }
// How a multi-slice request is split into statements.
//
// 'each' — one statement per slice, so every slice reaches its target on
// its own and gets its own log entry
// 'prorate' — a single statement over all of them, letting the SQL's
// sum() OVER () distribute across the whole pool
//
// Only scale has a target to prorate towards; recode and clone rewrite rows
// rather than distribute an amount, so for them this only decides whether the
// work lands as one log entry or several.
function sliceUnits(slices, ctx, applyMode) {
return applyMode === 'each'
? slices.map(sl => ({ slices: [sl], where: buildWhere(sl, ctx.filterCols) }))
: [{ slices, where: buildWhereAny(slices, ctx.filterCols) }];
}
// A slice is only meaningful if at least one of its keys is a filterable // A slice is only meaningful if at least one of its keys is a filterable
// column. buildWhere silently drops unknown keys, so {"typo": "x"} would // column. buildWhere silently drops unknown keys, so {"typo": "x"} would
// otherwise reduce to TRUE and apply the operation to the whole version. // otherwise reduce to TRUE and apply the operation to the whole version.
@ -572,9 +588,7 @@ module.exports = function(pool) {
// sum() OVER () distribute the increment across the whole pool. // sum() OVER () distribute the increment across the whole pool.
// 'each' runs the same statement once per slice, so every slice // 'each' runs the same statement once per slice, so every slice
// reaches the target on its own and gets its own log entry. // reaches the target on its own and gets its own log entry.
const units = applyMode === 'each' const units = sliceUnits(slices, ctx, applyMode);
? slices.map(sl => ({ slices: [sl], where: buildWhere(sl, ctx.filterCols) }))
: [{ slices, where: buildWhereAny(slices, ctx.filterCols) }];
const client = await pool.connect(); const client = await pool.connect();
let committed = false; let committed = false;
@ -656,7 +670,7 @@ module.exports = function(pool) {
const excludeClause = buildExcludeClause(ctx.version.exclude_iters); const excludeClause = buildExcludeClause(ctx.version.exclude_iters);
const setClause = buildSetClause(ctx.dimCols, set); const setClause = buildSetClause(ctx.dimCols, set);
const units = sliceUnits(slices, ctx, apply_mode); const units = sliceUnits(slices, ctx, apply_mode === 'each' ? 'each' : 'prorate');
const client = await pool.connect(); const client = await pool.connect();
let committed = false; let committed = false;
@ -712,7 +726,7 @@ module.exports = function(pool) {
const scaleFactor = (scale != null) ? parseFloat(scale) : 1.0; const scaleFactor = (scale != null) ? parseFloat(scale) : 1.0;
const excludeClause = buildExcludeClause(ctx.version.exclude_iters); const excludeClause = buildExcludeClause(ctx.version.exclude_iters);
const setClause = buildSetClause(ctx.dimCols, set); const setClause = buildSetClause(ctx.dimCols, set);
const units = sliceUnits(slices, ctx, apply_mode); const units = sliceUnits(slices, ctx, apply_mode === 'each' ? 'each' : 'prorate');
const client = await pool.connect(); const client = await pool.connect();
let committed = false; let committed = false;