pt/pf_app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

One name for one column: Note

Browse Source 
Description was the original field and Note replaced it, but nothing removed
it -- so the edit form carried both, writing the same pf.log.note, with
`note: description || segNote` letting Description win silently over whatever
was typed in Note right below it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Trowbridge 2026-09-17 23:18:41 -04:00
parent 2306315a17
commit 1286351be3
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui/src/views/Baseline.jsx
View File

@ -97,7 +97,6 @@ export default function Baseline({ sources = [], sourceId, versions = [], versio
// segment form
const [segType, setSegType] = useState('baseline')
const [description, setDescription] = useState('')
const [filters, setFilters] = useState([]) // [[cond,...], [cond,...]]
const [useRaw, setUseRaw] = useState(false)
const [rawSql, setRawSql] = useState('')
@ -222,7 +221,7 @@ export default function Baseline({ sources = [], sourceId, versions = [], versio
const endpoint = isRef ? 'reference' : 'baseline'
const body = {
where_clause: clause,
note: description || segNote,
note: segNote,
date_offset: offsetStr,
label: segLabel.trim(),
bucket: segBucket.trim(),
@ -263,7 +262,6 @@ export default function Baseline({ sources = [], sourceId, versions = [], versio
setSegNote(entry.note || '')
setSegLabel(entry.label || '')
setSegBucket(entry.bucket || '')
setDescription('')
setOffset(params.date_offset || '0 days')
const groups = normalizeFilters(params.filters)
if (groups) {
@ -290,7 +288,6 @@ export default function Baseline({ sources = [], sourceId, versions = [], versio
function cancelEdit() {
setEditingLogId(null)
setShowAddForm(false)
setDescription('')
setSegNote('')
setSegLabel('')
setSegBucket('')
@ -559,7 +556,6 @@ export default function Baseline({ sources = [], sourceId, versions = [], versio
filters={filters} setFilters={setFilters}
useRaw={useRaw} setUseRaw={setUseRaw}
rawSql={rawSql} setRawSql={setRawSql}
description={description} setDescription={setDescription}
segNote={segNote} setSegNote={setSegNote}
segBucket={segBucket} setSegBucket={setSegBucket}
segLabel={segLabel} setSegLabel={setSegLabel}
@ -588,7 +584,6 @@ function segmentValuesFor(entry, filterCols) {
filters: groups || (filterCols.length > 0 ? [emptyGroup(filterCols)] : []),
useRaw: !groups && !!params.where_clause,
rawSql: params.where_clause || '',
description: '',
segNote: entry.note || '',
segBucket: entry.bucket || '',
segLabel: entry.label || '',
@ -602,7 +597,6 @@ function SegmentForm({
filters, setFilters,
useRaw, setUseRaw,
rawSql, setRawSql,
description, setDescription,
segNote, setSegNote,
segBucket, setSegBucket,
segLabel, setSegLabel,
@ -676,14 +670,6 @@ function SegmentForm({
</div>
</div>
{/* Description (edit only) */}
{mode === 'edit' && (
<div className="flex items-center gap-3">
<label className="text-xs text-gray-500 w-28 shrink-0">Description</label>
<input value={description} onChange={e => setDescription(e.target.value)} placeholder="e.g. FY25 actuals +1yr" className="border border-gray-200 rounded px-2 py-1.5 text-sm flex-1 max-w-sm" />
</div>
)}
{/* Filters */}
<div>
<div className="flex items-center justify-between mb-2">