pt/jrunner
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 5 Wiki Activity

fix race condition in deploy script rename logic

Browse Source 
Previous version failed when /opt/jrunner existed from a prior run,
because mv cannot move over an existing directory. Now the script:

1. Removes target directory if it exists
2. Removes intermediate jrunner/ directory if it exists and differs
   from target (prevents collision)
3. Extracts cleanly
4. Renames to target name

This fixes the issue where ./deploy.sh /opt/jr_test would fail if
/opt/jrunner already existed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Paul Trowbridge 2026-01-06 22:26:14 -05:00
parent 4b8ffcdd1c
commit c6d34847d5
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
deploy.sh
View File

@ -22,16 +22,27 @@ echo "Building jrunner..."
./gradlew build ./gradlew build
echo "Deploying to ${DEPLOY_DIR}..." echo "Deploying to ${DEPLOY_DIR}..."
# Remove both target and intermediate jrunner directory if they exist
if [ -d "${DEPLOY_DIR}" ]; then if [ -d "${DEPLOY_DIR}" ]; then
echo "Removing existing deployment..." echo "Removing existing deployment at ${DEPLOY_DIR}..."
sudo rm -rf "${DEPLOY_DIR}" sudo rm -rf "${DEPLOY_DIR}"
fi fi
sudo mkdir -p "$(dirname "${DEPLOY_DIR}")"
sudo unzip -q jrunner/build/distributions/jrunner.zip -d "$(dirname "${DEPLOY_DIR}")"
# Rename if custom directory name was specified PARENT_DIR="$(dirname "${DEPLOY_DIR}")"
EXTRACT_DIR="${PARENT_DIR}/jrunner"
if [ -d "${EXTRACT_DIR}" ] && [ "${EXTRACT_DIR}" != "${DEPLOY_DIR}" ]; then
echo "Removing existing jrunner directory at ${EXTRACT_DIR}..."
sudo rm -rf "${EXTRACT_DIR}"
fi
# Extract and rename if needed
sudo mkdir -p "${PARENT_DIR}"
sudo unzip -q jrunner/build/distributions/jrunner.zip -d "${PARENT_DIR}"
if [ "$(basename "${DEPLOY_DIR}")" != "jrunner" ]; then if [ "$(basename "${DEPLOY_DIR}")" != "jrunner" ]; then
sudo mv "$(dirname "${DEPLOY_DIR}")/jrunner" "${DEPLOY_DIR}" sudo mv "${EXTRACT_DIR}" "${DEPLOY_DIR}"
fi fi
# Only create symlink for default location # Only create symlink for default location