jellyfin/MediaBrowser.Controller
jkhsjdhjs 547d97d602
Use `eof_action=pass` when overlaying subtitles
The previous behavior using `eof_action=endall` and `shortest=1` would
end the video stream if one of the input stream (video, subtitle) ends.
In some cases the duration of the overlayed subtitles is shorter than the
video stream, causing the output to end when the subtitles end and dropping
the remaining video stream.

This commit changes this behavior so `eof_action=pass` is used instead,
which continues passing the video stream through even if the subtitles end
earlier [1]. `shortest=1` is also removed, as this option implies
`eof_action=endall`.

If the subtitle stream has a higher duration than the video stream, the output
will also end with the video stream without `shortest=1`, as the video stream
is the primary input to the `overlay` filter.

Fix #10698

[1] https://ffmpeg.org/ffmpeg-filters.html#Options-for-filters-with-several-inputs-_0028framesync_0029
2023-12-13 13:11:42 +01:00
..
Authentication Reduce log spam on failed logins 2023-08-21 19:09:32 +02:00
BaseItemManager Remove redundant using directives 2023-10-08 00:50:02 +02:00
Channels Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Chapters Fix warnings in MediaBrowser.Controller/Drawing 2021-07-24 20:33:58 -07:00
ClientEvent Multiple Stream changes 2023-10-11 18:32:57 +02:00
Collections Added CleanupCollection task 2023-02-01 19:34:58 +01:00
Configuration Minor improvements 2021-08-15 23:48:19 +02:00
Devices Re-add documentation 2021-09-02 20:22:08 -04:00
Drawing Merge branch 'master' into trickplay 2023-10-18 19:27:05 -07:00
Dto Return NotFound when itemId isn't found 2023-02-04 20:11:08 +01:00
Entities Merge branch 'master' into feat/book-persons 2023-11-13 18:07:23 +01:00
Events Apply review suggestions 2023-07-29 13:50:55 +02:00
Extensions Remove unnecessary Trim() from GetPersonFromXmlNode 2023-10-06 16:57:36 -04:00
IO Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Library Convert CollectionType, SpecialFolderType to enum (#9764) 2023-11-09 14:00:29 -07:00
LiveTv Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Lyrics Check for empty string in DefaultLyricProvider 2023-07-01 11:16:21 +02:00
MediaEncoding Use `eof_action=pass` when overlaying subtitles 2023-12-13 13:11:42 +01:00
Net Make files readonly 2023-10-08 00:40:58 +02:00
Persistence Migrate to trickplay table to EF. Rename vars/methods/members to have consistent use of tile and thumbnail 2023-06-26 17:40:10 -07:00
Playlists Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
Plugins Add IServerApplicationHost parameter to IPluginServiceRegistrator 2023-11-10 07:43:46 -05:00
Properties Rewrite BaseItem.ModifySortChunks 2022-10-12 17:43:01 +02:00
Providers Convert ItemSortBy to enum (#9765) 2023-11-09 14:00:13 -07:00
QuickConnect Fix issues with QuickConnect and AuthenticationDb 2021-06-23 21:07:08 -06:00
Resolvers Convert CollectionType, SpecialFolderType to enum (#9764) 2023-11-09 14:00:29 -07:00
Security Enable nullable for more files and add tests 2023-08-22 18:11:34 +02:00
Session Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Sorting Convert ItemSortBy to enum (#9765) 2023-11-09 14:00:13 -07:00
Subtitles Add ability to upload (and save) SDH subtitles (#10036) 2023-07-29 06:52:35 -06:00
SyncPlay Add all websocket messages to generated openapi spec (#9682) 2023-06-10 07:28:21 -06:00
TV Fix suggestions from review 2021-05-15 15:33:50 -06:00
Trickplay Make TrickplayManifest dictionary key a string rather than Guid 2023-09-04 12:30:20 -07:00
IDisplayPreferencesManager.cs Minor cleanup 2022-08-18 13:56:23 +02:00
IServerApplicationHost.cs Add SystemManager service 2023-10-04 14:40:00 -04:00
IServerApplicationPaths.cs Remove unused ImageByName API (#8928) 2022-12-19 18:44:13 -07:00
ISystemManager.cs Add SystemManager service 2023-10-04 14:40:00 -04:00
MediaBrowser.Controller.csproj Update deps 2023-11-16 00:50:48 +01:00