Commit Graph

102 Commits

Author SHA1 Message Date
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009 5726535a26 Fix some warnings
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) (#6078)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
Matt Montgomery 53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
Bond_009 404bb4f835 Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release 2020-08-22 21:56:24 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan ba610b5094 Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller 2019-01-13 21:01:16 +01:00
Erwin de Haan 26ca4b607b Visual Studio Reformat: MediaBrowser.Controller 2019-01-13 20:25:32 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009 ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti 0d28929e17 update download progress reporting 2017-11-03 14:11:04 -04:00
Luke Pulverenti 539fecd08b rework live stream creation 2017-09-28 13:04:06 -04:00
Luke Pulverenti e441e2f53d update active recordings 2017-08-24 15:52:19 -04:00
Luke Pulverenti f4765a87cc update m3u tuner 2017-08-20 15:10:00 -04:00
Luke Pulverenti 40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti 386ed8d34a update live stream buffers 2017-06-01 01:05:36 -04:00
Luke Pulverenti 2ca2a21737 update live stream buffer 2017-06-01 00:51:43 -04:00
Luke Pulverenti 33014f77aa update GetItems method 2017-05-26 02:48:54 -04:00
Luke Pulverenti ef6b90b8e6 make controller project portable 2016-10-25 15:02:04 -04:00
Sven Van den brande 168587b2a0 Remove unused code... 2016-03-27 23:11:27 +02:00
Luke Pulverenti 1a1fbec334 add error handling when resolving shortcuts 2015-11-30 22:54:24 -05:00
Luke Pulverenti c6ce834216 update use of FileAttributes 2015-11-12 15:51:39 -05:00
Luke Pulverenti 078277ebc2 continue file system rework 2015-10-04 00:23:11 -04:00
Luke Pulverenti 8ad702060e begin file system rework 2015-10-03 23:38:46 -04:00
Luke Pulverenti 30104bd8de probe live streams after opening 2015-04-05 11:01:57 -04:00
Luke Pulverenti d74e3b2dea connect updates 2014-10-25 14:32:58 -04:00
Luke Pulverenti 16bc3a6d77 implement fetcher priority adjustment 2014-02-11 16:41:01 -05:00
Luke Pulverenti 7c5b222463 Created ILibraryMonitor to replace IDirectoryWatchers 2014-01-28 16:25:10 -05:00
Luke Pulverenti 6c8d919298 replace file system calls with IFileSystem when needed 2013-10-31 10:03:23 -04:00
Luke Pulverenti 579b507f7f use IFileSystem interface to get creation time 2013-10-30 19:15:58 -04:00
Luke Pulverenti be7918e5f6 fixes #567 - Deprecate native shortcut code 2013-10-30 10:40:14 -04:00
Luke Pulverenti 7c9c0c999d safer shortcut migration 2013-10-01 16:20:48 -04:00
Luke Pulverenti 2da4ef2a01 limit knowledge of lnk files 2013-10-01 15:25:12 -04:00
Luke Pulverenti 8f002964fb parse shortcuts without native code 2013-10-01 15:18:52 -04:00
Luke Pulverenti 3d40c5ba36 fixed xml providers running over and over 2013-10-01 14:24:27 -04:00
Luke Pulverenti 60780399c5 allow request header overrides 2013-09-17 22:43:34 -04:00
Luke Pulverenti 1496991096 use StringBuilder in GetValidFilename 2013-09-10 21:50:05 -04:00
Luke Pulverenti 7b6bf545da removed network option from directory picker due to unreliability 2013-09-05 10:42:17 -04:00
Luke Pulverenti 8d5c0cbe04 fixes around saving music brainz id's to xml 2013-08-25 13:18:56 -04:00
Luke Pulverenti dab5003d6b added collection type 2013-07-12 15:56:40 -04:00
Luke Pulverenti 30e135e576 use linq on file system ops when possible 2013-06-20 10:40:05 -04:00
Luke Pulverenti 830e5c01f1 reduce memory usage from file system info 2013-06-19 22:21:50 -04:00