Commit Graph

1538 Commits

Author SHA1 Message Date
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero a8a8ce4e7b Fix build from PR merging 2021-12-23 19:27:51 -07:00
Cody Robibero 076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00
Cody Robibero 00211ca056
Merge pull request #7028 from cvium/everything_went_wrong 2021-12-22 17:57:00 +00:00
cvium 05c8834a3a Don't cache special feature ids 2021-12-21 00:10:58 +01:00
cvium 9158511017 Don't skip extras refresh when replacing metadata or doing a full refresh 2021-12-20 23:58:09 +01:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
cvium 83a94aa612 Fix extras folders 2021-12-20 12:15:20 +01:00
cvium 91f3ce3109 Use == instead of Object.Equals to avoid closure allocation 2021-12-19 18:24:05 +01:00
Claus Vium 9a0618552b
Merge branch 'master' into what_could_go_wrong 2021-12-15 08:38:39 +01:00
Cody Robibero 0edf77994a Cache BaseItemKind 2021-12-14 07:41:29 -07:00
cvium c5569c701c Folder can't have extras 2021-12-12 19:04:22 +01:00
Cody Robibero 32629cd7da Use BaseItemKind where possible 2021-12-12 06:11:27 -07:00
cvium fde84a1e00 Refactor extras parsing 2021-12-07 15:24:57 +01:00
Jonas Resch 180e2dc329 Prevent crashes in specific scenarios 2021-12-01 21:05:43 +01:00
Jonas Resch 9978164438 Add support for external audio files 2021-11-30 19:31:46 +01:00
Cody Robibero b2b4bd82d7
Merge pull request #6862 from 1337joe/query-instead-of-filtering 2021-11-20 08:50:39 -07:00
Joe Rogers 9ba7bf96ef
Query MediaSourceManager directly in image providers
Add doc comments/minor tweaks to AudioImageProvider
2021-11-18 15:11:50 +01:00
Joe Rogers 7cf5767949
Query media streams by type instead of filtering 2021-11-17 22:34:04 +01:00
Bond_009 257e1be95f Fix some warnings 2021-11-16 16:31:57 +01:00
cvium 5b1b2621ab Fix build 2021-11-16 12:25:46 +01:00
cvium b50c3852ef Remove unused dependencies 2021-11-16 12:24:17 +01:00
Bond_009 1d19a5be61 Fix some warnings
down to 580
2021-11-09 22:29:33 +01:00
Bond_009 5726535a26 Fix some warnings
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero 64652b6392 Fix and disable new dotnet6 warnings 2021-11-08 12:40:52 -07:00
Joe Rogers b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot 2021-11-06 20:43:20 +01:00
Bond_009 924c6682b9 Remove unused IHasScreenshots interface 2021-11-04 01:06:21 +01:00
Bond_009 416894008e Minor improvements
* Removed some allocations
* Removed some useless abstractions
2021-11-03 14:02:57 +01:00
Joe Rogers 7fcf01235c
Change RemoveImages to array, improve download test 2021-11-02 16:16:06 +01:00
Joe Rogers b478b115e3
Refactor to validate all images up front 2021-11-01 11:53:31 +01:00
KonH e3fccd5ae6 Fix warning: Qualifier is redundant (#2149) 2021-10-03 11:01:40 +07:00
Cody Robibero 9234e5bf80 Remove all instances of en-US culture 2021-09-26 09:11:25 -06:00
Dixin 27e32083a1
Update LINQ query according to code review feedback.
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-09-20 00:27:51 -07:00
Dixin dc8420c7a2 Fix extra folder type resolving. 2021-09-19 16:54:00 -07:00
Bond_009 0d16c48998 Fix some warnings 2021-09-09 15:59:13 +02:00
dkanada b8eb8940c7
Merge pull request #6257 from MrTimscampi/music-library-backdrop
Use artist backdrop for generated library image
2021-09-06 02:30:49 +09:00
Claus Vium 66659b0842
Merge pull request #6089 from BaronGreenback/IsRoot_fix
Set UserRootFolder.IsRoot to true
2021-09-05 15:25:40 +02:00
Bond_009 637e86478f Fix some warnings 2021-09-03 19:32:11 +02:00
Bond-009 3ec7ecf399
Merge pull request #6358 from MrTimscampi/audio-people 2021-09-03 17:15:58 +02:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
MrTimscampi 3300d2d7d3 Enable people for audio files 2021-08-16 00:20:48 +02:00
Rich Lander e7a3552aae Update per feedback 2021-08-15 10:32:23 -07:00
Rich Lander 312e2685f8
Update MediaBrowser.Controller/Entities/IHasMediaSources.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-08-15 10:30:12 -07:00
Rich Lander e3df4dcaae Fix warnings in MediaBrowser.Controller 2021-08-13 20:34:36 -07:00
Rich Lander ad6f27143f
Update MediaBrowser.Controller/Entities/Folder.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-08-11 13:38:23 -07:00
Rich Lander e72868f72b
Update AggregateFolder.cs 2021-07-26 18:13:37 -07:00
Rich Lander 0ce7a15534 Fix more warnings 2021-07-23 16:36:27 -07:00
Rich Lander a16e66615c
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-07-23 14:19:48 -07:00
Rich Lander 32616d15f2
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-07-23 14:19:44 -07:00
Rich Lander a7cc77e7fa Fix partial set of MediaBrowser.Controller/Entities warnings 2021-07-23 13:49:18 -07:00
Bond-009 c22582b5aa
Merge pull request #6281 from crobibero/controller-warn-04 2021-07-20 21:24:08 +02:00
Bond_009 915141f196 Fix some warnings 2021-07-11 22:51:36 +02:00
Cody Robibero 65f8d8c0cd [CA1801] Parameter is never used. Remove the parameter or use it in the method body. 2021-07-10 10:09:02 -06:00
MrTimscampi 8a65a6dfc3 Use artist backdrop for generated library image 2021-07-03 02:50:28 +02:00
Bond_009 981cf4cfa0 Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net 2021-06-22 09:48:40 +02:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
Claus Vium cb77f8ee28
Merge pull request #6172 from Bond-009/nullable6
Remove useless nullable directives
2021-06-12 00:22:30 +02:00
Bond-009 cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram 2021-06-12 00:20:54 +02:00
Bond_009 383c2d7374 Remove useless nullable directives 2021-06-11 23:36:10 +02:00
Claus Vium ed2f08d05f
Merge pull request #6156 from Bond-009/minor14
Minor fixes
2021-06-07 23:09:50 +02:00
Claus Vium f17d43c564
Merge pull request #6071 from BaronGreenback/DLNAFolderFixPart1
Make DLNA folders to work as expected.
2021-06-07 09:55:58 +02:00
Claus Vium b8f5a14384
Merge pull request #6117 from LinFor/pr_originaltitle_in_lookupinfo
Add OriginalTitle to ItemLookupInfo
2021-06-07 09:37:49 +02:00
Bond_009 c78457e6d3 Minor fixes 2021-06-06 18:11:51 +02:00
Cody Robibero d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) (#6078)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
PingWin 05c241da78 Add OriginalTitle to ItemLookupInfo 2021-05-27 10:36:56 +00:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
BaronGreenback 51fb6e1d2d
Merge branch 'master' into IsRoot_fix 2021-05-22 22:01:03 +01:00
BaronGreenback d0537a3271 Set isRoot to true 2021-05-21 15:07:35 +01:00
Bond-009 8d2e5ef8c6
Merge pull request #6042 from crobibero/mbc-warn-2 2021-05-18 21:21:26 +02:00
Bond_009 2b321d8b89 Enable nullable for InternalItemsQuery 2021-05-18 12:23:26 +02:00
BaronGreenback 48bb338352 Enable child items to be returned if a musicAlbum 2021-05-17 23:34:50 +01:00
crobibero 6bcbc2b88a Reduce warnings in MediaBrowser.Controller 2021-05-13 07:33:11 -06:00
Cody Robibero e3f55a0c54
Reduce warnings in MediaBrowser.Controller (#6006)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009 fb090df0b5 Enable nullable reference types for MediaBrowser.Controller 2021-05-07 00:39:20 +02:00
Bond_009 bcb4010db6 More improvements 2021-05-05 15:30:32 +02:00
Bond_009 787bcd4a83 Remove dead code 2021-05-05 14:45:08 +02:00
BaronGreenback 2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
BaronGreenback f2c10471bf
Code Clean up: Use Pattern Matching (#5838)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:37:36 +02:00
Claus Vium b9d18f0fa7
Merge branch 'master' into allocationz 2021-05-03 22:52:31 +02:00
Bond-009 360d80c873
Merge pull request #5890 from Bond-009/filesystem
Reduce string allocations/fs lookups in resolve code
2021-04-30 20:45:43 +02:00
cvium 608cba817c Reduce some allocations with the magic of spans etc. 2021-04-30 15:09:36 +02:00
Bond-009 eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
Bond_009 b323044139 Reduce string allocations/fs lookups in resolve code 2021-04-22 01:24:21 +02:00
Bond_009 f46195899e Improve perf of db save and query 2021-04-21 22:25:08 +02:00
Bond-009 24103d0953
Merge pull request #5876 from Bond-009/nullref5
DeepCopy: Throw ArgumentNullException if one of the args is null
2021-04-21 14:08:36 +02:00
Bond-009 48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf 2021-04-21 13:52:51 +02:00
Bond_009 63e9b1ae2d DeepCopy: Throw ArgumentNullException if one of the args is null 2021-04-20 22:59:51 +02:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
cvium d44b2e2ee5 fixes 2021-04-13 20:12:50 +02:00
cvium 723b6abcb3 Optimize the way items are grouped into collections 2021-04-13 15:38:13 +02:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
cvium c5a870051a Use distinct for artists to avoid double refreshing 2021-03-10 08:20:02 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
crobibero 223b42aed3 Create BaseItemKind enum 2021-02-10 17:09:23 -07:00
Bond_009 a9b497720d Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.

```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

|          Method |       Mean |    Error |   StdDev |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
|  RoundTripBytes |   932.0 ns |  5.09 ns |  4.25 ns | 0.1173 |     - |     - |     368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 |     - |     - |     464 B |
```
2021-01-12 15:37:18 +01:00
David 043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David b9dbdc7e54 Remove custom Json serializer from MediaBrowser.Controller 2020-12-23 13:25:49 +01:00
crobibero ee23d06154 Use a more descriptive function name 2020-12-13 08:15:26 -07:00
crobibero f5cce9e630 Use typed UserManager GetPreference 2020-12-11 15:04:14 -07:00
crobibero b670937c3d Use typed UserManager GetPreference 2020-12-11 15:00:43 -07:00
cvium 15a3d8d626 Forgot to revert some other changes, dunno if needed 2020-12-10 18:02:12 +01:00
Claus Vium f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
Gary Wilber f4edca7c27 Move MetadataRefreshThrottler to BaseItemManager 2020-12-02 18:51:53 -08:00
Joshua M. Boniface a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
Playback (direct-stream/transcode) of BDISO/BDAV containers
2020-12-01 22:36:04 -05:00
BaronGreenback e8cb9cea7d
Merge branch 'master' into library_scan_speed 2020-11-21 22:54:40 +00:00
Joshua M. Boniface bf54b5579c
Merge branch 'master' into defer_image_fetching 2020-11-21 17:20:31 -05:00
Joshua M. Boniface 7457c4a95d
Merge pull request #4499 from crobibero/more-param
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
2020-11-20 12:34:18 -05:00
Gary Wilber 4a22380565 Merge remote-tracking branch 'upstream/master' into library_scan_speed 2020-11-19 18:44:16 -08:00
Joshua M. Boniface 212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium 15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback 9a323f6df0 More spelling corrections. 2020-11-18 13:46:14 +00:00
crobibero 3cc0dd7e12 Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage. 2020-11-16 20:29:46 -07:00
Kayila d0cf60e145 Fixes #4465 by adding the missing extras folders. 2020-11-11 13:47:42 -05:00
Gary Wilber e6d8c02944 Merge remote-tracking branch 'upstream/master' into library_scan_speed 2020-11-08 11:51:40 -08:00
cvium 584b4fa41f Fix Persons, Genres and Studios endpoints 2020-11-05 12:27:22 +01:00
Anthony Lavado 6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
Stan 3bb8884e16
Merge branch 'master' into bdiso-playback 2020-10-28 13:18:05 +01:00
crobibero 64b32d3290 Use BaseItemManager 2020-10-27 18:01:52 -06:00
Bond_009 5a9c218324 Fix build 2020-10-17 16:27:31 +02:00
Bond_009 49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00
cvium 763862cbd8 Defer image pre-fetching until the end of a refresh/scan 2020-10-03 13:36:53 +02:00
Gary Wilber a51adec836 fix parallelism when set to 0 2020-10-02 18:26:10 -07:00
Gary Wilber 8f2fbf7a99 Switch to TPL dataflow for subfolder scan 2020-10-01 16:24:35 -07:00
Stanislav Ionascu cd4641dca0 Remove PlayableStreamFileNames as unused
Since ffmpeg can play and transcode ISO files and BDMV folders directly,
there's no use of that property.
2020-10-01 22:20:34 +02:00
Gary Wilber c2276b17cb Increase library scan and metadata refresh speed 2020-09-30 19:33:34 -07:00
Matt Montgomery 53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
Bond-009 5e76d5fd56
Merge pull request #3879 from cvium/fix_theme_songs
Populate ThemeVideoIds and ThemeSongIds
2020-09-04 13:13:39 +02:00
Claus Vium abc527329d Sort by SortName after scanning 2020-09-03 14:49:02 +02:00
Erwin de Haan 208b00fbb1 Add the item path to the ItemLookupInfo class.
This is important for the Shoko Anime Meatdata provider plugin.
2020-09-02 20:11:31 +02:00
Bond_009 c4d8275fc1 Fix duplicate 2020-08-23 00:26:32 +02:00
Bond_009 404bb4f835 Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release 2020-08-22 21:56:24 +02:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009 ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
Bond_009 68edccd9f4 More warn 2020-08-19 18:02:34 +02:00
Bond_009 2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
cvium e10693cbe0 Remove some LINQ queries 2020-08-12 22:14:14 +02:00
cvium 1ae3dc202c Populate ThemeVideoIds and ThemeSongIds 2020-08-11 22:04:41 +02:00
Bond-009 b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
Bond_009 febb6bced6 Review usage of string.Substring (part 1)
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Patrick Barron ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
Patrick Barron 6d1b00da64 Use Array.Empty 2020-07-04 11:54:25 -04:00
crobibero 1398c2117c Revert ILoggerFactory usage in BaseItem.cs 2020-06-23 07:31:59 -06:00
telans 6556bec646
brace multiline if statements (cont.) 2020-06-20 21:19:16 +12:00
telans 7f307f9082
brace multiline if statements 2020-06-20 21:12:36 +12:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans 8de6452967
fix some documentation periods 2020-06-20 18:13:11 +12:00
telans afe09612e8
fix SA1119 2020-06-20 18:13:11 +12:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00