Commit Graph

63 Commits

Author SHA1 Message Date
Cody Robibero e7b8d45bbb
Use helper function to compare guid (#10825) 2024-01-17 08:51:39 -07:00
Joe Rogers 1c3a97bf6a
Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Joe Rogers 160baa02fd
Remove some BaseItem references to make ItemResolveArgs more usable for testing. 2023-03-06 22:18:26 -05:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Rich Lander e72868f72b
Update AggregateFolder.cs 2021-07-26 18:13:37 -07:00
Rich Lander 0ce7a15534 Fix more warnings 2021-07-23 16:36:27 -07:00
Rich Lander a16e66615c
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-07-23 14:19:48 -07:00
Rich Lander 32616d15f2
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-07-23 14:19:44 -07:00
Rich Lander a7cc77e7fa Fix partial set of MediaBrowser.Controller/Entities warnings 2021-07-23 13:49:18 -07:00
Cody Robibero d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) (#6078)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
crobibero 6bcbc2b88a Reduce warnings in MediaBrowser.Controller 2021-05-13 07:33:11 -06:00
Cody Robibero e3f55a0c54
Reduce warnings in MediaBrowser.Controller (#6006)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009 fb090df0b5 Enable nullable reference types for MediaBrowser.Controller 2021-05-07 00:39:20 +02:00
Bond_009 b323044139 Reduce string allocations/fs lookups in resolve code 2021-04-22 01:24:21 +02:00
Bond_009 404bb4f835 Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release 2020-08-22 21:56:24 +02:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond_009 5edb8159a7 Fix Json serialization error 2019-10-15 17:49:49 +02:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan ba610b5094 Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller 2019-01-13 21:01:16 +01:00
Erwin de Haan 26ca4b607b Visual Studio Reformat: MediaBrowser.Controller 2019-01-13 20:25:32 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009 340a2c6512 Post GPL cleanup 2019-01-03 23:19:02 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti cdd79ec7e2 update owned items 2017-09-18 12:52:22 -04:00
Luke Pulverenti e441e2f53d update active recordings 2017-08-24 15:52:19 -04:00
Luke Pulverenti f4765a87cc update m3u tuner 2017-08-20 15:10:00 -04:00
Luke Pulverenti a7db7cd40c reduce traffic from session player 2017-08-11 02:29:49 -04:00
Luke Pulverenti 40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti e91f569c15 update live tv startup 2017-06-03 03:36:32 -04:00
Luke Pulverenti 33014f77aa update GetItems method 2017-05-26 02:48:54 -04:00
Luke Pulverenti 04b6f23473 3.2.9.1 2017-03-29 02:26:48 -04:00
Luke Pulverenti ef6b90b8e6 make controller project portable 2016-10-25 15:02:04 -04:00
Luke Pulverenti d5b5c8e1a5 update display of active recordings 2016-10-11 02:46:59 -04:00
Luke Pulverenti daaae69df5 add playback of in-progress recordings 2016-10-09 03:18:43 -04:00
Luke Pulverenti ea62399fe8 use shared headroom 2016-08-15 22:40:29 -04:00
Luke Pulverenti ec111eebd3 fix folder caching 2016-08-15 20:22:59 -04:00
Luke Pulverenti 037c4e8740 improve boxset & playlist performance 2016-08-13 15:53:20 -04:00
Luke Pulverenti 0706bd5237 update DirectoryService 2016-08-06 00:48:00 -04:00
Luke Pulverenti efe9fa8a8d update playlist 2016-05-19 15:57:30 -04:00
Luke Pulverenti edfc55fdf6 fix content sometimes not appearing after restart 2016-05-19 01:20:47 -04:00
Sven Van den brande 168587b2a0 Remove unused code... 2016-03-27 23:11:27 +02:00
Luke Pulverenti 9c6cb3f8f6 update i/o methods 2015-11-13 15:49:21 -05:00