Commit Graph

67 Commits

Author SHA1 Message Date
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller (#6006)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009
fb090df0b5 Enable nullable reference types for MediaBrowser.Controller 2021-05-07 00:39:20 +02:00
Bond_009
2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Bond_009
be511ca162
Fix release build ... again 2021-01-09 15:14:26 +01:00
Bond_009
d07eef4f25
Add tests for NFO parsers 2021-01-09 15:00:59 +01:00
Gary Wilber
f4edca7c27 Move MetadataRefreshThrottler to BaseItemManager 2020-12-02 18:51:53 -08:00
Patrick Barron
9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009
404bb4f835 Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release 2020-08-22 21:56:24 +02:00
Patrick Barron
98ed90c4a2 Merge branch 'master' into event-rewrite-1 2020-08-19 18:11:17 -04:00
Bond_009
2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
crobibero
1325815182 Remove IHttpClient from Providers 2020-08-17 13:10:02 -06:00
Patrick Barron
ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00
Patrick Barron
9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
dkanada
52fde64f10 remove unused files and fix some future warnings 2020-03-09 23:30:57 +09:00
Erwin de Haan
ba610b5094 Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller 2019-01-13 21:01:16 +01:00
Erwin de Haan
3ed6f37030 EditorConfig reformat: MediaBrowser.Controller 2019-01-13 20:30:58 +01:00
Erwin de Haan
26ca4b607b Visual Studio Reformat: MediaBrowser.Controller 2019-01-13 20:25:32 +01:00
Andrew Rabert
a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
a5b82cd2ec remove unneeded async signatures 2017-10-03 14:39:37 -04:00
Luke Pulverenti
1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti
52aeb3c40b consolidate interfaces 2017-08-07 17:06:13 -04:00
Luke Pulverenti
1e5c3db9eb support individual library refreshing 2017-06-23 12:04:45 -04:00
Luke Pulverenti
a9b041a7e6 rework refresh queue 2017-04-29 22:37:51 -04:00
Luke Pulverenti
ac3ec6d185 update image saver 2017-02-04 16:22:55 -05:00
Luke Pulverenti
bba0c564c7 remove dead interface objects 2016-10-17 12:35:29 -04:00
Luke Pulverenti
50e6686987 update live stream management 2016-10-07 11:08:13 -04:00
Luke Pulverenti
88415471eb add trakt external url 2016-05-29 02:03:09 -04:00
Luke Pulverenti
4e624c2cef removed dead code 2016-05-26 13:18:58 -04:00
Thomas Gillen
556b34d000 Re-designed item identity providers 2015-09-19 22:25:19 +01:00
Luke Pulverenti
b289b4cc7f complete gdi fallback 2015-04-08 11:45:30 -04:00
Luke Pulverenti
0708dc953e add live tv collage 2015-03-14 11:38:16 -04:00
Luke Pulverenti
dbb7fd61ff add dynamic images 2015-03-14 00:50:23 -04:00
Luke Pulverenti
f39d460f04 update artist and album fields on song changes 2015-03-10 22:07:07 -04:00
Luke Pulverenti
3be4aa8dc7 add connect to startup wizard 2014-10-19 23:04:45 -04:00
Luke Pulverenti
eab030df7f fixes #916 - Support reading playstate data from nfo's 2014-09-26 22:28:13 -04:00
Thomas Gillen
0a3381471d Updating tvdb providers to use item identities 2014-05-07 22:19:04 +01:00
Thomas Gillen
a14e919a85 Added item identity providers and converters 2014-05-07 22:18:24 +01:00
Luke Pulverenti
6c5cf81752 a start to the lookup feature 2014-03-01 17:34:27 -05:00
Luke Pulverenti
8f22edb503 use modular id's on edit page 2014-02-21 16:44:10 -05:00
Luke Pulverenti
0d90f1d450 make external id's modular 2014-02-21 13:48:15 -05:00
Luke Pulverenti
13e4b2a6a7 add search methods to remote metadata providers 2014-02-19 23:53:15 -05:00
Luke Pulverenti
4e38c35373 fixed remote control flyout 2014-02-19 00:21:03 -05:00
Luke Pulverenti
4ebba2b2e8 change usage reporting to a timer 2014-02-15 17:42:06 -05:00
Luke Pulverenti
1ff62edd84 fixes #709 - show all languages 2014-02-11 22:46:27 -05:00
Luke Pulverenti
5a41d7e0fd fixes #709 - Add option to show all languages in image interface 2014-02-11 22:33:59 -05:00
Luke Pulverenti
f64f55c894 fixes #709 - Add option to show all languages in image interface 2014-02-11 22:30:50 -05:00
Luke Pulverenti
17bf59dfe3 added toggles for metadata settings 2014-02-10 23:55:01 -05:00
Luke Pulverenti
44bb192ce0 update wizard function of enable/disable local metadata saving 2014-02-09 18:08:01 -05:00
Luke Pulverenti
a29cd06883 added audio db id's to web client 2014-02-09 16:11:11 -05:00