Commit Graph

687 Commits

Author SHA1 Message Date
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Bond_009 1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero b6489e73ab
Merge pull request #7241 from Bond-009/async5 2022-02-06 15:25:48 -07:00
Bond_009 e7be01d7a5 Flush to disk async where possible 2022-01-22 23:36:42 +01:00
Bond_009 2dcb2f8a9f Ban the usage of Task.Result
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero a60cb280a3 Properly populate QueryResult 2022-01-20 08:53:06 -07:00
Bond_009 05836c8cd3 Fix warning SA1414 and CA1849 2022-01-10 10:57:32 +01:00
Bond_009 77c615ba42 Error on SA1316 2022-01-05 10:58:57 +01:00
ignacio laborde 8952819494 remove unnecessary ToList in DlnaManager 2022-01-03 15:31:08 -03:00
Bond_009 ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Cody Robibero 32629cd7da Use BaseItemKind where possible 2021-12-12 06:11:27 -07:00
cvium 0485ff1899 Create a store key constant for network 2021-11-24 13:42:14 +01:00
Cody Robibero 5b7e8a27fb Fix creating DLNA profiles 2021-11-21 11:48:30 -07:00
cvium 93fd1c7075 Fix 2021-11-16 12:27:27 +01:00
cvium b50c3852ef Remove unused dependencies 2021-11-16 12:24:17 +01:00
Marius Luca a774d1fa10 - flush the XmlWriter before calling the StringBuilder ToString() method 2021-11-14 20:46:17 +02:00
Cody Robibero 4c88bf3fe3
Merge pull request #6808 from cvium/dlnope_never_again 2021-11-09 20:34:09 -07:00
cvium efa76c0b63 Remove unused field 2021-11-09 23:17:27 +01:00
cvium 3f09fb8d70 length 2021-11-09 22:45:34 +01:00
Bond_009 1d19a5be61 Fix some warnings
down to 580
2021-11-09 22:29:33 +01:00
Claus Vium c3523e7cf7
Merge pull request #5905 from BaronGreenback/TVFix
Fix for Livetv and DLNA when bind interfaces specified.
2021-11-09 19:53:21 +01:00
cvium a90735bc5a Last small fixes 2021-11-09 19:44:21 +01:00
cvium 37a04d5dbf Reduce indentation 2021-11-09 19:40:36 +01:00
cvium e1f7f1405e Use GetOrderBy in GetChildrenSorted 2021-11-09 19:33:15 +01:00
cvium 6985a4f255 Fix SortCriteria and refactor SetSorting 2021-11-09 19:31:54 +01:00
cvium 53c16c2342 Build an array instead of using LINQ 2021-11-09 19:22:16 +01:00
cvium c1c77c8762 comments 2021-11-09 19:19:48 +01:00
cvium 2b02b53fc0 Merge branch 'master' into dlnope_never_again 2021-11-09 16:00:14 +01:00
cvium 996500b2f8 review stuff 2021-11-09 15:57:39 +01:00
Claus Vium 66912deb84
Apply suggestions from code review 2021-11-09 14:47:42 +01:00
Claus Vium ac06022e0f
Update Emby.Dlna/ContentDirectory/ControlHandler.cs 2021-11-09 14:40:51 +01:00
cvium a236f52c31 Simplify and reduce LOC in ControlHandler 2021-11-08 23:13:12 +01:00
Cody Robibero 40045d2147 Update to full dotnet 6 2021-11-08 09:40:12 -07:00
cvium 82e6a21f3b Use the new method in DLNA 2021-11-08 10:58:04 +01:00
LinFor 5c69d110cc Samsung DLNA fixes 2021-11-08 11:24:33 +03:00
Cody Robibero 2f6437a987 Use correct id when finding existing dlna profile 2021-10-31 08:49:24 -06:00
Cody Robibero 2b10251b32 Update to dotnet6.rc2 2021-10-12 18:31:58 -06:00
Claus Vium 1156699481
Merge pull request #6657 from Bond-009/dotnetbug 2021-10-09 12:19:44 +02:00
Claus Vium b16e6621b3
Merge pull request #6663 from crobibero/dotnet-6-rc1
Reference dotnet6-rc1 packages
2021-10-08 16:06:15 +02:00
Bond_009 f7ae3c6a85 Set AnalysisMode to AllEnabledByDefault 2021-10-06 11:39:54 +02:00
Cody Robibero 017380f1dd Reference dotnet6-rc1 packages 2021-10-04 07:43:40 -06:00
Bond_009 9af16fcb6c Remove workaround for dotnet/runtime#42790 2021-10-03 19:52:38 +02:00
Cody Robibero 9234e5bf80 Remove all instances of en-US culture 2021-09-26 09:11:25 -06:00
Bond_009 f31224fa8f Remove sync FileStream hack 2021-09-25 19:44:40 +02:00
Bond_009 4d1d9f23d5 Use new Enum.TryParse(ReadOnlySpan<char>) overload 2021-09-24 20:15:46 +02:00
Bond_009 13fbfe6091 Target net6.0 2021-09-24 20:15:46 +02:00
Bond_009 ec45808275 SsdpHttpClient: Ensure successful status code before reading response 2021-09-21 22:32:14 +02:00
Bond_009 a6d1e542e6 Reduce allocations 2021-09-19 20:53:31 +02:00
Claus Vium 74fef6c05b
Merge pull request #6177 from Bond-009/async
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
Cody Robibero ff9d14c811 Merge remote-tracking branch 'upstream/master' into authenticationdb-efcore 2021-09-03 11:01:55 -06:00
Bond_009 e3dac4fda2 Use async FileStreams where it makes sense 2021-09-02 14:02:04 +02:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Bond-009 fc9f45b42d
Merge pull request #6381 from Bond-009/nullable5
Enable nullable for DlnaManager
2021-08-15 14:14:33 +02:00
Patrick Barron 45f478f63e Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Security/IAuthenticationRepository.cs
#	MediaBrowser.Controller/Session/ISessionManager.cs
2021-08-13 21:08:24 -04:00
Bond-009 e5a29824e5
Merge branch 'master' into minor15 2021-08-13 00:33:18 +02:00
Bond_009 4e9fbabef2 Enable nullable for DlnaManager 2021-08-03 17:54:55 +02:00
Bond-009 00c90cfb21
Merge pull request #6354 from Bond-009/nullable4
Enable nullable in more files
2021-07-30 09:49:40 +02:00
Rich Lander c07e83fdf8
Invert code and style analysis configuration (#6334)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-07-30 09:49:28 +02:00
Bond_009 501de7b6dc Enable nullable in more files 2021-07-26 23:02:32 +02:00
Bond_009 8528e9bddb Improve platform checks 2021-07-12 20:21:51 +02:00
Bond_009 1f99c9b90c Minor fixes 2021-07-06 00:01:33 +02:00
Patrick Barron ae878fa051 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
2021-06-23 20:22:12 -04:00
Bond_009 981cf4cfa0 Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net 2021-06-22 09:48:40 +02:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
Patrick Barron be88efce3c Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Devices/DeviceManager.cs
#	Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
#	Emby.Server.Implementations/Security/AuthenticationRepository.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Net/ISessionContext.cs
2021-06-18 18:56:10 -04:00
Claus Vium 75704effae
Merge pull request #5659 from ssenart/feature/5644-dlna_next_track 2021-05-24 20:35:07 +02:00
Claus Vium 2f9034c94b
Update Emby.Dlna/PlayTo/Device.cs 2021-05-24 19:37:23 +02:00
Claus Vium e134a3677c
Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-05-24 19:29:29 +02:00
Patrick Barron a225f34796 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Jellyfin.Api/Helpers/RequestHelpers.cs
2021-05-18 18:09:46 -04:00
Bond_009 06caee28b7 Enable nullable reference types for Emby.Dlna 2021-05-07 14:43:50 +02:00
Maxr1998 70771fdcd6
Nullability handling for device profile classes 2021-05-01 13:06:10 +02:00
Bond-009 f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
PlayTo Fix: Use external ip not internal interface
2021-04-25 18:51:11 +02:00
Claus Vium 12496677bd
Merge pull request #5861 from BaronGreenback/ProfileMatch
Change profile matching to match what the web interface says.
2021-04-25 17:27:32 +02:00
Bond-009 184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
Various DLNA Optimizations
2021-04-22 16:45:36 +02:00
BaronGreenback 53e1b302cc Changes as requested 2021-04-21 10:18:29 +01:00
BaronGreenback 522d5a7158 Fixed indent 2021-04-20 18:17:48 +01:00
BaronGreenback 41246909dc fixed merge 2021-04-20 18:14:50 +01:00
BaronGreenback f8b717e7c5
Merge branch 'master' into ProfileMatch 2021-04-20 18:10:38 +01:00
BaronGreenback 7848ea1484 missed one. 2021-04-20 18:08:19 +01:00
BaronGreenback a99caa0daa Changed testing 2021-04-20 18:05:38 +01:00
BaronGreenback 092c610fbf
Update Emby.Dlna/DlnaManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-04-20 08:26:41 +01:00
BaronGreenback 4449217f8f simplified isMatch 2021-04-19 14:24:58 +01:00
BaronGreenback 95b733ad4c reworked code 2021-04-19 14:07:14 +01:00
BaronGreenback c68f616377 Flip fields 2021-04-19 12:36:30 +01:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback 3199d1c902 Fix: PlayTo using external ip not internal 2021-04-15 18:36:47 +01:00
Patrick Barron 8607b52541 Make device/session code async 2021-04-10 16:57:25 -04:00
Bond_009 117736aac9 Fix LogUnmatchedProfile formatting 2021-04-10 17:09:45 +02:00
Bond-009 4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
BaronGreenback d9a50cb510 Various DLNA Optimizations 2021-04-02 19:06:38 +01:00
Bond_009 aa76957338 Remove useless code 2021-04-01 19:16:00 +02:00
Stéphane Senart 3164781ce0 [5644] [DLNA] [Music] Next track command from any DLNA device does not do anything. 2021-03-30 22:18:32 +02:00
Stéphane Senart ec113816aa [5644] [DLNA] [Music] Next track command from any DLNA device does not do anything. 2021-03-29 23:43:02 +02:00
Stéphane Senart a7c82b2681 [5644] [DLNA] [Music] Next track command from any DLNA device does not do anything. 2021-03-29 12:11:38 +02:00
cvium 74e14b4ca5 fix isdirectstream default 2021-03-22 22:34:47 +01:00
cvium 7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
BaronGreenback 4bd345fbab DLNA Exception catching 2021-03-22 17:21:12 +00:00
Claus Vium baa43c6b41
Merge pull request #5475 from BaronGreenback/SSDPFix 2021-03-15 09:06:15 +01:00
Claus Vium 109f24514f
Merge pull request #5510 from BaronGreenback/DlnaFirstFix
Fix: Streaming crashing due to no deviceProfileId match.
2021-03-14 15:07:31 +01:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
BaronGreenback 1d5b7b61fb Change First to FirstOrDefault 2021-03-12 22:20:13 +00:00
BaronGreenback 1dd6036765 Fixed false starts 2021-03-10 19:56:33 +00:00
BaronGreenback 2f843b3b48 Hide msg if dlna disabled 2021-03-10 19:32:13 +00:00
Claus Vium 5592967497
Merge pull request #5403 from BaronGreenback/DLNAProfileFix 2021-03-10 11:50:08 +01:00
Bond_009 9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
Joshua M. Boniface 3c46f10e3d
Merge pull request #5315 from BaronGreenback/FixFor5280Part2 2021-03-08 18:06:40 -05:00
Joshua M. Boniface 480dd66428
Merge pull request #5402 from Ullmie02/fix-null-size
Use FileShare.None when creating files
2021-03-07 19:37:21 -05:00
BaronGreenback 75c9659e05 Fix unreachable code & assign id to each profile. 2021-03-07 14:17:32 +00:00
David 60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
Bond_009 e8413ed8c0 Use XDocument.LoadAsync instead of XDocument.Parse 2021-03-06 03:33:52 +01:00
BaronGreenback d819a1d928
Remove Content-Length header from DLNA HEAD request (#5335) 2021-03-03 15:41:18 +01:00
BaronGreenback caa8e7cdf3 fixed build 2021-02-28 10:16:28 +00:00
Claus Vium 9e77fdc70d
Merge pull request #5312 from BaronGreenback/FixFor5280 2021-02-27 20:01:51 +01:00
BaronGreenback d95ca20fc7 removed bad merge code 2021-02-27 14:05:13 +00:00
BaronGreenback a25e3c0256 fix for override ports contained in PublishedServerUrl 2021-02-27 13:56:21 +00:00
Joshua M. Boniface 7ece3c5523
Merge pull request #5273 from Bond-009/warn31 2021-02-22 21:00:46 -05:00
Bond-009 0beda0e32c
Merge pull request #5275 from BaronGreenback/upnpStartupFix
Fixes #5148
2021-02-21 19:59:15 +01:00
BaronGreenback c50d0dbc72 Fixed startup racing issue 2021-02-20 23:06:48 +00:00
Bond_009 40b9e7592f Fix build 2021-02-20 23:34:15 +01:00
Bond_009 141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
dkanada 13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
Bond_009 e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
Troy 8c640a1492 Replaced /d with [0-9], see issue #2923 2021-02-01 02:49:23 +00:00
Claus Vium b9691e8712
Merge pull request #5025 from BaronGreenback/DlnaFix 2021-01-18 14:24:35 +01:00
BaronGreenback e81b7c8f4f reverted 2021-01-18 12:17:18 +00:00
BaronGreenback 828a9b7c75 rollback 2021-01-17 23:30:56 +00:00
BaronGreenback 13012bfa27 Fix bug in GetItemId 2021-01-17 22:43:05 +00:00
BaronGreenback 620648fe81 Fixed for no data. 2021-01-15 18:55:52 +00:00
BaronGreenback 16d092a8a7 Fixed encoding issue 2021-01-15 12:17:50 +00:00
Bond-009 a554423163
Merge pull request #4976 from BaronGreenback/dlnaPortFix
Fixed DLNA Server on RC2
2021-01-08 21:06:14 +01:00
BaronGreenback 192efff791
Update DlnaEntryPoint.cs 2021-01-07 17:17:22 +00:00
Bill Thornton cfca27e99a Fix capitalization of Playstate message 2021-01-05 10:06:55 -05:00
Joshua M. Boniface ccc1b8bf92
Merge pull request #4729 from BaronGreenback/19.0RC---Fix-networkInterfaceFix 2020-12-30 19:57:53 -05:00
BaronGreenback 4c291da45c
Encoding fix for System Logs. (#4564) 2020-12-30 18:31:26 +01:00
Bond-009 054adf6379
Merge pull request #4853 from Ullmie02/servicestack-json 2020-12-30 10:33:32 +01:00
David 043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David bc0976ceac Remove custom Json serializer from Dlna 2020-12-23 13:14:40 +01:00
Bond-009 3a452463fc
Merge pull request #4849 from crobibero/clean-deps
Remove unused dependencies
2020-12-23 11:51:41 +01:00
crobibero 1dac2226c4 Remove unused deps 2020-12-22 08:57:51 -07:00
BaronGreenback f06d52c475 Disable API if dlna is disabled. 2020-12-18 23:29:21 +00:00
nyanmisaka 7c3f2e7c59 Correct DLNA audio codecs for PS3 and PS4
* https://manuals.playstation.net/document/en/ps3/current/video/filetypes.html
* https://manuals.playstation.net/document/en/ps4/music/mp_format_m.html
2020-12-16 21:20:29 +08:00
Greenback d69f2d7d7f DNLA over HTTP only 2020-12-07 22:06:28 +00:00
Greenback 8999871b68 cleaned change 2020-12-07 18:31:45 +00:00
Greenback d14d8145d5 Fixed createPlayList 2020-12-07 18:27:22 +00:00
Bond_009 e530401462
Remove spammy debug line 2020-12-04 22:15:00 +01:00
Bond_009 e4fd61411f Minor improvements 2020-12-02 15:38:52 +01:00
Bond_009 f6a38e6340 Add tests for GetUuid 2020-12-01 15:12:55 +01:00