Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009
5036afd691
Minor cleanup
2022-08-18 13:56:23 +02:00
Cody Robibero
7424f0ca8c
Merge pull request #7561 from DMouse10462/named-config-api-fix
...
Fix NamedConfiguration API Generation
(cherry picked from commit d7c548f3db
2022-04-17 15:45:11 -04:00
Bond_009
ea8f40e84a
More cleanup
2021-12-27 14:20:05 +00:00
cvium
76c2775d8c
Use static lambdas
2021-12-19 10:27:57 +01:00
Bond-009
cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram
2021-06-12 00:20:54 +02:00
Bond_009
0bc0601442
Fix some warnings
2021-05-28 14:33:54 +02:00
cvium
42a2cc1747
Remove some unnecessary allocations
2021-05-24 00:30:41 +02:00
Bond_009
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
2021-05-20 22:48:53 +02:00
BaronGreenback
caea2bb862
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-11-11 17:00:19 +00:00
BaronGreenback
69790ef6b8
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-09 11:24:53 +00:00
BaronGreenback
a8cee0bd36
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:04:17 +01:00
BaronGreenback
002190f0a3
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:04:09 +01:00
BaronGreenback
0e872ca65c
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:03:54 +01:00
BaronGreenback
387fdb0f13
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-11 23:50:36 +01:00
BaronGreenback
ed05ae683e
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-11 23:49:51 +01:00
Greenback
0b73a1d90f
Added extra functionality to support registrar.
2020-10-11 13:19:14 +01:00
Bond_009
e653eef44f
Fix some warnings
2020-08-31 22:20:19 +02:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
dkanada
67922dff50
Merge pull request #2041 from Bond-009/warn11
...
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009
affb58ef9e
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-12-10 16:22:03 +01:00
Bond_009
4a0df15bbd
Fix GetTranscodePath function and cache path update logline
...
* GetTranscodePath returned an empty string after the option was left
blank in the web UI
* Unified the log style for all paths
2019-12-04 22:18:37 +01:00
Bond_009
42ffddc269
Fix more warnings
2019-11-27 16:29:56 +01:00
Joshua M. Boniface
48120d01dc
Merge pull request #1991 from Bond-009/transtemp
...
Don't append transcodes to transcoding temp path
2019-11-24 15:13:50 -05:00
Bond-009
b477b3874e
Fix some warnings
2019-11-22 16:15:31 +01:00
Bond-009
d4b438791f
Don't append transcodes to transcoding temp path
2019-11-21 16:57:49 +01:00
Bond_009
3f7836d9eb
Update deps and add MultiThreading analyzer
2019-11-01 17:55:44 +01:00
Bond_009
25917db07a
Fix doc releated warnings
2019-08-09 23:50:40 +02:00
Bond-009
bdfd042d70
Merge branch 'master' into fields
2019-02-16 17:03:15 +01:00
Joshua Boniface
382b8bb509
Use Path.Combine
2019-02-09 19:14:34 -05:00
Joshua Boniface
74d2698c5f
Fix poor handling of cache directories
2019-02-09 18:37:35 -05:00
Bond_009
a6a4cd5667
Removed some unused fields
2019-02-09 15:57:42 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Erwin de Haan
838541b825
Removed loose whitespace and one .ToArray() call.
2019-01-28 22:21:14 +01:00
Erwin de Haan
1d1d7e8a37
Fixed inlining local-variable artifact.
2019-01-28 22:10:52 +01:00
Erwin de Haan
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
ffe79c8982
Check if file exists instead of catching exceptions
2019-01-27 17:00:17 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a5288115a8
Visual Studio Reformat: Emby.Server.Implementations Part A-Da
2019-01-13 20:20:16 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009
391b48614d
Remove FireEventIfNotNull
...
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00
Bond_009
a8fde5e89c
Readded some stuff
2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
2018-12-30 22:44:38 +01:00
Luke Pulverenti
369df3ffda
add smb fixes
2017-05-10 15:12:03 -04:00
Luke Pulverenti
5d55b36487
make more classes portable
2017-02-20 15:50:58 -05:00
