Commit Graph

1863 Commits

Author SHA1 Message Date
Bond_009
2b948aead9 Fix possible ArgumentNullException
```
System.ArgumentNullException: Value cannot be null. (Parameter 'source')
   at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.GetImages(BaseItem
           item, IRemoteImageProvider provider, IReadOnlyCollection`1
           preferredLanguages, CancellationToken cancellationToken,
           Nullable`1 type) in
   /home/bond/dev/jellyfin/MediaBrowser.Providers/Manager/ProviderManager.cs:line
   280
```
2021-04-13 19:53:09 +02:00
dependabot[bot]
f1c4b541c1
Bump TMDbLib from 1.7.3-alpha to 1.8.1
Bumps [TMDbLib](https://github.com/LordMike/TMDbLib) from 1.7.3-alpha to 1.8.1.
- [Release notes](https://github.com/LordMike/TMDbLib/releases)
- [Commits](https://github.com/LordMike/TMDbLib/compare/v1.7.3-alpha...v1.8.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-13 13:09:28 +00:00
cvium
35cfd760d4 Do not touch "old" local artwork unless saving locally 2021-04-11 00:27:53 +02:00
Mohamed Akram
ce4f730221 Add support for TMDB series absolute and DVD order 2021-04-09 20:02:23 +04:00
Maxr1998
24ac8a1223
Improve metadata probing to better support music videos 2021-04-06 15:34:29 +02:00
Bond_009
2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Bond-009
7c51d0a50e
Merge pull request #5671 from jellyfin/tmdbmovieprovider-originaltitle
set original title in tmdbmovieprovider
2021-04-01 17:39:22 +02:00
Claus Vium
df60d176b8
ensure only valid images are saved in ItemImageProvider 2021-04-01 15:27:28 +02:00
Claus Vium
28a0eb6d53
set original title in tmdbmovieprovider 2021-04-01 14:28:03 +02:00
Bond-009
16011d96a0
Merge pull request #5321 from Ullmie02/nfo-thumb 2021-03-25 01:10:37 +01:00
David
a4cac09d5b Use |= 2021-03-23 19:25:32 +01:00
Erwin de Haan
470305f75e Authenticated arbitrary file overwrite in SubtitleController -> SubtitleManager
GHSL-2021-050: Issue 5 Arbitrary file overwrite.
2021-03-20 01:14:59 +01:00
cvium
151156f227 Clean the entity name for non-words before searching 2021-03-17 10:29:45 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Claus Vium
84e16a8535
Merge pull request #5431 from cvium/fix_tmdb_imdbid
Use imdbid as fallback in movie provider
2021-03-10 08:37:00 +01:00
Bond-009
97fd136a8c
Merge pull request #5428 from cvium/fix_tmdb_year
Default to the searchinfo year, fallback to parsed year
2021-03-09 15:59:37 +01:00
cvium
880c8636bc Use imdbid as fallback in movie provider
Includes post-ProviderIdExtensions cleanup
2021-03-09 11:44:39 +01:00
cvium
80fb52e64f Default to the searchinfo year, fallback to parsed year 2021-03-09 10:46:54 +01:00
Bond_009
d202df6e8a Remove useless line 2021-03-09 03:22:51 +01:00
Bond_009
9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
David
60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
cvium
ba366118f9 Do not use language or imagelanguages when searching for images
TMDb API returns all images if languages are excluded, which is needed for the All Languages toggle in Identify.
2021-03-05 08:18:04 +01:00
cvium
664c5da317 return false when providerid is null or empty 2021-03-03 09:09:57 +01:00
David Ullmer
8f99bdd07c
Fix TMDb search name containing year (#5349) 2021-03-02 21:17:25 +01:00
David
16694b0cfc Add nfo thumb tag support 2021-02-28 15:00:17 +01:00
Patrick Barron
9413d974f3 Switch to using declarations in MediaBrowser.Providers 2021-02-25 20:38:18 -05:00
Joshua M. Boniface
5ce4df4178
Merge pull request #5270 from Bond-009/imdb 2021-02-22 20:59:57 -05:00
dkanada
175e2a5249
Merge pull request #5242 from jellyfin/cancellationtokens
Properly forward cancellationTokens
2021-02-20 10:52:30 +09:00
Bond_009
b2700ecf44 TMDB: Also search with IMDB or TVDB Id if specified 2021-02-19 16:09:23 +01:00
Bond_009
c1b17b2fa4 TMDB: Include year in search 2021-02-18 22:58:18 +01:00
Bond_009
e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
Mariusz Chryc
0d1f356373 Remove season name from metadata result 2021-01-26 19:04:20 +01:00
Bond_009
eeff9f52c6 Fix Omdb caching 2021-01-12 16:27:38 +01:00
crobibero
c1d1b6e9f4 Fix serialization loop 2021-01-04 07:52:44 -07:00
crobibero
a3a31952f4 Fix OMDb converter 2021-01-03 09:35:22 -07:00
Joshua M. Boniface
406ae3e43a
Merge pull request #4709 from BaronGreenback/PluginDowngrade 2020-12-31 18:47:05 -05:00
martinek-stepan
cc92f7afe5
Enable nullable for MediaBrowser.XbmcMetadata project (#4612)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Stepan <ste.martinek+git@gmail.com>
2020-12-31 12:09:25 +01:00
Cody Robibero
5c57569692
Merge branch 'master' into PluginDowngrade 2020-12-30 18:11:37 -07:00
Bond-009
054adf6379
Merge pull request #4853 from Ullmie02/servicestack-json 2020-12-30 10:33:32 +01:00
David
9e0f425783 Make RootObject and SeasonRootObject internal again 2020-12-28 23:41:46 +01:00
David
21fd124bca Code revie 2020-12-27 11:15:46 +01:00
David
f73bb92ce3 Remove manual N/A removal and write directly to stream 2020-12-26 20:00:54 +01:00
David
e0499f8769 Remove attributes 2020-12-25 19:37:38 +01:00
crobibero
fc212e5e5f Remove JsonOmdbNotAvailableConverterFactory 2020-12-25 14:43:10 +01:00
crobibero
6ddbe8420f Add tests for special Omdb json 2020-12-25 14:43:10 +01:00
David
043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
crobibero
570b4dc0d0 Explicity reference Newtonsoft.Json 2020-12-23 12:34:07 -07:00
David
2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
BaronGreenback
889e988167 Updated to latest unstable. 2020-12-23 17:25:34 +00:00
David
e2d338412f Fix OMDb "N/A" 2020-12-23 14:45:05 +01:00
David
276b219fbd Add missing options 2020-12-23 13:47:57 +01:00
David
e09d3ba9ef Remove custom Json serializer from Providers 2020-12-23 13:14:39 +01:00
crobibero
1dac2226c4 Remove unused deps 2020-12-22 08:57:51 -07:00
Greenback
ce19f2be55 Renamed Guid property to Id 2020-12-18 20:37:35 +00:00
cvium
9f6000d845 Add missing seasons during AfterMetadataRefresh 2020-12-15 08:18:36 +01:00
cvium
3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00
cvium
dd238937f4 Remember to await the async task 2020-12-10 13:44:58 +01:00
cvium
3c5bbeb80c Remove ImageFetcherPostScanTask 2020-12-10 13:38:33 +01:00
crobibero
d12fa01d7a Fix potential null reference 2020-12-07 19:10:35 -07:00
Joshua M. Boniface
670f7cacc3
Merge pull request #4651 from crobibero/iso_manager
Remove IIsoMounter and IsoMounter
2020-12-04 14:53:09 -05:00
Claus Vium
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
crobibero
ca5c20c988 Remove IIsoMounter and IsoMounter 2020-12-03 07:34:15 -07:00
Gary Wilber
2b6b2cbf31 Remove Lazy 2020-12-02 23:23:13 -08:00
Gary Wilber
f4edca7c27 Move MetadataRefreshThrottler to BaseItemManager 2020-12-02 18:51:53 -08:00
Bond_009
e4fd61411f Minor improvements 2020-12-02 15:38:52 +01:00
Joshua M. Boniface
a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
Playback (direct-stream/transcode) of BDISO/BDAV containers
2020-12-01 22:36:04 -05:00
dkanada
8b0ef119c3 remove deprecated flag to disable music plugins 2020-11-28 23:55:56 +09:00
crobibero
c4423373b6 Use proper Named HttpClient for MusicBrainz requests 2020-11-25 08:47:05 -07:00
Greenback
fe3e22be98 Null Pointer 2020-11-22 13:11:05 +00:00
BaronGreenback
d3b0080a27
Update MetadataService.cs
added return Task.CompletedTask;
2020-11-21 23:29:52 +00:00
BaronGreenback
79855a76b1
Update MetadataService.cs
removed async line 232
2020-11-21 23:21:15 +00:00
Joshua M. Boniface
bf54b5579c
Merge branch 'master' into defer_image_fetching 2020-11-21 17:20:31 -05:00
BaronGreenback
05bd1383c1
Null pointer fix. (#4527)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2020-11-21 14:22:23 +01:00
Joshua M. Boniface
b5ff91c281
Merge pull request #4298 from crobibero/bye-tvdb
Remove TheTVDB plugin from server source.
2020-11-19 14:25:12 -05:00
Joshua M. Boniface
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback
9a323f6df0 More spelling corrections. 2020-11-18 13:46:14 +00:00
Bond_009
4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
Anthony Lavado
4a70bc72ab
Merge pull request #4489 from jellyfin/dependabot/nuget/PlaylistsNET-1.1.3
Bump PlaylistsNET from 1.1.2 to 1.1.3
2020-11-17 11:52:20 -05:00
dependabot[bot]
809556eb98
Bump PlaylistsNET from 1.1.2 to 1.1.3
Bumps [PlaylistsNET](https://github.com/tmk907/PlaylistsNET) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/tmk907/PlaylistsNET/releases)
- [Commits](https://github.com/tmk907/PlaylistsNET/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2020-11-15 20:47:32 +00:00
crobibero
4b15284324 Merge remote-tracking branch 'upstream/master' into bye-tvdb 2020-11-15 13:12:43 -07:00
crobibero
e66d79fc0c Merge remote-tracking branch 'upstream/master' into http-exception 2020-11-15 13:09:05 -07:00
crobibero
dae4541bad Merge remote-tracking branch 'upstream/master' into dotnet-5 2020-11-15 11:56:35 -07:00
crobibero
95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Bond_009
ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
Bond_009
c4bb32f259
Access last element by index where possible 2020-11-14 20:28:14 +01:00
Bond_009
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[]) 2020-11-14 20:27:48 +01:00
crobibero
7ff212576e Merge remote-tracking branch 'upstream/master' into bye-tvdb 2020-11-11 08:08:06 -07:00
crobibero
83629ab6f2 Update packages to net5 2020-11-10 09:52:34 -07:00
Claus Vium
cdf979efef
Merge pull request #3196 from ferferga/images-advance
Remove "download images in advance" option
2020-11-10 10:54:23 +01:00
Fernando Fernández
103d503c15 Removed code as suggested by @cvium 2020-11-10 02:12:47 +01:00
Claus Vium
96dcd9c87e
Merge pull request #3086 from redSpoutnik/api-upload-subtitle
Add Post subtitle in API
2020-11-08 11:32:53 +01:00
Claus Vium
38185f8326
Apply suggestions from code review 2020-11-08 11:20:28 +01:00
Anthony Lavado
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
crobibero
e41e832495 Dependency catch up 2020-11-01 10:52:32 -07:00
Stan
3bb8884e16
Merge branch 'master' into bdiso-playback 2020-10-28 13:18:05 +01:00
crobibero
64b32d3290 Use BaseItemManager 2020-10-27 18:01:52 -06:00
ferferga
9fd01fade6 Remove "download images in advance" option 2020-10-19 17:28:07 +02:00
Bond_009
49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Joshua M. Boniface
19c2abb50f
Merge pull request #4261 from Spacetech/music_brainz_provider_thread_safe
Make MusicBrainzAlbumProvider thread safe and fix retry logic
2020-10-17 01:58:21 -04:00