Bond-009
aaa9cc604f
Merge pull request #6176 from nielsvanvelzen/userid-required
...
Require userId in getItems and getTrailers endpoints
2021-06-13 15:06:30 +02:00
Niels van Velzen
226abde3f7
Change userId to required in operations that would otherwise throw exceptions
2021-06-12 16:19:34 +02:00
Niels van Velzen
0a0e10e854
Fix routeMediaSourceId route parameter in SubtitleController GetSubtitle
2021-06-12 15:38:13 +02:00
Cody Robibero
9154f20b34
Don't dispose managed CancellationTokenSource ( #6139 )
2021-06-04 14:36:58 +02:00
Claus Vium
6080093b51
Merge pull request #6094 from crobibero/album-artist-sort
...
Add sorting to /Artists/AlbumArtists
2021-05-27 07:23:34 +02:00
Claus Vium
61346dd2e2
Merge pull request #5828 from jackrvan/issue-5813
...
Add NextUpCutoffDate to NextUpQuery
2021-05-27 07:22:06 +02:00
Jack
accb974605
Add optional back
2021-05-26 22:49:53 -04:00
Jack
e3ff473bd4
Review notes to set value to Datetime min value instead of null
2021-05-25 20:46:29 -04:00
crobibero
e01ce826e0
Allow sorting for AlbumArtist
2021-05-23 08:38:05 -06:00
Bond-009
d61530eb4b
Merge pull request #6083 from Bond-009/nullable4
...
Enable nullable reference types for Emby.Server.Implementations
2021-05-21 13:05:03 +02:00
Patrick Barron
b6446c06ee
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Security/AuthenticationRepository.cs
# Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
2021-05-21 00:19:07 -04:00
Patrick Barron
a0c6f72762
Migrate authentication db to EF Core
2021-05-20 23:56:59 -04:00
Patrick Barron
ab63a7745c
Add PaginatedQuery abstract class, change startIndex to skip
2021-05-20 20:48:41 -04:00
Patrick Barron
e1f7086077
Remove unnecessary query class
2021-05-20 20:39:22 -04:00
Bond-009
a937a854f2
Merge pull request #6013 from Bond-009/minor13
2021-05-21 01:29:36 +02:00
Bond_009
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
2021-05-20 22:48:53 +02:00
Patrick Barron
a225f34796
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Jellyfin.Api/Helpers/RequestHelpers.cs
2021-05-18 18:09:46 -04:00
Jack
7a17de84d9
Add optional to nextUpDateCutoff help text
2021-05-17 21:35:58 -04:00
crobibero
66b185898f
Update to dotnet5.0.6
2021-05-14 17:28:36 -06:00
Bond-009
50f617357b
Merge pull request #5929 from crobibero/sort
2021-05-11 12:41:25 +00:00
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller ( #6006 )
...
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009
56ac64e70a
Minor improvements
...
* properly dispose CancellationTokenSource
* rewrite DynamicHlsController.GetSegmentLengths
* remove dead code
2021-05-08 00:33:24 +02:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
Bond-009
a4a3f598af
Merge pull request #5982 from Bond-009/nullable
2021-05-06 23:33:41 +02:00
Bond_009
ddb04dc12b
Use new ReadAllLines extensions
2021-05-06 14:12:43 +02:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
Bond_009
91c2a57b28
Enable nullable reference types for MediaBrowser.Common
2021-05-05 12:57:01 +02:00
Bond-009
48e81e65e8
Merge pull request #5938 from cvium/allocationz
2021-05-05 09:35:30 +02:00
Bond-009
9d3f614527
Merge pull request #5943 from Maxr1998/device-profile-defaults
2021-05-05 00:40:32 +02:00
dependabot[bot]
ee92dffa82
Bump Swashbuckle.AspNetCore.ReDoc from 6.1.3 to 6.1.4
...
Bumps [Swashbuckle.AspNetCore.ReDoc](https://github.com/domaindrivendev/Swashbuckle.AspNetCore ) from 6.1.3 to 6.1.4.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases )
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.1.3...v6.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-04 09:01:23 +00:00
Claus Vium
b9d18f0fa7
Merge branch 'master' into allocationz
2021-05-03 22:52:31 +02:00
dependabot[bot]
6f722bac0f
Bump Swashbuckle.AspNetCore from 6.1.3 to 6.1.4
...
Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore ) from 6.1.3 to 6.1.4.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases )
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.1.3...v6.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-03 12:00:39 +00:00
Joshua M. Boniface
e71cd8274a
Merge pull request from GHSA-rgjw-4fwc-9v96
...
Remove /Images/Remote API endpoint
2021-05-02 16:53:36 -04:00
Joshua M. Boniface
3e4c860986
Remove /Items/RemoteSearch/Image API endpoint
2021-05-02 01:22:52 -04:00
Joshua M. Boniface
dc81d576ab
Remove /Images/Remote API endpoint
2021-05-02 01:20:58 -04:00
Maxr1998
70771fdcd6
Nullability handling for device profile classes
2021-05-01 13:06:10 +02:00
cvium
ba2e346d12
prevent cancellationtoken leakage
2021-04-30 15:27:07 +02:00
Maxr1998
e90fbe90f9
Remove extraneous 'stream' parameter
...
The argument isn't passed to the method but causes the API generator to include an unnecessary parameter.
Also fixes some typos in the documentation comments.
2021-04-30 15:07:27 +02:00
Bond-009
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
Cody Robibero
69e91c33d8
Update Jellyfin.Api/Controllers/GenresController.cs
2021-04-29 04:10:26 -06:00
crobibero
d27ca993a5
Add ability to sort on Genre, MusicGenre, Artist
2021-04-28 18:33:30 -06:00
dependabot[bot]
a3cb8dbc9d
Bump Swashbuckle.AspNetCore.ReDoc from 6.0.7 to 6.1.3
...
Bumps [Swashbuckle.AspNetCore.ReDoc](https://github.com/domaindrivendev/Swashbuckle.AspNetCore ) from 6.0.7 to 6.1.3.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases )
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.7...v6.1.3 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-26 21:47:14 +00:00
dependabot[bot]
d5037a8988
Bump Swashbuckle.AspNetCore from 6.0.7 to 6.1.3
...
Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore ) from 6.0.7 to 6.1.3.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases )
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.7...v6.1.3 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-26 12:00:48 +00:00
Bond-009
224c48821e
Merge pull request #5887 from Bond-009/perf
...
Improve perf of db save and query
2021-04-24 15:57:51 +02:00
Bond-009
1a54338e38
Merge pull request #5892 from crobibero/password-obsolete
2021-04-23 10:17:49 +02:00
Bond-009
184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
...
Various DLNA Optimizations
2021-04-22 16:45:36 +02:00
crobibero
856819e58f
Don't use obsolete Password property
2021-04-22 06:49:42 -06:00
crobibero
5b0dc21c64
Mark password property as obsolete
2021-04-21 20:46:15 -06:00
Bond_009
f46195899e
Improve perf of db save and query
2021-04-21 22:25:08 +02:00
Bond-009
d5163b4167
Merge pull request #5877 from Bond-009/circ1
...
EncodingHelper: Fix circular dependency
2021-04-21 15:49:17 +02:00
Bond_009
499bac5185
EncodingHelper: Fix circular dependency
2021-04-20 23:03:36 +02:00
cvium
8933389753
Respect user settings for transcode and remux
2021-04-19 10:49:52 +02:00
BaronGreenback
bc1cc2d04a
Remove unused using directives
2021-04-17 11:37:55 +01:00
BaronGreenback
bb6fddde9a
Group Methods
2021-04-17 11:19:09 +01:00
Jack
198cc6e76a
Some code cleanup. Allow NextUpDateCutoff to be null
2021-04-16 13:57:22 -04:00
Jack
d7855500c2
Add NextUpCutoffDate to NextUpQuery
2021-04-15 14:48:21 -04:00
Claus Vium
dc4714fe40
fix webp compatibility testing ( #5787 )
2021-04-12 19:54:32 +02:00
Cody Robibero
cc59abd54e
Mark cropWhitespace parameter as obsolete ( #5751 )
2021-04-12 15:50:24 +02:00
Joshua M. Boniface
770c123d12
Merge pull request #5764 from cvium/fix-folders-perms
...
Do not check permissions for Folders collectiontype
2021-04-11 13:30:15 -04:00
Odd Stråbø
13d0837b78
(mostly)Fix ResizeFill
2021-04-11 08:21:23 +02:00
Odd Stråbø
383aa4e4d9
Add Resize to fill box alternative to image endpoints
2021-04-11 08:20:47 +02:00
Claus Vium
bf510ca04e
Merge pull request #5750 from iwalton3/fix-audio-selection-uns
...
Fix setting audio stream in PlaybackInfo for jellyfin-web.
2021-04-10 23:10:16 +02:00
cvium
f2e7491755
Do not check permissions for Folders collectiontype
2021-04-10 22:58:32 +02:00
Patrick Barron
8607b52541
Make device/session code async
2021-04-10 16:57:25 -04:00
Patrick Barron
44e71774b1
Rewrite device manager using EF Core
2021-04-10 16:17:36 -04:00
Bond-009
b2fbf97abd
Merge pull request #4988 from Bond-009/crop
2021-04-10 02:57:43 +02:00
Ian Walton
321e383965
Fix setting audio stream in PlaybackInfo for jellyfin-web.
2021-04-09 19:24:41 -04:00
Bond-009
5042246360
Merge pull request #5710 from jellyfin/dependabot/nuget/Microsoft.AspNetCore.Authorization-5.0.5
...
Bump Microsoft.AspNetCore.Authorization from 5.0.3 to 5.0.5
2021-04-07 17:42:27 +02:00
Claus Vium
a1718e392b
Merge pull request #5631 from BrianCArnold/FixMessageCommand
2021-04-07 14:36:08 +02:00
dependabot[bot]
e85ac4d975
Bump Microsoft.AspNetCore.Authorization from 5.0.3 to 5.0.5
...
Bumps [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore ) from 5.0.3 to 5.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.3...v5.0.5 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-06 18:35:36 +00:00
Bond-009
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values
2021-04-03 19:36:41 +02:00
Bond-009
ec0ef1530c
Merge pull request #5602 from Ullmie02/IP-string-IP
2021-04-03 00:32:43 +02:00
BaronGreenback
d9a50cb510
Various DLNA Optimizations
2021-04-02 19:06:38 +01:00
Patrick Barron
499785bebb
Use new entities for API key endpoints
2021-04-01 17:08:22 -04:00
BrianCArnold
4fa2a32d81
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-31 01:24:38 -04:00
BrianCArnold
af03b280bc
Update SessionController.cs
2021-03-31 01:23:51 -04:00
BrianCArnold
80fe48fda9
Update SessionController.cs
...
Removed unnecessary construction of POCO to represent data from POST body
2021-03-30 07:29:40 -04:00
Brian Arnold
ca25301e64
Added Required attribute to Text property of MessageCommand.
2021-03-29 10:10:44 -04:00
Brian C. Arnold
998833ea6e
Removed null check for body object and user [Required] attribute in replacement.
2021-03-27 23:29:24 -04:00
Brian Arnold
f114ba57dd
Fixed comment and code block runes to match coding
...
standards required by Jellyfin team.
2021-03-27 23:29:24 -04:00
Brian Arnold
81e3e5ca48
Changed SessionController.SendMessageCommand
...
implementation receive data in the POST body, as that is how the
jellyfin-web client currently posts the data to the server.
Resolves : #5628
2021-03-27 23:29:24 -04:00
Claus Vium
9144d11a9d
Merge pull request #5624 from crobibero/subtitle-format
2021-03-27 09:25:34 +01:00
crobibero
afe3b5999e
Fix route naming
2021-03-26 17:40:55 -06:00
lmaonator
694d772b11
Update Jellyfin.Api/Controllers/SessionController.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-26 14:13:45 +01:00
crobibero
5b758c4711
Mark query parameters as obsolete
2021-03-26 07:07:45 -06:00
lmaonator
db2fbcef2b
Fix stream selection having no effect when casting
...
When casting to jellyfin-mpv-shim from jellyfin-web in the browser,
jellyfin-web sends data about which version (for grouped items) and
which streams the user selected in the browser to the
"Sessions/{sessionId}/Playing" API endpoint.
The API endpoint currently doesn't forward them to jellyfin-mpv-shim
through the Play command, which results in the default streams being
played instead of the browser selected ones.
PlayRequest already has the properties and they are already sent to the
cast client by SendPlayCommand when present.
jellyfin-mpv-shim will already use them to select the wanted streams
when it receives the Play command.
All that's needed to make it work is to take the parameters and assign
them to PlayRequest.
2021-03-26 13:41:34 +01:00
crobibero
e0ff51cf2a
Mark query parameters as obsolete
2021-03-25 20:30:15 -06:00
crobibero
73fe9d3f69
Allow subtitle format to be set from query parameter.
2021-03-25 18:06:25 -06:00
cvium
b3d084044e
enable range processing for download endpoints
2021-03-25 15:09:37 +01:00
Szymon Acedański
b1e8a8565f
Update Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-24 22:46:08 +01:00
Szymon Acedański
136136dea9
Fix incorrect responses for HEAD /audio/<id>/stream
...
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA
and returns "Error: Resource not found (716)" instead.
I had a look on tcpdump network logs between Jellyfin and the soundbar
and noticed that the device performs a HEAD request for the media before
responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP
Android App).
Jellyfin retuns 204 No Content response, which is unusual. Common web
servers generally return 200 OK if the GET would return content, and
this is not-very-clearly suggested [in HTTP
spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1 )
The other patch is to ensure, that invalid Content-Length: 0 is not
returned with the HEAD response in the streaming case.
I think in both cases we still don't return the same headers with HEAD
as with GET (e.g. Content-Length or Accept-Ranges), but at least we
don't return anything misleading.
2021-03-24 20:43:54 +01:00
David
19e4ef82dd
Remove conversion from IPAddress to string to IPAddress
2021-03-23 17:16:10 +01:00
cvium
7dedeb6c79
change HLS endpoint defaults to false
2021-03-22 20:53:55 +01:00
Erwin de Haan
1f3aa3fe6f
Apply review suggestions
2021-03-20 01:28:14 +01:00
Erwin de Haan
239a7156cc
Fix arbitrary image file reads in ImageByNameController
...
GHSL-2021-050: Issue 4 Arbitrary image file read and directory traversal.
2021-03-20 01:14:59 +01:00
Erwin de Haan
f61d18612b
Fix directory traversal in the HlsSegmentController in a fairly rudimentary but working way.
...
GHSL-2021-050: Issue 1,2,3 Arbitrary file read and directory traversal.
The segment id's can probably just be verified to be an actual ID or to not contain any forward or backward slashes
2021-03-20 01:14:59 +01:00
Patrick Barron
e5380c653b
Merge branch 'master' into ef-cleanup
...
# Conflicts:
# Jellyfin.Data/Entities/Libraries/MediaFileStream.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2021-03-14 10:19:35 -04:00
Bond-009
0e5d4a3bcf
Merge pull request #5422 from Bond-009/warn51
2021-03-14 00:41:40 +01:00
Bond-009
8bb2420a25
Merge pull request #5518 from crobibero/missing-endpoints
...
Add missing InstantMix endpoints
2021-03-13 22:59:47 +01:00
Bond_009
a8ed753f6c
FxCop -> Net Analyzers (part 2)
2021-03-13 22:33:28 +01:00