Commit Graph

281 Commits

Author SHA1 Message Date
Cody Robibero da41cd365c Suggestions from review 2022-03-06 18:17:49 -07:00
Cody Robibero bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Cody Robibero c331e11c24 Clean up EnumFlags serialization 2022-03-06 18:13:54 -07:00
Isaac Gordezky 9ebd521754 Update MediaBrowser.Model/Dlna/StreamBuilder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-03-06 18:13:54 -07:00
Isaac Gordezky 84a3db6f84 Fix transcode video matching and add tests for Transcode and Safari 2022-03-06 18:13:54 -07:00
Isaac Gordezky 5e779f20ee Series: issue-6450
Issue: https://github.com/jellyfin/jellyfin/issues/6450

Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
2022-03-06 18:13:54 -07:00
Isaac Gordezky d871dded9f Convert TranscodeReason to Flags 2022-03-06 18:13:54 -07:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero 904efeaddc Add null check for audio stream 2022-01-06 08:15:37 -07:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero 55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop 2021-12-24 02:01:44 +00:00
cvium a7a7173cd5 Force a remux/transcode with external audio files 2021-12-21 14:35:58 +01:00
Marius Luca 7d86ef6f22 - add an option for dropping specific subtitle formats using the DLNA SubtitleProfile 2021-12-09 17:52:51 +02:00
zehner bbf40d6be2 Update StreamBuilder.cs
LogLevel INFO => DEBUG
2021-11-02 09:35:09 +01:00
KonH 6cbfdea4c0 Fix warning: Type cast is redundant (#2149) 2021-10-03 11:05:18 +07:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
Bond-009 fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type 2021-04-04 01:25:09 +02:00
Dmitry Lyzo 36da7a06d7
Less negation
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-04-04 02:09:57 +03:00
Max Rumpf 21e7ceae8e
StreamBuilder tweaks (#5668)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-01 19:18:14 +02:00
Dmitry Lyzo 364e8931af Check appropriate profile type 2021-03-27 11:53:57 +03:00
Bond_009 141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
crobibero c8a95e0926 Fix null reference when logging 2020-12-24 10:05:06 -07:00
nyanmisaka b4598bd71b Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-20 10:01:17 +08:00
Nyanmisaka 5ff08338d5
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-19 15:02:36 +00:00
Joshua M. Boniface e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
Add FLAC and define the corresponding target sample rate
2020-11-17 10:29:29 -05:00
nyanmisaka 488dbdb31d Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-16 12:36:55 +08:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
nyanmisaka 57e5b59b93 adjust bitrate limit for HLS audio codecs 2020-11-11 17:10:08 +08:00
Stéphane Senart 28ee4f0a7f [AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate 2020-10-22 11:09:59 +02:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00
Maxr1998 e01209a6f5
Log stream type and codec for missing direct play profile 2020-10-03 17:14:09 +02:00
Matt Montgomery 53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Bond-009 94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009 f47ad85011 Fix warnings MediaBrowser.Model 2020-02-04 01:49:27 +01:00
Bond-009 fdbb329118 Remove StringHelper functions 2020-01-09 17:07:13 +01:00
William Lees d18823ced1 Fix potential NullReferenceException 2019-02-12 23:28:02 +11:00
Bond_009 2f8f9e6853 Address comments 2019-01-21 16:57:10 +01:00
Bond_009 06d9423f00 Clean up last bits 2019-01-21 16:48:45 +01:00
Bond_009 37be6c87eb Make ConditionProcessor static 2019-01-21 16:48:45 +01:00
Bond_009 c9b88ab741 Clean up streambuilder 2019-01-21 16:48:45 +01:00
Erwin de Haan 38f96af079 Reformat JustAMan review pt2 changes
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan 8f41ba4d3a Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model 2019-01-13 21:02:23 +01:00
Erwin de Haan 1a4b271314 Visual Studio Reformat: MediaBrowser.Model 2019-01-13 20:26:15 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti e7ffdf3fbd add StreamBuilder fix 2017-11-23 10:12:02 -05:00
Luke Pulverenti 43cb11f694 update shared stream support 2017-11-18 23:59:34 -05:00
Luke Pulverenti 1dc8ff9e91 allow specification of m3u stream limit 2017-11-17 16:54:33 -05:00
Luke Pulverenti 8ec8b46394 allow separate configuration of date format 2017-10-30 00:51:43 -04:00
Luke Pulverenti 93676f6838 revise unknown audio stream handling 2017-10-28 23:52:05 -04:00
Luke Pulverenti c583d49541 live tv subtitle fixes 2017-10-13 14:32:58 -04:00
Luke Pulverenti 4e4c145855 update hls query string 2017-09-29 16:10:13 -04:00
Luke Pulverenti d43508a898 update applyconditions 2017-09-25 15:15:01 -04:00
Luke Pulverenti 978eedbcb7 improve support for compressed xmltv 2017-09-25 01:06:15 -04:00
Luke Pulverenti de5a8d579b move season zero display name to per library settings 2017-09-24 16:23:56 -04:00
Luke Pulverenti f3120dbee9 fix application of params 2017-09-22 16:38:59 -04:00
Luke Pulverenti b4851d4789 separate deinterlacing params by video codec 2017-09-21 17:36:19 -04:00
Luke Pulverenti eb63e0d264 update image processor 2017-09-07 14:17:18 -04:00
Luke Pulverenti 82ab91f209 add property to indicate support for on the fly subtitle extraction 2017-08-23 15:45:40 -04:00
Luke Pulverenti 1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti d8e2887071 update container value 2017-08-04 16:29:34 -04:00
Luke Pulverenti e208ef19b0 check audio stream for null 2017-08-04 10:49:46 -04:00
Luke Pulverenti 31841a31a9 3.2.26.7 2017-07-30 14:02:25 -04:00
Luke Pulverenti a0e7cdd2dc support all inclusive direct play profile 2017-07-14 11:57:44 -04:00
Luke Pulverenti 6ea8e7868d add live stream params 2017-07-03 13:16:01 -04:00
Luke Pulverenti 5cafb17e8f fix stream builder error 2017-07-01 14:00:43 -04:00
Luke Pulverenti a759b09577 support max audio bit depth 2017-06-26 11:10:52 -04:00
Luke Pulverenti f2fb52761f update stream building 2017-06-25 13:50:17 -04:00
Luke Pulverenti a107ff0369 capture more transcoding info 2017-06-24 14:33:19 -04:00
Luke Pulverenti 8a780bc023 add interlaced fix 2017-06-06 02:13:27 -04:00
Luke Pulverenti 3e15b28b18 add IsInterlaced param 2017-05-29 08:35:59 -04:00
Luke Pulverenti 0beb803aed add sample rate condition 2017-05-13 15:31:25 -04:00
Luke Pulverenti 06394d1a9f add break on non keyframes 2017-03-31 15:05:19 -04:00
Luke Pulverenti c9be9b4141 update hls params 2017-03-24 11:03:49 -04:00
Luke Pulverenti 79f3eb3fe2 update live tv osd 2017-03-18 19:37:29 -04:00
Luke Pulverenti c9ee7633ca embed recording button into video player 2017-03-17 16:23:34 -04:00
Luke Pulverenti ce1ed2bea7 update hls to support mpeg2video 2017-03-15 15:57:18 -04:00
Luke Pulverenti 6091e00e18 clean related files when deleting items 2017-02-18 03:32:17 -05:00
Luke Pulverenti ab026ab2de restore localized guids switch 2017-01-29 15:00:29 -05:00
Luke Pulverenti 6066619138 handle bitrate overflow 2017-01-03 00:15:59 -05:00
Luke Pulverenti 5372c0bf23 remove unused property 2016-12-28 01:08:18 -05:00
Luke Pulverenti e1da7b80f4 update cloud sync profile 2016-12-23 12:57:47 -05:00
Luke e7cebb91a7 Merge pull request #2350 from MediaBrowser/beta
Beta
2016-12-18 00:44:33 -05:00
Luke Pulverenti de9cd28a79 remove tvos dts hack no longer needed 2016-12-14 15:58:55 -05:00