Joshua M. Boniface
5587dd8bfb
Merge pull request #900 from ploughpuff/validator
...
Implement proper FFmpeg version checking
2019-03-05 11:07:49 -05:00
Vasily
f1086a72bf
Improve logic when determining return value
...
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
2019-02-28 15:58:41 +00:00
PloughPuff
7668ecf9c9
Use Version Class to ease comparisons
2019-02-27 18:20:48 +00:00
Claus Vium
aafed63c3f
Set EnableRaisingEvents to true for processes that require it
2019-02-24 16:33:05 +01:00
PloughPuff
69ea15f73a
Use string interpolation
...
Two further review comments from JustAMan.
2019-02-16 00:47:38 +00:00
PloughPuff
d8d237f6f2
Review comments
...
Addressed review comments from JustAMan. Removed code to determine experimental version. Store major and minor as two ints. Allow control of a min and max recommended version.
2019-02-15 23:51:22 +00:00
PloughPuff
a6bde0943e
Implement proper FFmpeg version checking
...
Three routes to determine FFmpeg version:
1) Grab the 'ffmpeg version x.y' from from the -version output. This should work for all pre-built binaries.
2) Compare the library versions against known contents of FFmpeg versions. This is fallback aimed at custom builds.
3) Compare libavcodec version to determine if newer than latest known release. This suggests user is running within latest/HEAD/master build.
2019-02-14 22:08:48 +00:00
Bond_009
1cdcace061
Remove dead code
2019-02-02 15:58:39 +01:00
Bond_009
95ee3c72e3
Properly dispose Tasks
2019-02-02 15:56:54 +01:00
Bond_009
66eabcdd39
Minor changes to encoding code
...
* Don't wait in intervals of 100ms for the file to exist
2019-02-02 15:56:54 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
91e99effc9
Apply suggestions from code review for flipped conditions.
...
Co-Authored-By: EraYaN <EraYaN@users.noreply.github.com>
2019-01-29 14:45:07 +01:00
Erwin de Haan
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
a430568082
Unwrapped OpenRead
and CopyFile
2019-01-28 22:09:58 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Tthecreator
0b80902cc8
Set EnableRaisingEvents correctly for SubtitleEncoder
2019-01-22 16:52:26 +01:00
Andrew Rabert
d16f38dbe1
Merge pull request #623 from wtayl0r/inject-logger-factories
...
Replaced injections of ILogger with ILoggerFactory
2019-01-20 18:12:50 -05:00
Andrew Rabert
a1fcf4ea0d
Merge pull request #613 from MatMaul/mediaencoding-dev
...
Update MediaEncoding
2019-01-20 18:11:51 -05:00
Mathieu Velten
da16de48aa
Revert back to 10e57ce8d21b4516733894075001819f3cd6db6b for MediaEncoding
...
Remove some duplicate code that were causing warnings
2019-01-20 22:50:09 +01:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Claus Vium
e8cf72e925
Change CanExtractSubtitles to true to allow conversion during direct streaming
2019-01-20 21:03:18 +01:00
Andrew Rabert
3a6624f701
Merge pull request #629 from cvium/fix_subtitleencoder
...
Fix subtitle converter misinterpreting 0 valued endTimeTicks
2019-01-20 11:35:20 -05:00
Claus Vium
2b47006662
Remove unneeded variable
2019-01-20 17:06:40 +01:00
Claus Vium
2dc14aa85d
Remove CodePages from csproj
2019-01-20 11:41:33 +01:00
Claus Vium
26e20d1cd5
Fix subtitle converter misinterpreting 0 valued endTimeTicks
2019-01-20 08:17:31 +01:00
cvium
790266d314
Add package ref for codepages
2019-01-20 06:30:52 +01:00
cvium
b35dcbb9f0
Remove MediaBrowser.Text since it violates licenses and is overall hacky
2019-01-20 06:30:50 +01:00
Erwin de Haan
c5430f86b0
Fixed csproj and xml identation.
2019-01-19 15:01:16 +01:00
Erwin de Haan
38f96af079
Reformat JustAMan review pt2 changes
...
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
2019-01-13 21:31:14 +01:00
Erwin de Haan
9fa60ec934
Find+Sed BOM removal all toher files, except test files.
2019-01-13 21:20:44 +01:00
Erwin de Haan
089ad8e7c2
Find+Sed BOM removal *.xml,*.csproj,*,json,*.sln,*.txt
2019-01-13 21:10:15 +01:00
Erwin de Haan
8f41ba4d3a
Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model
2019-01-13 21:02:23 +01:00
Erwin de Haan
742bef5b5f
EditorConfig reformat: Non-CS files.
2019-01-13 20:45:51 +01:00
Erwin de Haan
f2e50f50bd
Visual Studio Reformat: MediaBrowser.MediaEncoding
2019-01-13 20:26:04 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Andrew Rabert
e5c2dbdf23
Merge pull request #540 from joshuaboniface/api-keys
...
Update Emby API keys to our own
2019-01-10 23:02:29 -05:00
Joshua M. Boniface
15c89d281e
Merge pull request #506 from hawken93/linting
...
Removing tabs and trailing whitespace
2019-01-10 19:54:18 -05:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Anthony Lavado
5900ab8c68
Update OpenSubtitles User Agent to our own
2019-01-10 13:26:52 -05:00
Bond_009
f520ddc966
Remove useless properties from IEnvironmentInfo
2019-01-08 17:35:56 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Andrew Rabert
237187bfc0
Merge pull request #456 from Bond-009/subencoder
...
SubtitleEncoder: stop using tuples for clarity
2019-01-06 18:29:12 -05:00
Anthony Lavado
0a715f9196
Merge pull request #435 from Bond-009/ffmpeglogs
...
Reduce log spam from ffmpeg info
2019-01-06 16:59:37 -05:00
Bond_009
73fd0cd8c6
SubtitleEncoder: stop using tuples for clarity
...
* Replace Tuples with a ValueTuple or a struct
2019-01-06 21:02:25 +01:00