Commit Graph

166 Commits

Author SHA1 Message Date
cvium
381db60ed3 fix test 2021-04-09 15:05:39 +02:00
cvium
457229c56d Simplification 2021-04-09 13:43:40 +02:00
cvium
23c3188501 revert underscore as a multiversion separator 2021-03-15 23:24:59 +01:00
Bond-009
d7f0aaaec1
Merge pull request #5417 from Bond-009/codeanal
Add code analysis attributes where appropriate
2021-03-12 00:15:12 +01:00
cvium
b0af11c34e make the eligibility check more strict wrt. brackets 2021-03-10 19:29:52 +01:00
cvium
3824c09e77 fix multiversion eligibility check for complex folder names 2021-03-10 10:47:35 +01:00
Bond_009
9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
Bond_009
5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
cvium
fcacae8cde return empty span instead of null for backwards compat 2021-03-07 22:59:08 +01:00
cvium
e0db17a935 do not throw ArgumentNullException in TryCleanString 2021-03-07 22:49:31 +01:00
dkanada
13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
Bond_009
8a6242826f 100% branch coverage for Emby.Naming 2021-02-13 11:38:17 +01:00
Bond_009
65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
dkanada
995b370017
Merge pull request #4663 from joshuaboniface/bump-version-10.8.0
Bump version to 10.8.0 for next release
2021-02-09 11:38:31 +09:00
Bond_009
88f37833df Remove last usage of \d 2021-02-08 16:33:37 +01:00
dkanada
aea1c4f310
Merge pull request #5142 from M0ssTee/updateRegex
Replaced /d with [0-9], see issue #2923
2021-02-08 22:52:58 +09:00
dkanada
2e9661c415
Merge pull request #5043 from senritsu/improve-episode-number-parsing-with-digits-in-names
adjust episode path expression to allow digits in series names
2021-02-05 11:43:32 +09:00
Troy
8c640a1492 Replaced /d with [0-9], see issue #2923 2021-02-01 02:49:23 +00:00
Bond_009
956ca0e5aa 100% branch coverage for Jellyfin.Naming 2021-01-21 15:46:10 +01:00
senritsu
4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
Joshua M. Boniface
5f2cd11199 Bump version to 10.8.0 for next release 2020-12-04 21:56:24 -05:00
crobibero
20251e670f Fix tests 2020-11-22 14:39:34 -07:00
crobibero
2aefe9ed5a Only trim file name if folder name is shorter 2020-11-22 14:17:42 -07:00
Greenback
e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
martinek-stepan
04a712ab1d
Update Emby.Naming/Video/VideoFileInfo.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-11-17 15:11:32 +01:00
Stepan
d481c35cad Merge fix 2020-11-17 13:06:56 +01:00
BaronGreenback
2bbfcc264d
Merge branch 'master' into emby-namig-nullable 2020-11-16 19:47:36 +00:00
martinek-stepan
4bfcc8b0d1
Update Emby.Naming/AudioBook/AudioBookListResolver.cs
Use StringComparison.OrdinalIgnoreCase when comparing names

Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 16:51:52 +01:00
Stepan
b66239fd52 One more missed suggestions (removing commented out code) 2020-11-12 13:18:22 +01:00
Stepan
3bca1181b3 Taken suggestions from code review and created test for ExtraRuleType.Regex instead of throwing exception there. 2020-11-12 13:16:33 +01:00
martinek-stepan
496923719c
Apply suggestions from code review
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 12:54:55 +01:00
Stepan
158eff62d7 Xml-doc part2 2020-11-10 19:23:10 +01:00
crobibero
83629ab6f2 Update packages to net5 2020-11-10 09:52:34 -07:00
Stepan
693760e38a Xml-doc part1 2020-11-10 17:11:48 +01:00
Stepan
c0747512d6 Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable 2020-11-10 12:42:49 +01:00
crobibero
78551d166a Don't throw exception if name is null 2020-11-09 06:10:16 -07:00
Stepan
f22e0800e2 Episode parsing coverage 2020-11-07 11:02:12 +01:00
Stepan
e96e480f01 Add comment with match cases for weir EpisodeExpression and named group for some date EpisodeExpressions 2020-11-06 15:52:01 +01:00
Stepan
3466dc5581 Finish coverage for Emby.Naming.Video 2020-11-05 16:59:15 +01:00
Stepan
5741150367 Enable MultiVersion video tests and added support for naming based on tests 11 & 8 2020-11-05 14:51:27 +01:00
Stepan
c060ed1a18 Added resolving of alternative files and extras for audibooks. 2020-11-03 16:24:04 +01:00
Stepan
1e71775688 Add Name and Year parsing for audiobooks 2020-11-02 20:03:12 +01:00
Stepan
f39775dc3a Written test to finish coverage for AudioBookListResolver & AudioBookResolver and corrected some logical erros / unhandled exception 2020-11-01 17:10:48 +01:00
Stepan
e7a37bedfc Simplify AudioBookResolver since there is no option of passing directories into it (AudioResolver.cs:179) and handling directories were not implemented anyway 2020-11-01 13:42:56 +01:00
Stepan
6437cf6950 Removed Success property from AudioBookFilePathParserResult, since it was unused and consider only audiobooks that have chapter/page number in name makes no sense 2020-11-01 13:28:43 +01:00
Stepan
60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan
59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
Bond_009
74f4affcda Fix AudioBookListResolver test coverage 2020-10-12 20:09:15 +02:00
Bond_009
228b33a23b Minor improvements 2020-09-20 14:02:41 +02:00
Keridos
b9c7cce696
some testing for AudioBook
fix PartNumber detection
2020-09-09 02:24:17 +02:00