Commit Graph

275 Commits

Author SHA1 Message Date
Bond_009 b202bfebce Fix episode parser 2021-07-15 16:05:57 +02:00
Bond_009 1f99c9b90c Minor fixes 2021-07-06 00:01:33 +02:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
cvium 66de842896 Use stackalloc in Format3DParser.Parse 2021-06-12 00:16:33 +02:00
Claus Vium 3b5214e595
Update Emby.Naming/Video/VideoListResolver.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-05-28 19:01:29 +02:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
cvium 1027792b16 Review changes 2021-05-19 08:51:46 +02:00
cvium 415e8fc0f3 Forward 2021-05-16 14:54:36 +02:00
cvium 1b49435a0e Reduce some allocations 2021-05-16 14:49:11 +02:00
cvium 381db60ed3 fix test 2021-04-09 15:05:39 +02:00
cvium 457229c56d Simplification 2021-04-09 13:43:40 +02:00
cvium 23c3188501 revert underscore as a multiversion separator 2021-03-15 23:24:59 +01:00
Bond-009 d7f0aaaec1
Merge pull request #5417 from Bond-009/codeanal
Add code analysis attributes where appropriate
2021-03-12 00:15:12 +01:00
cvium b0af11c34e make the eligibility check more strict wrt. brackets 2021-03-10 19:29:52 +01:00
cvium 3824c09e77 fix multiversion eligibility check for complex folder names 2021-03-10 10:47:35 +01:00
Bond_009 9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
Bond_009 5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
cvium fcacae8cde return empty span instead of null for backwards compat 2021-03-07 22:59:08 +01:00
cvium e0db17a935 do not throw ArgumentNullException in TryCleanString 2021-03-07 22:49:31 +01:00
dkanada 13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
Bond_009 8a6242826f 100% branch coverage for Emby.Naming 2021-02-13 11:38:17 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
dkanada 995b370017
Merge pull request #4663 from joshuaboniface/bump-version-10.8.0
Bump version to 10.8.0 for next release
2021-02-09 11:38:31 +09:00
Bond_009 88f37833df Remove last usage of \d 2021-02-08 16:33:37 +01:00
dkanada aea1c4f310
Merge pull request #5142 from M0ssTee/updateRegex
Replaced /d with [0-9], see issue #2923
2021-02-08 22:52:58 +09:00
dkanada 2e9661c415
Merge pull request #5043 from senritsu/improve-episode-number-parsing-with-digits-in-names
adjust episode path expression to allow digits in series names
2021-02-05 11:43:32 +09:00
Troy 8c640a1492 Replaced /d with [0-9], see issue #2923 2021-02-01 02:49:23 +00:00
Bond_009 956ca0e5aa 100% branch coverage for Jellyfin.Naming 2021-01-21 15:46:10 +01:00
senritsu 4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
Joshua M. Boniface 5f2cd11199 Bump version to 10.8.0 for next release 2020-12-04 21:56:24 -05:00
crobibero 20251e670f Fix tests 2020-11-22 14:39:34 -07:00
crobibero 2aefe9ed5a Only trim file name if folder name is shorter 2020-11-22 14:17:42 -07:00
Greenback e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
martinek-stepan 04a712ab1d
Update Emby.Naming/Video/VideoFileInfo.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-11-17 15:11:32 +01:00
Stepan d481c35cad Merge fix 2020-11-17 13:06:56 +01:00
BaronGreenback 2bbfcc264d
Merge branch 'master' into emby-namig-nullable 2020-11-16 19:47:36 +00:00
martinek-stepan 4bfcc8b0d1
Update Emby.Naming/AudioBook/AudioBookListResolver.cs
Use StringComparison.OrdinalIgnoreCase when comparing names

Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 16:51:52 +01:00
Stepan b66239fd52 One more missed suggestions (removing commented out code) 2020-11-12 13:18:22 +01:00
Stepan 3bca1181b3 Taken suggestions from code review and created test for ExtraRuleType.Regex instead of throwing exception there. 2020-11-12 13:16:33 +01:00
martinek-stepan 496923719c
Apply suggestions from code review
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 12:54:55 +01:00
Stepan 158eff62d7 Xml-doc part2 2020-11-10 19:23:10 +01:00
crobibero 83629ab6f2 Update packages to net5 2020-11-10 09:52:34 -07:00
Stepan 693760e38a Xml-doc part1 2020-11-10 17:11:48 +01:00
Stepan c0747512d6 Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable 2020-11-10 12:42:49 +01:00
crobibero 78551d166a Don't throw exception if name is null 2020-11-09 06:10:16 -07:00
Stepan f22e0800e2 Episode parsing coverage 2020-11-07 11:02:12 +01:00
Stepan e96e480f01 Add comment with match cases for weir EpisodeExpression and named group for some date EpisodeExpressions 2020-11-06 15:52:01 +01:00
Stepan 3466dc5581 Finish coverage for Emby.Naming.Video 2020-11-05 16:59:15 +01:00
Stepan 5741150367 Enable MultiVersion video tests and added support for naming based on tests 11 & 8 2020-11-05 14:51:27 +01:00
Stepan c060ed1a18 Added resolving of alternative files and extras for audibooks. 2020-11-03 16:24:04 +01:00
Stepan 1e71775688 Add Name and Year parsing for audiobooks 2020-11-02 20:03:12 +01:00
Stepan f39775dc3a Written test to finish coverage for AudioBookListResolver & AudioBookResolver and corrected some logical erros / unhandled exception 2020-11-01 17:10:48 +01:00
Stepan e7a37bedfc Simplify AudioBookResolver since there is no option of passing directories into it (AudioResolver.cs:179) and handling directories were not implemented anyway 2020-11-01 13:42:56 +01:00
Stepan 6437cf6950 Removed Success property from AudioBookFilePathParserResult, since it was unused and consider only audiobooks that have chapter/page number in name makes no sense 2020-11-01 13:28:43 +01:00
Stepan 60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan 59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
Bond_009 74f4affcda Fix AudioBookListResolver test coverage 2020-10-12 20:09:15 +02:00
Bond_009 228b33a23b Minor improvements 2020-09-20 14:02:41 +02:00
Keridos b9c7cce696
some testing for AudioBook
fix PartNumber detection
2020-09-09 02:24:17 +02:00
Bond-009 6d154041b9
Merge pull request #3880 from DirtyRacer1337/datetime
Fix year parsing
2020-09-05 16:09:05 +02:00
Erwin de Haan 346581bb2a Fixes for CI Nuget package pushing and CI triggers
Also adds SourceLink support and symbols that are pushed to Nuget.
Add symbols to main nuget packages for unstable builds (Azure Artifacts does not support symbols outside of the main package)
SourceLink will enable stepping during debugging.
2020-09-02 22:42:00 +02:00
crobibero b02650ec2f use proper spdx 2020-08-26 07:39:01 -06:00
crobibero 5f60da29c7 switch to spdx 2020-08-26 07:36:57 -06:00
crobibero 670c41ee89 Properly pack project license 2020-08-25 21:33:19 -06:00
David b92fbe4d69 Use VersionPrefix 2020-08-13 19:03:24 +02:00
David a61f6e3308 Fix nuget ci 2020-08-13 15:22:12 +02:00
DirtyRacer1337 f5d90949cf Replace \d to [0-9] 2020-08-12 22:02:19 +07:00
DirtyRacer1337 1259fe2d50 Add date filter 2020-08-12 09:08:09 +07:00
DirtyRacer1337 c2f901acfe Fix year parsing 2020-08-12 07:56:01 +07:00
Bond-009 3ff110984a
Merge branch 'master' into readonlyspan 2020-07-24 09:40:44 +02:00
Bond_009 febb6bced6 Review usage of string.Substring (part 1)
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bond_009 e98351b912 Replace \d with [0-9] in ffmpeg detection and scan code 2020-07-20 14:14:15 +02:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
Bond-009 f0d182b8fe
Merge pull request #3046 from puschie286/add-clean-name-tag
allow bd tag in file names
2020-06-03 15:50:32 +02:00
Vasily ce16651dbd Fix a check broken by https://github.com/jellyfin/jellyfin/pull/2105 2020-05-15 01:55:53 +03:00
Anthony Lavado 0e11646107
Merge pull request #2950 from Bond-009/videoresolver
Fix VideoResolver and tests
2020-05-04 04:21:30 -04:00
Christoph Potas 7d3eaea3fa + add bd tag to clean string regex
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
2020-05-03 18:17:55 +02:00
Vasily aff65adca9
Merge pull request #2917 from Bond-009/tests
Improved tests
2020-04-29 12:17:39 +03:00
Bond_009 a273ed9a57 Address comments 2020-04-25 15:29:59 +02:00
Bond-009 c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
Remove requirement to build web during server builds
2020-04-22 00:17:44 +02:00
Mark Monteiro c5f163293f Add <ProjectGuid> properties to all project files
This is required for SonarCloud analysis to run
2020-04-21 16:21:09 -04:00
Bond_009 735e7c3f7d Fix VideoResolver and tests 2020-04-21 12:11:55 +02:00
Bond_009 fc3e2baccc Address comments 2020-04-19 18:27:07 +02:00
Bond_009 d99536e99f Improved tests 2020-04-19 11:57:03 +02:00
Delgan be6cc9644f Another iteration 2020-04-13 16:11:02 +02:00
Delgan 90d289f946 Fix failing tests? 2020-04-13 15:55:18 +02:00
Delgan 5c117734a5 Improve movie resolver if space precedes the year 2020-04-13 14:50:35 +02:00
Mark Monteiro 7be4b57fe7 Fix documentation for ExtraRuleType enum values 2020-04-05 09:47:55 -04:00
Mark Monteiro 1a4d9d4c53 Code review suggestions 2020-04-01 19:41:52 +02:00
Mark Monteiro 377f9896ce Small fixes 2020-04-01 19:04:00 +02:00
Mark Monteiro 4ff8d30e41 Document ExtraRule properly 2020-04-01 18:54:06 +02:00
Mark Monteiro 2e1ec2858a Match using directory names in ExtraResolver 2020-04-01 18:53:19 +02:00
Cody Robibero ea49514723
Update Emby.Naming/Subtitles/SubtitleParser.cs
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-03-26 09:31:23 -06:00
crobibero bd5c66b2a6 implement suggestions 2020-03-25 18:29:47 -06:00
crobibero 18906d0205 implement suggestions 2020-03-25 14:33:44 -06:00
crobibero 261a2e1989 revert xml docs indentation 2020-03-25 14:31:03 -06:00
crobibero cb68fbeb0a Fix warnings in Emby.Naming 2020-03-25 10:53:03 -06:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
dkanada 6715450598
Merge pull request #2427 from Bond-009/minor
Minor improvements
2020-02-23 10:48:47 +09:00
Bond_009 adc9fc282c Minor improvements 2020-02-19 23:08:58 +01:00
Bond_009 620047ab9a Fix episode parsing 2020-02-19 22:35:40 +01:00
Bond_009 dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
Vasily f23434f4f7
Merge pull request #2299 from dkanada/testing
Fix a few more tests for music and episodes
2020-01-21 13:21:24 +03:00
dkanada e700fc8a07 fix and remove a few more tests 2020-01-19 00:18:55 +09:00
Bond_009 9f5bbb126e Fix tests 2020-01-11 22:29:46 +01:00
Bond_009 abf03f7d3a Clean up some more 2020-01-11 22:17:05 +01:00
Bond_009 ec0ef2a2c5 Remove useless statement 2020-01-11 22:17:05 +01:00
Bond_009 cd0592ea8f Improve parsers 2020-01-11 22:17:05 +01:00
Bond_009 dd254eddac Simplify CleanDateTimeParser 2020-01-11 22:17:05 +01:00
Bond_009 b1dc595be1 Fix a couple of tests 2020-01-11 22:17:05 +01:00
Bond_009 a647dc5705 Cleanup tests 2020-01-11 22:17:05 +01:00
Bond_009 801c356d66 Fix regex for movies released after 2019 2020-01-11 00:23:14 +01:00
Vasily dd7feacd34
Merge pull request #2105 from Bond-009/namingtests
Add back all old emby tests
2020-01-11 02:11:13 +03:00
Bond_009 bb236b9591 Merge branch 'master' into warn12 2020-01-10 21:18:16 +01:00
Bond_009 b50c4938e1 Merge branch 'master' into namingtests 2020-01-09 18:26:22 +01:00
Bond_009 742d84e53f Enable analyzers for Emby.Naming 2019-12-17 17:41:12 +01:00
Bond-009 6b185119aa
Merge branch 'master' into namingtests 2019-12-17 17:35:27 +01:00
Bond_009 5a8e972952 Enable TreatWarningsAsErrors for some projects
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
2019-12-13 20:11:37 +01:00
Bond_009 2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
Bond_009 35151553e3 Add back all old emby tests 2019-12-06 20:41:39 +01:00
Claus Vium 8befab5b5d Simplify regex to avoid catastrophic backtracking 2019-12-06 20:21:18 +01:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond_009 3cf9313c86 Update deps 2019-11-21 17:08:06 +01:00
Bond_009 dd749dde5f Add comment 2019-11-09 20:26:56 +01:00
Bond_009 a2df6e0e36 Fix naming tests 2019-11-08 19:59:48 +01:00
dkanada 61b9b4046a
Merge pull request #1929 from Narfinger/parser-fix4
[Draft][Help wanted] Fix parsing of certain names and adds a default season if no season was found
2019-11-08 02:14:01 +09:00
Narfinger 9cd62d661f removed restriction to 3 digits in episodenumber and 4 in season numbers 2019-11-07 10:50:02 +09:00
Bond_009 3f7836d9eb Update deps and add MultiThreading analyzer 2019-11-01 17:55:44 +01:00
Narfinger 4a20260a27 add another parser case and allow parsing of seasonless
Add another parser case and we now allow parsing of seasonless series which hopefully should cover more cases of directory structure
2019-10-22 15:46:35 +09:00
Bond_009 516933aab5 Move to netcore3.0 2019-10-11 18:32:13 +02:00
Bond_009 003238ef5e Update deps + document startup project
* Fixed the release build
* Documented all public/internal members of Jellyfin.Server
* Enable TreatWarningsAsErrors for debug builds for Jellyfin.Server

This will ensure that any new public/internal members of Jellyfin.Server
are documented
2019-08-11 15:11:53 +02:00
Bond_009 5554595255 Update deps 2019-06-14 18:49:57 +02:00
Bond_009 08ac5b6ec3 Fix build 2019-06-01 11:34:28 +02:00
Bond-009 a6f9ceedd8 Fix more warnings 2019-06-01 11:31:27 +02:00
Bond_009 f2e2065fd4 Remove unused dependency for Emby.Naming 2019-03-31 15:25:30 +02:00
Erwin de Haan 21cc38fcf4 Adjusted AssemblyCopyright attribute values. 2019-03-14 22:17:56 +01:00
Erwin de Haan ee7bf86e0f Adjusted the Product Name so the User Agent is correct/better. 2019-03-14 22:11:47 +01:00
Bond-009 9993dafe54 Don't mix LINQ and roreach loops for readability 2019-03-01 17:12:22 +01:00
Claus Vium 6016a27736 Check for whitespace 2019-02-19 22:30:21 +01:00
Claus Vium 566646ad8b Remove limit comment 2019-02-19 19:44:22 +01:00
Claus Vium 6c1ca6f737 Remove arbitrary limit and minor style fixes 2019-02-19 19:33:41 +01:00
Claus Vium aa0c20afd5 Revert "Change multi version logic for movies"
This reverts commit a4055779f6.
2019-02-19 17:39:47 +01:00
Claus Vium 46acff4113 Revert "Remove unnecessary ToList"
This reverts commit 42abb5a993.
2019-02-19 17:39:30 +01:00
Claus Vium de5c0bab70 Revert "Add Year to the new VideoInfo"
This reverts commit 05ad2e9b3f.
2019-02-19 17:39:10 +01:00
Claus Vium 5181427234 Revert "Merge pull request #924 from cvium/fix_movie_matching"
This reverts commit f274d024ce, reversing
changes made to 4b4399fba6.
2019-02-19 17:34:43 +01:00
Claus Vium c79324154f Revert "Merge pull request #933 from cvium/fix_movie_matching_again"
This reverts commit 77d4fec6eb, reversing
changes made to f274d024ce.
2019-02-19 17:10:11 +01:00
Claus Vium 29ff80d69c Minor style fixes 2019-02-18 22:02:16 +01:00
Claus Vium 4a700778e3 Semi-revert to prefer old movie grouping behaviour 2019-02-18 21:56:08 +01:00