Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond-009
f369ddf522
Merge pull request #7039 from 1337joe/providermanager-cleanup
2022-11-23 18:24:07 +01:00
Shadowghost
072651c4be
Add xmldocs for TMDb provider, correct provider spelling
2022-11-17 11:16:20 +01:00
Claus Vium
81b04ddbb5
Merge branch 'master' into providermanager-cleanup
2022-10-07 09:57:16 +02:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Bond-009
6702756e7b
Merge pull request #7873 from cvium/fix_nfo_remoteimages
...
(cherry picked from commit 1a787e273a
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Bond-009
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero
97bf6c7364
Merge pull request #7521 from 1337joe/image-mime-fallback
...
Add fallback for image downloads with bad reported MediaType
(cherry picked from commit bf1ccf7493
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Joe Rogers
b03f56c3d6
Remove warnings
2022-04-03 23:36:32 +02:00
Joe Rogers
6e4710d048
Fix review comment
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-04-03 23:36:32 +02:00
Joe Rogers
ac675318f8
Simplify RefreshSingleItem
2022-04-03 23:36:32 +02:00
Joe Rogers
bdce435b09
Reorder and flatten provider filtering
2022-04-03 23:36:30 +02:00
Joe Rogers
a7c009e2eb
Pass TypeOptions instead of full LibraryOptions
2022-04-03 23:34:49 +02:00
Joe Rogers
e7df72de49
Improve metadata provider sorting
...
Extract configured order up front instead of for each provider
Non-IHasOrder providers default to middle, not beginning
Merge image and metadata sort helper methods
2022-04-03 23:34:49 +02:00
Joe Rogers
11c7c24f0e
Clarify naming, minor method ordering improvement
2022-04-03 23:34:49 +02:00
Joe Rogers
6221991c63
Add nullable annotations
2022-04-03 23:34:48 +02:00
Joe Rogers
8515e8fbd1
Improve image provider sorting
...
Remove irrelevant check for ILocalImageProvider
Providers that are not IHasOrder default to middle, not beginning
2022-04-03 23:34:48 +02:00
Joe Rogers
4ace7f5c53
Fix unused var, log typo
2022-04-03 23:34:47 +02:00
Joe Rogers
2e2a594e19
Move Get*Providers definitions to interface
2022-04-03 23:34:47 +02:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
b6489e73ab
Merge pull request #7241 from Bond-009/async5
2022-02-06 15:25:48 -07:00
Claus Vium
488ce51032
Remove some allocations ( #7246 )
2022-01-28 12:21:40 +01:00
Bond_009
e7be01d7a5
Flush to disk async where possible
2022-01-22 23:36:42 +01:00
Bond-009
ef0708d876
Merge pull request #7078 from 1337joe/metadata-merge-data
2022-01-16 23:17:40 +01:00
Joe Rogers
f87e780fb5
Address review comments
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-01-16 13:21:24 +01:00
Joe Rogers
b43f46d5c9
Make identify flag describe purpose, not source
2022-01-08 14:03:59 +01:00
Joe Rogers
b17fe35e2e
Clean up list handling
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-01-04 16:25:36 +01:00
Bond_009
dc222b75c5
Remove incorrect mime type image/jpg
2022-01-04 10:40:16 +01:00
Joe Rogers
1dfbeae045
Embed ProviderUtils into MetadataService
2022-01-04 00:44:03 +01:00
Joe Rogers
19164378f2
Clean up warnings
2022-01-04 00:21:45 +01:00
Joe Rogers
c81d2e9dec
Remove existing images when applying identify
2022-01-03 23:41:13 +01:00
Joe Rogers
ce66df2c92
Clean up warnings, simplify
2022-01-03 22:59:58 +01:00
Joe Rogers
853ef727da
Add refresh flag to remove existing data/images
...
Fixes #7040
2022-01-02 22:21:05 +01:00
Joe Rogers
76e640b0b9
Add tests and documentation for ProviderUtils
2021-12-31 00:10:35 +01:00
Joe Rogers
e3a7c9238d
Pull default MergeData implementation to parent
2021-12-28 15:12:09 +01:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
2021-12-24 01:59:25 +00:00
cvium
c86b064f80
Catch HttpRequestException when saving images from local provider
2021-12-21 12:29:09 +01:00
cvium
b880dc8a4a
Use our own Contains extension
2021-12-20 13:31:07 +01:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Cody Robibero
14c072dd32
Fix filtering images without dimensions
2021-11-12 07:21:46 -07:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
2021-11-06 20:43:20 +01:00
Bond_009
924c6682b9
Remove unused IHasScreenshots interface
2021-11-04 01:06:21 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test
2021-11-02 16:16:06 +01:00
Joe Rogers
7da6bd905a
Fix edge case in multi-image replacing
2021-11-02 00:31:59 +01:00
Joe Rogers
b478b115e3
Refactor to validate all images up front
2021-11-01 11:53:31 +01:00
Joe Rogers
0fbd8d85c8
Validate multi-images, lazy-delete bg on refresh
...
Fix failing test: Invalid background images not purged by validate
Fixes #6310 : Background images only delete when using "Replace existing images" when new image(s) is found to replace them
2021-11-01 00:16:11 +01:00
Joe Rogers
080b02cc4c
Add comments, minor cleanup, add tests
2021-10-31 23:56:50 +01:00