Fix code issues

This commit is contained in:
gion 2020-05-15 18:47:16 +02:00
parent 5c8cbd4087
commit e8f45248aa

View File

@ -175,8 +175,7 @@ namespace MediaBrowser.Api.SyncPlay
Guid groupId; Guid groupId;
Guid playingItemId = Guid.Empty; Guid playingItemId = Guid.Empty;
var valid = Guid.TryParse(request.GroupId, out groupId); if (!Guid.TryParse(request.GroupId, out groupId))
if (!valid)
{ {
Logger.LogError("JoinGroup: {0} is not a valid format for GroupId. Ignoring request.", request.GroupId); Logger.LogError("JoinGroup: {0} is not a valid format for GroupId. Ignoring request.", request.GroupId);
return; return;
@ -185,8 +184,7 @@ namespace MediaBrowser.Api.SyncPlay
// Both null and empty strings mean that client isn't playing anything // Both null and empty strings mean that client isn't playing anything
if (!String.IsNullOrEmpty(request.PlayingItemId)) if (!String.IsNullOrEmpty(request.PlayingItemId))
{ {
valid = Guid.TryParse(request.PlayingItemId, out playingItemId); if (!Guid.TryParse(request.PlayingItemId, out playingItemId))
if (!valid)
{ {
Logger.LogError("JoinGroup: {0} is not a valid format for PlayingItemId. Ignoring request.", request.PlayingItemId); Logger.LogError("JoinGroup: {0} is not a valid format for PlayingItemId. Ignoring request.", request.PlayingItemId);
return; return;
@ -224,8 +222,7 @@ namespace MediaBrowser.Api.SyncPlay
if (!String.IsNullOrEmpty(request.FilterItemId)) if (!String.IsNullOrEmpty(request.FilterItemId))
{ {
var valid = Guid.TryParse(request.FilterItemId, out filterItemId); if (!Guid.TryParse(request.FilterItemId, out filterItemId))
if (!valid)
{ {
Logger.LogWarning("ListGroups: {0} is not a valid format for FilterItemId. Ignoring filter.", request.FilterItemId); Logger.LogWarning("ListGroups: {0} is not a valid format for FilterItemId. Ignoring filter.", request.FilterItemId);
} }