pt
/
jellyfin
mirror of https://github.com/jellyfin/jellyfin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SubtitleEncoder: stop using tuples for clarity 

* Replace Tuples with a ValueTuple or a struct
This commit is contained in:
Bond_009 2019-01-06 20:59:13 +01:00
parent e9b44a3d6e
commit 73fd0cd8c6
1 changed files with 97 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

171
MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs
View File

@ -1,26 +1,25 @@
using MediaBrowser.Common.Configuration; using System;
using MediaBrowser.Common.Extensions;
using MediaBrowser.Common.Net;
using MediaBrowser.Controller.Entities;
using MediaBrowser.Controller.Library;
using MediaBrowser.Controller.MediaEncoding;
using MediaBrowser.Model.Entities;
using Microsoft.Extensions.Logging;
using MediaBrowser.Model.MediaInfo;
using MediaBrowser.Model.Serialization;
using System;
using System.Collections.Concurrent; using System.Collections.Concurrent;
using System.Diagnostics;
using System.Globalization; using System.Globalization;
using System.IO; using System.IO;
using System.Linq; using System.Linq;
using System.Text; using System.Text;
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using MediaBrowser.Common.Configuration;
using MediaBrowser.Common.Extensions;
using MediaBrowser.Common.Net;
using MediaBrowser.Controller.Entities;
using MediaBrowser.Controller.Library;
using MediaBrowser.Controller.MediaEncoding;
using MediaBrowser.Model.IO; using MediaBrowser.Model.IO;
using MediaBrowser.Model.Diagnostics; using MediaBrowser.Model.Diagnostics;
using MediaBrowser.Model.Dto; using MediaBrowser.Model.Dto;
using MediaBrowser.Model.Entities;
using MediaBrowser.Model.MediaInfo;
using MediaBrowser.Model.Serialization;
using MediaBrowser.Model.Text; using MediaBrowser.Model.Text;
using Microsoft.Extensions.Logging;
namespace MediaBrowser.MediaEncoding.Subtitles namespace MediaBrowser.MediaEncoding.Subtitles
{ {
@ -110,7 +109,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
if (endTimeTicks.HasValue) if (endTimeTicks.HasValue)
{ {
var endTime = endTimeTicks.Value; long endTime = endTimeTicks.Value;
track.TrackEvents = track.TrackEvents track.TrackEvents = track.TrackEvents
.TakeWhile(i => i.StartPositionTicks <= endTime) .TakeWhile(i => i.StartPositionTicks <= endTime)
@ -150,48 +149,51 @@ namespace MediaBrowser.MediaEncoding.Subtitles
var subtitle = await GetSubtitleStream(mediaSource, subtitleStream, cancellationToken) var subtitle = await GetSubtitleStream(mediaSource, subtitleStream, cancellationToken)
.ConfigureAwait(false); .ConfigureAwait(false);
var inputFormat = subtitle.Item2; var inputFormat = subtitle.format;
var writer = TryGetWriter(outputFormat); var writer = TryGetWriter(outputFormat);
// Return the original if we don't have any way of converting it // Return the original if we don't have any way of converting it
if (writer == null) if (writer == null)
{ {
return subtitle.Item1; return subtitle.stream;
} }
// Return the original if the same format is being requested // Return the original if the same format is being requested
// Character encoding was already handled in GetSubtitleStream // Character encoding was already handled in GetSubtitleStream
if (string.Equals(inputFormat, outputFormat, StringComparison.OrdinalIgnoreCase)) if (string.Equals(inputFormat, outputFormat, StringComparison.OrdinalIgnoreCase))
{ {
return subtitle.Item1; return subtitle.stream;
} }
using (var stream = subtitle.Item1) using (var stream = subtitle.stream)
{ {
return ConvertSubtitles(stream, inputFormat, outputFormat, startTimeTicks, endTimeTicks, preserveOriginalTimestamps, cancellationToken); return ConvertSubtitles(stream, inputFormat, outputFormat, startTimeTicks, endTimeTicks, preserveOriginalTimestamps, cancellationToken);
} }
} }
private async Task<Tuple<Stream, string>> GetSubtitleStream(MediaSourceInfo mediaSource, private async Task<(Stream stream, string format)> GetSubtitleStream(
MediaSourceInfo mediaSource,
MediaStream subtitleStream, MediaStream subtitleStream,
CancellationToken cancellationToken) CancellationToken cancellationToken)
{ {
var inputFiles = new[] { mediaSource.Path }; string[] inputFiles;
if (mediaSource.VideoType.HasValue) if (mediaSource.VideoType.HasValue
&& (mediaSource.VideoType.Value == VideoType.BluRay || mediaSource.VideoType.Value == VideoType.Dvd))
{ {
if (mediaSource.VideoType.Value == VideoType.BluRay || mediaSource.VideoType.Value == VideoType.Dvd) var mediaSourceItem = (Video)_libraryManager.GetItemById(new Guid(mediaSource.Id));
{ inputFiles = mediaSourceItem.GetPlayableStreamFileNames(_mediaEncoder);
var mediaSourceItem = (Video)_libraryManager.GetItemById(new Guid(mediaSource.Id)); }
inputFiles = mediaSourceItem.GetPlayableStreamFileNames(_mediaEncoder).ToArray(); else
} {
inputFiles = new[] { mediaSource.Path };
} }
var fileInfo = await GetReadableFile(mediaSource.Path, inputFiles, mediaSource.Protocol, subtitleStream, cancellationToken).ConfigureAwait(false); var fileInfo = await GetReadableFile(mediaSource.Path, inputFiles, mediaSource.Protocol, subtitleStream, cancellationToken).ConfigureAwait(false);
var stream = await GetSubtitleStream(fileInfo.Item1, subtitleStream.Language, fileInfo.Item2, fileInfo.Item4, cancellationToken).ConfigureAwait(false); var stream = await GetSubtitleStream(fileInfo.Path, subtitleStream.Language, fileInfo.Protocol, fileInfo.IsExternal, cancellationToken).ConfigureAwait(false);
return new Tuple<Stream, string>(stream, fileInfo.Item3); return (stream, fileInfo.Format);
} }
private async Task<Stream> GetSubtitleStream(string path, string language, MediaProtocol protocol, bool requiresCharset, CancellationToken cancellationToken) private async Task<Stream> GetSubtitleStream(string path, string language, MediaProtocol protocol, bool requiresCharset, CancellationToken cancellationToken)
@ -206,15 +208,13 @@ namespace MediaBrowser.MediaEncoding.Subtitles
if (!string.IsNullOrEmpty(charset)) if (!string.IsNullOrEmpty(charset))
{ {
using (var inputStream = new MemoryStream(bytes)) using (var inputStream = new MemoryStream(bytes))
using (var reader = new StreamReader(inputStream, _textEncoding.GetEncodingFromCharset(charset)))
{ {
using (var reader = new StreamReader(inputStream, _textEncoding.GetEncodingFromCharset(charset))) var text = await reader.ReadToEndAsync().ConfigureAwait(false);
{
var text = await reader.ReadToEndAsync().ConfigureAwait(false);
bytes = Encoding.UTF8.GetBytes(text); bytes = Encoding.UTF8.GetBytes(text);
return new MemoryStream(bytes); return new MemoryStream(bytes);
}
} }
} }
} }
@ -222,7 +222,8 @@ namespace MediaBrowser.MediaEncoding.Subtitles
return _fileSystem.OpenRead(path); return _fileSystem.OpenRead(path);
} }
private async Task<Tuple<string, MediaProtocol, string, bool>> GetReadableFile(string mediaPath, private async Task<SubtitleInfo> GetReadableFile(
string mediaPath,
string[] inputFiles, string[] inputFiles,
MediaProtocol protocol, MediaProtocol protocol,
MediaStream subtitleStream, MediaStream subtitleStream,
@ -237,30 +238,30 @@ namespace MediaBrowser.MediaEncoding.Subtitles
string.Equals(subtitleStream.Codec, "ssa", StringComparison.OrdinalIgnoreCase) || string.Equals(subtitleStream.Codec, "ssa", StringComparison.OrdinalIgnoreCase) ||
string.Equals(subtitleStream.Codec, "srt", StringComparison.OrdinalIgnoreCase)) string.Equals(subtitleStream.Codec, "srt", StringComparison.OrdinalIgnoreCase))
{ {
// Extract // Extract
outputCodec = "copy"; outputCodec = "copy";
outputFormat = subtitleStream.Codec; outputFormat = subtitleStream.Codec;
} }
else if (string.Equals(subtitleStream.Codec, "subrip", StringComparison.OrdinalIgnoreCase)) else if (string.Equals(subtitleStream.Codec, "subrip", StringComparison.OrdinalIgnoreCase))
{ {
// Extract // Extract
outputCodec = "copy"; outputCodec = "copy";
outputFormat = "srt"; outputFormat = "srt";
} }
else else
{ {
// Extract // Extract
outputCodec = "srt"; outputCodec = "srt";
outputFormat = "srt"; outputFormat = "srt";
} }
// Extract // Extract
var outputPath = GetSubtitleCachePath(mediaPath, protocol, subtitleStream.Index, "." + outputFormat); var outputPath = GetSubtitleCachePath(mediaPath, protocol, subtitleStream.Index, "." + outputFormat);
await ExtractTextSubtitle(inputFiles, protocol, subtitleStream.Index, outputCodec, outputPath, cancellationToken) await ExtractTextSubtitle(inputFiles, protocol, subtitleStream.Index, outputCodec, outputPath, cancellationToken)
.ConfigureAwait(false); .ConfigureAwait(false);
return new Tuple<string, MediaProtocol, string, bool>(outputPath, MediaProtocol.File, outputFormat, false); return new SubtitleInfo(outputPath, MediaProtocol.File, outputFormat, false);
} }
var currentFormat = (Path.GetExtension(subtitleStream.Path) ?? subtitleStream.Codec) var currentFormat = (Path.GetExtension(subtitleStream.Path) ?? subtitleStream.Codec)
@ -268,15 +269,31 @@ namespace MediaBrowser.MediaEncoding.Subtitles
if (GetReader(currentFormat, false) == null) if (GetReader(currentFormat, false) == null)
{ {
// Convert // Convert
var outputPath = GetSubtitleCachePath(mediaPath, protocol, subtitleStream.Index, ".srt"); var outputPath = GetSubtitleCachePath(mediaPath, protocol, subtitleStream.Index, ".srt");
await ConvertTextSubtitleToSrt(subtitleStream.Path, subtitleStream.Language, protocol, outputPath, cancellationToken).ConfigureAwait(false); await ConvertTextSubtitleToSrt(subtitleStream.Path, subtitleStream.Language, protocol, outputPath, cancellationToken).ConfigureAwait(false);
return new Tuple<string, MediaProtocol, string, bool>(outputPath, MediaProtocol.File, "srt", true); return new SubtitleInfo(outputPath, MediaProtocol.File, "srt", true);
} }
return new Tuple<string, MediaProtocol, string, bool>(subtitleStream.Path, protocol, currentFormat, true); return new SubtitleInfo(subtitleStream.Path, protocol, currentFormat, true);
}
private struct SubtitleInfo
{
public SubtitleInfo(string path, MediaProtocol protocol, string format, bool isExternal)
{
Path = path;
Protocol = protocol;
Format = format;
IsExternal = isExternal;
}
public string Path { get; set; }
public MediaProtocol Protocol { get; set; }
public string Format { get; set; }
public bool IsExternal { get; set; }
} }
private ISubtitleParser GetReader(string format, bool throwIfMissing) private ISubtitleParser GetReader(string format, bool throwIfMissing)
@ -482,7 +499,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
} }
catch (IOException ex) catch (IOException ex)
{ {
_logger.LogError(ex, "Error deleting converted subtitle {0}", outputPath); _logger.LogError(ex, "Error deleting converted subtitle {Path}", outputPath);
} }
} }
} }
@ -493,7 +510,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
if (failed) if (failed)
{ {
var msg = string.Format("ffmpeg subtitle conversion failed for {0}", inputPath); var msg = string.Format("ffmpeg subtitle conversion failed for {Path}", inputPath);
_logger.LogError(msg); _logger.LogError(msg);
@ -501,7 +518,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
} }
await SetAssFont(outputPath).ConfigureAwait(false); await SetAssFont(outputPath).ConfigureAwait(false);
_logger.LogInformation("ffmpeg subtitle conversion succeeded for {0}", inputPath); _logger.LogInformation("ffmpeg subtitle conversion succeeded for {Path}", inputPath);
} }
/// <summary> /// <summary>
@ -515,8 +532,13 @@ namespace MediaBrowser.MediaEncoding.Subtitles
/// <param name="cancellationToken">The cancellation token.</param> /// <param name="cancellationToken">The cancellation token.</param>
/// <returns>Task.</returns> /// <returns>Task.</returns>
/// <exception cref="System.ArgumentException">Must use inputPath list overload</exception> /// <exception cref="System.ArgumentException">Must use inputPath list overload</exception>
private async Task ExtractTextSubtitle(string[] inputFiles, MediaProtocol protocol, int subtitleStreamIndex, private async Task ExtractTextSubtitle(
string outputCodec, string outputPath, CancellationToken cancellationToken) string[] inputFiles,
MediaProtocol protocol,
int subtitleStreamIndex,
string outputCodec,
string outputPath,
CancellationToken cancellationToken)
{ {
var semaphore = GetLock(outputPath); var semaphore = GetLock(outputPath);
@ -535,8 +557,12 @@ namespace MediaBrowser.MediaEncoding.Subtitles
} }
} }
private async Task ExtractTextSubtitleInternal(string inputPath, int subtitleStreamIndex, private async Task ExtractTextSubtitleInternal(
string outputCodec, string outputPath, CancellationToken cancellationToken) string inputPath,
int subtitleStreamIndex,
string outputCodec,
string outputPath,
CancellationToken cancellationToken)
{ {
if (string.IsNullOrEmpty(inputPath)) if (string.IsNullOrEmpty(inputPath))
{ {
@ -564,7 +590,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
ErrorDialog = false ErrorDialog = false
}); });
_logger.LogInformation("{0} {1}", process.StartInfo.FileName, process.StartInfo.Arguments); _logger.LogInformation("{File} {Arguments}", process.StartInfo.FileName, process.StartInfo.Arguments);
try try
{ {
@ -583,7 +609,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
{ {
try try
{ {
_logger.LogInformation("Killing ffmpeg subtitle extraction process"); _logger.LogWarning("Killing ffmpeg subtitle extraction process");
process.Kill(); process.Kill();
} }
@ -605,7 +631,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
try try
{ {
_logger.LogInformation("Deleting extracted subtitle due to failure: {0}", outputPath); _logger.LogWarning("Deleting extracted subtitle due to failure: {Path}", outputPath);
_fileSystem.DeleteFile(outputPath); _fileSystem.DeleteFile(outputPath);
} }
catch (FileNotFoundException) catch (FileNotFoundException)
@ -614,7 +640,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
} }
catch (IOException ex) catch (IOException ex)
{ {
_logger.LogError(ex, "Error deleting extracted subtitle {0}", outputPath); _logger.LogError(ex, "Error deleting extracted subtitle {Path}", outputPath);
} }
} }
else if (!_fileSystem.FileExists(outputPath)) else if (!_fileSystem.FileExists(outputPath))
@ -624,7 +650,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
if (failed) if (failed)
{ {
var msg = string.Format("ffmpeg subtitle extraction failed for {0} to {1}", inputPath, outputPath); var msg = $"ffmpeg subtitle extraction failed for {inputPath} to {outputPath}";
_logger.LogError(msg); _logger.LogError(msg);
@ -632,7 +658,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
} }
else else
{ {
var msg = string.Format("ffmpeg subtitle extraction completed for {0} to {1}", inputPath, outputPath); var msg = $"ffmpeg subtitle extraction completed for {inputPath} to {outputPath}";
_logger.LogInformation(msg); _logger.LogInformation(msg);
} }
@ -650,19 +676,17 @@ namespace MediaBrowser.MediaEncoding.Subtitles
/// <returns>Task.</returns> /// <returns>Task.</returns>
private async Task SetAssFont(string file) private async Task SetAssFont(string file)
{ {
_logger.LogInformation("Setting ass font within {0}", file); _logger.LogInformation("Setting ass font within {File}", file);
string text; string text;
Encoding encoding; Encoding encoding;
using (var fileStream = _fileSystem.OpenRead(file)) using (var fileStream = _fileSystem.OpenRead(file))
using (var reader = new StreamReader(fileStream, true))
{ {
using (var reader = new StreamReader(fileStream, true)) encoding = reader.CurrentEncoding;
{
encoding = reader.CurrentEncoding;
text = await reader.ReadToEndAsync().ConfigureAwait(false); text = await reader.ReadToEndAsync().ConfigureAwait(false);
}
} }
var newText = text.Replace(",Arial,", ",Arial Unicode MS,"); var newText = text.Replace(",Arial,", ",Arial Unicode MS,");
@ -707,7 +731,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
var charset = _textEncoding.GetDetectedEncodingName(bytes, bytes.Length, language, true); var charset = _textEncoding.GetDetectedEncodingName(bytes, bytes.Length, language, true);
_logger.LogDebug("charset {0} detected for {1}", charset ?? "null", path); _logger.LogDebug("charset {0} detected for {Path}", charset ?? "null", path);
return charset; return charset;
} }
@ -716,18 +740,18 @@ namespace MediaBrowser.MediaEncoding.Subtitles
{ {
if (protocol == MediaProtocol.Http) if (protocol == MediaProtocol.Http)
{ {
HttpRequestOptions opts = new HttpRequestOptions(); HttpRequestOptions opts = new HttpRequestOptions()
opts.Url = path;
opts.CancellationToken = cancellationToken;
using (var file = await _httpClient.Get(opts).ConfigureAwait(false))
{ {
using (var memoryStream = new MemoryStream()) Url = path,
{ CancellationToken = cancellationToken
await file.CopyToAsync(memoryStream).ConfigureAwait(false); };
memoryStream.Position = 0; using (var file = await _httpClient.Get(opts).ConfigureAwait(false))
using (var memoryStream = new MemoryStream())
{
await file.CopyToAsync(memoryStream).ConfigureAwait(false);
memoryStream.Position = 0;
return memoryStream.ToArray(); return memoryStream.ToArray();
}
} }
} }
if (protocol == MediaProtocol.File) if (protocol == MediaProtocol.File)
@ -737,6 +761,5 @@ namespace MediaBrowser.MediaEncoding.Subtitles
throw new ArgumentOutOfRangeException("protocol"); throw new ArgumentOutOfRangeException("protocol");
} }
} }
} }