pt
/
jellyfin
mirror of https://github.com/jellyfin/jellyfin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

alter column type of OwnerId and add indexes

This commit is contained in:
TheMelmacian 2023-06-11 21:58:09 +02:00
parent 014a1afd86
commit 12bfeb3e73
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Emby.Server.Implementations/Data/BaseSqliteRepository.cs
View File

@ -174,6 +174,21 @@ namespace Emby.Server.Implementations.Data
return columnNames;
}
protected Dictionary<string, string> GetColumnTypes(SqliteConnection connection, string table)
{
var columnTypes = new Dictionary<string, string>();
foreach (var row in connection.Query("PRAGMA table_info(" + table + ")"))
{
if (row.TryGetString(1, out var columnName) && row.TryGetString(2, out var columnType))
{
columnTypes[columnName] = columnType;
}
}
return columnTypes;
}
protected void AddColumn(SqliteConnection connection, string table, string columnName, string type, List<string> existingColumnNames)
{
if (existingColumnNames.Contains(columnName, StringComparison.OrdinalIgnoreCase))

18
Emby.Server.Implementations/Data/SqliteItemRepository.cs
View File

@ -423,6 +423,10 @@ namespace Emby.Server.Implementations.Data
// resume
"create index if not exists idx_TypeTopParentId7 on TypedBaseItems(TopParentId,MediaType,IsVirtualItem,PresentationUniqueKey)",
// used to effectively link items when building item tree
"create index if not exists idx_TypedBaseItemsOwnerId on TypedBaseItems(OwnerId)",
"create index if not exists idx_TypedBaseItemsPrimaryVersionId on TypedBaseItems(PrimaryVersionId)",
// items by name
"create index if not exists idx_ItemValues6 on ItemValues(ItemId,Type,CleanValue)",
"create index if not exists idx_ItemValues7 on ItemValues(Type,CleanValue,ItemId)",
@ -512,11 +516,23 @@ namespace Emby.Server.Implementations.Data
AddColumn(connection, "TypedBaseItems", "ExternalId", "Text", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "SeriesPresentationUniqueKey", "Text", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "ShowId", "Text", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "OwnerId", "Text", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "OwnerId", "GUID", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "Width", "INT", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "Height", "INT", existingColumnNames);
AddColumn(connection, "TypedBaseItems", "Size", "BIGINT", existingColumnNames);
// change type of OwnerId from TEXT to GUID so database can use index when compared to guid column
// sadly sqlite doesn't support to change column types directly (see: https://www.sqlite.org/lang_altertable.html)
// it would be much cleaner to use a database migration tool with proper versioning like evolve to execute the necessary databse changes for new versions (see: https://github.com/lecaillon/Evolve)
var columnTypes = GetColumnTypes(connection, "TypedBaseItems");
if (columnTypes["OwnerId"] == "TEXT")
{
connection.Execute("ALTER TABLE TypedBaseItems RENAME COLUMN OwnerId TO OwnerId_OLD");
connection.Execute("ALTER TABLE TypedBaseItems ADD COLUMN OwnerId GUID NULL");
connection.Execute("UPDATE TypedBaseItems SET OwnerId = OwnerId_OLD WHERE OwnerId_OLD IS NOT NULL");
connection.Execute("ALTER TABLE TypedBaseItems DROP COLUMN OwnerId_OLD");
}
existingColumnNames = GetColumnNames(connection, "ItemValues");
AddColumn(connection, "ItemValues", "CleanValue", "Text", existingColumnNames);