From f9427b9bfbe6e4dad0abbf8498fc24c7e75a8230 Mon Sep 17 00:00:00 2001 From: George Ke Date: Thu, 28 Jul 2016 11:50:39 -0700 Subject: [PATCH] Fix mapbox radius calculations being off when changing latitude (#824) --- caravel/assets/visualizations/mapbox.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/caravel/assets/visualizations/mapbox.jsx b/caravel/assets/visualizations/mapbox.jsx index 97281e9a0d..75a6909f81 100644 --- a/caravel/assets/visualizations/mapbox.jsx +++ b/caravel/assets/visualizations/mapbox.jsx @@ -137,12 +137,13 @@ class ScatterPlotGlowOverlay extends ScatterPlotOverlay { let pointLabel; if (radiusProperty !== null) { + const pointLatitude = props.lngLatAccessor(location)[1]; if (props.pointRadiusUnit === 'Kilometers') { pointLabel = d3.round(pointRadius, 2) + 'km'; - pointRadius = kmToPixels(pointRadius, props.latitude, props.zoom); + pointRadius = kmToPixels(pointRadius, pointLatitude, props.zoom); } else if (props.pointRadiusUnit === 'Miles') { pointLabel = d3.round(pointRadius, 2) + 'mi'; - pointRadius = kmToPixels(pointRadius * MILES_PER_KM, props.latitude, props.zoom); + pointRadius = kmToPixels(pointRadius * MILES_PER_KM, pointLatitude, props.zoom); } }