diff --git a/superset-frontend/spec/javascripts/sqllab/LimitControl_spec.jsx b/superset-frontend/spec/javascripts/sqllab/LimitControl_spec.jsx index 53fb00d6ad..c05a13837b 100644 --- a/superset-frontend/spec/javascripts/sqllab/LimitControl_spec.jsx +++ b/superset-frontend/spec/javascripts/sqllab/LimitControl_spec.jsx @@ -99,7 +99,10 @@ describe('LimitControl', () => { wrappingComponent: ThemeProvider, wrappingComponentProps: { theme: supersetTheme }, }); - popoverContentWrapper.find('.ok').first().simulate('click'); + popoverContentWrapper + .find('[data-test="limit-control-confirm"]') + .first() + .simulate('click'); expect(wrapper.state().showOverlay).toBe(false); }); it('resets and closes', () => { @@ -114,7 +117,10 @@ describe('LimitControl', () => { wrappingComponent: ThemeProvider, wrappingComponentProps: { theme: supersetTheme }, }); - popoverContentWrapper.find('.reset').first().simulate('click'); + popoverContentWrapper + .find('[data-test="limit-control-cancel"]') + .first() + .simulate('click'); expect(wrapper.state().textValue).toEqual( defaultProps.defaultQueryLimit.toString(), ); diff --git a/superset-frontend/spec/javascripts/sqllab/SaveQuery_spec.jsx b/superset-frontend/spec/javascripts/sqllab/SaveQuery_spec.jsx index 6baa96e25e..231427bde2 100644 --- a/superset-frontend/spec/javascripts/sqllab/SaveQuery_spec.jsx +++ b/superset-frontend/spec/javascripts/sqllab/SaveQuery_spec.jsx @@ -48,7 +48,7 @@ describe('SavedQuery', () => { const wrapper = shallow(); const modal = wrapper.find(Modal); - expect(modal.find('.cancelQuery')).toHaveLength(1); + expect(modal.find('[data-test="cancel-query"]')).toHaveLength(1); }); it('has 2 FormControls', () => { const wrapper = shallow(); diff --git a/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx b/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx index 15559c7cf8..58e7ae25e0 100644 --- a/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx +++ b/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx @@ -108,7 +108,7 @@ describe('SqlEditor', () => { it('allows toggling autocomplete', () => { const wrapper = shallow(); expect(wrapper.find(AceEditorWrapper).props().autocomplete).toBe(true); - wrapper.find('.autocomplete').simulate('click'); + wrapper.find('[data-test="autocomplete"]').simulate('click'); expect(wrapper.find(AceEditorWrapper).props().autocomplete).toBe(false); }); }); diff --git a/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx b/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx index 388e74f195..ea52f09bed 100644 --- a/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx +++ b/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx @@ -75,7 +75,7 @@ class ExploreResultsButton extends React.PureComponent { this.dialog.show({ title: t('Explore'), body: msg, - actions: [Dialog.DefaultAction('Ok', () => {}, 'btn-primary')], + actions: [Dialog.DefaultAction('Ok', () => {})], bsSize: 'large', bsStyle: 'warning', onHide: dialog => { diff --git a/superset-frontend/src/SqlLab/components/LimitControl.tsx b/superset-frontend/src/SqlLab/components/LimitControl.tsx index 95348e321a..d771f37eda 100644 --- a/superset-frontend/src/SqlLab/components/LimitControl.tsx +++ b/superset-frontend/src/SqlLab/components/LimitControl.tsx @@ -118,7 +118,8 @@ export default class LimitControl extends React.PureComponent< - @@ -195,7 +195,7 @@ export default function SaveQuery({ return ( - - diff --git a/superset-frontend/src/SqlLab/components/SqlEditor.jsx b/superset-frontend/src/SqlLab/components/SqlEditor.jsx index cebd0c44d5..14924b8947 100644 --- a/superset-frontend/src/SqlLab/components/SqlEditor.jsx +++ b/superset-frontend/src/SqlLab/components/SqlEditor.jsx @@ -558,7 +558,7 @@ class SqlEditor extends React.PureComponent {
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx index 681e7e6156..6518d0dede 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx @@ -70,11 +70,6 @@ const StyledInputContainer = styled.div` i { margin: 0 ${({ theme }) => theme.gridUnit}px; } - - .btn-primary { - height: 36px; - font-size: ${({ theme }) => theme.typography.sizes.s - 1}px; - } } input,