From ef7087adb653dc30a61488ec9087cc2f6d619bd0 Mon Sep 17 00:00:00 2001 From: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> Date: Wed, 4 Nov 2020 14:27:32 -0800 Subject: [PATCH] fix(dashboard): properly unset mountedTab in reducer (#11558) --- .../src/dashboard/reducers/dashboardState.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/dashboard/reducers/dashboardState.js b/superset-frontend/src/dashboard/reducers/dashboardState.js index c7fde4abeb..6a21dec940 100644 --- a/superset-frontend/src/dashboard/reducers/dashboardState.js +++ b/superset-frontend/src/dashboard/reducers/dashboardState.js @@ -124,13 +124,16 @@ export default function dashboardStateReducer(state = {}, action) { }; }, [SET_DIRECT_PATH]() { - return { + const newState = { ...state, - // change of direct path (tabs) will reset current mounted tab - mountedTab: null, directPathToChild: action.path, directPathLastUpdated: Date.now(), }; + // change of direct path (tabs) will reset current mounted tab + // cannot just set mountedTab to null, + // as that is used when transitioning between tabs. + delete newState.mountedTab; + return newState; }, [SET_MOUNTED_TAB]() { // set current mounted tab after tab is really mounted to DOM