From ecf1abae7820993f854ec35b8729f269a2092b3c Mon Sep 17 00:00:00 2001 From: Daniel Vaz Gaspar Date: Fri, 17 Apr 2020 16:28:10 +0100 Subject: [PATCH] [pypi] Include compiled translations on Pypi pkg (#9567) --- RELEASING/README.md | 6 +++--- pypi_push.sh | 9 ++++++++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/RELEASING/README.md b/RELEASING/README.md index d67ff07325..6b69b8150b 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -292,9 +292,9 @@ with the changes on `CHANGELOG.md` and `UPDATING.md`. ### Publishing a Convenience Release to PyPI -From the root of the repo running ./pypi_push.sh will build the -Javascript bundle and echo the twine command allowing you to publish -to PyPI. You may need to ask a fellow committer to grant +Using the final release tarball, unpack it and run `./pypi_push.sh`. +This script will build the Javascript bundle and echo the twine command +allowing you to publish to PyPI. You may need to ask a fellow committer to grant you access to it if you don't have access already. Make sure to create an account first if you don't have one, and reference your username while requesting access to push packages. diff --git a/pypi_push.sh b/pypi_push.sh index 065fa262a2..8b4db99065 100755 --- a/pypi_push.sh +++ b/pypi_push.sh @@ -21,6 +21,13 @@ git branch rm superset/static/assets/* cd superset-frontend/ npm ci && npm run build -cd ../.. +cd ../ +echo "----------------------" +echo "Compiling translations" +echo "----------------------" +flask fab babel-compile --target superset/translations +echo "----------------------" +echo "Creating distribution " +echo "----------------------" python setup.py sdist echo "RUN: twine upload dist/apache-superset-{SUPERSET_VERSION}.tar.gz"