diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx index f0343842ef..d72156dd71 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx @@ -17,8 +17,9 @@ * under the License. */ import React, { useCallback, useMemo, useState, useRef } from 'react'; -import { uniq } from 'lodash'; +import { uniq, debounce } from 'lodash'; import { t, styled } from '@superset-ui/core'; +import { SLOW_DEBOUNCE } from 'src/constants'; import { Form } from 'src/common/components'; import { StyledModal } from 'src/components/Modal'; import ErrorBoundary from 'src/components/ErrorBoundary'; @@ -233,6 +234,23 @@ export function FiltersConfigModal({ } }; + const onValuesChange = useMemo( + () => + debounce((changes: any, values: NativeFiltersForm) => { + if ( + changes.filters && + Object.values(changes.filters).some( + (filter: any) => filter.name != null, + ) + ) { + // we only need to set this if a name changed + setFormValues(values); + } + setSaveAlertVisible(false); + }, SLOW_DEBOUNCE), + [], + ); + return ( { - if ( - changes.filters && - Object.values(changes.filters).some( - (filter: any) => filter.name != null, - ) - ) { - // we only need to set this if a name changed - setFormValues(values); - } - setSaveAlertVisible(false); - }} + onValuesChange={onValuesChange} layout="vertical" >