From e2f676445b406ddc3793949154270ab7a533a0e7 Mon Sep 17 00:00:00 2001 From: Jesse Yang Date: Mon, 21 Dec 2020 20:40:33 -0800 Subject: [PATCH] test(dashboard): fix flaky Cypress test (#12151) --- .../cypress/integration/dashboard/filter.test.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts index cbca4cad4f..8827c09427 100644 --- a/superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts @@ -69,8 +69,10 @@ describe('Dashboard filter', () => { it('should apply filter', () => { cy.get('.Select__placeholder:first').click(); - // should open the filter indicator - cy.get('svg[data-test="filter"]').should('be.visible'); + // should show the filter indicator + cy.get('svg[data-test="filter"]:visible').should(nodes => { + expect(nodes.length).to.least(9); + }); cy.get('.Select__control:first input[type=text]').type('So', { force: true, @@ -80,9 +82,8 @@ describe('Dashboard filter', () => { cy.get('.Select__menu').first().contains('South Asia').click(); // should still have all filter indicators - // and since the select is closed, all filter indicators should be visible cy.get('svg[data-test="filter"]:visible').should(nodes => { - expect(nodes).to.have.length(10); + expect(nodes.length).to.least(9); }); cy.get('.filter_box button').click({ force: true });