diff --git a/superset/assets/src/chart/chartAction.js b/superset/assets/src/chart/chartAction.js index a2f01165d6..f1112f5a8d 100644 --- a/superset/assets/src/chart/chartAction.js +++ b/superset/assets/src/chart/chartAction.js @@ -2,6 +2,7 @@ import { getExploreUrlAndPayload, getAnnotationJsonUrl } from '../explore/explor import { requiresQuery, ANNOTATION_SOURCE_TYPES } from '../modules/AnnotationTypes'; import { Logger, LOG_ACTIONS_LOAD_EVENT } from '../logger'; import { COMMON_ERR_MESSAGES } from '../common'; +import { t } from '../locales'; const $ = window.$ = require('jquery'); diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 9d6f57b455..269b087414 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -582,12 +582,12 @@ class SqlaTable(Model, BaseDatasource): col = flt['col'] op = flt['op'] col_obj = cols.get(col) - is_list_target = op in ('in', 'not in') - eq = self.filter_values_handler( - flt.get('val'), - target_column_is_numeric=col_obj.is_num, - is_list_target=is_list_target) if col_obj: + is_list_target = op in ('in', 'not in') + eq = self.filter_values_handler( + flt.get('val'), + target_column_is_numeric=col_obj.is_num, + is_list_target=is_list_target) if op in ('in', 'not in'): cond = col_obj.sqla_col.in_(eq) if '' in eq: diff --git a/superset/viz.py b/superset/viz.py index de14f1af24..7eb34c68c6 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -23,7 +23,7 @@ import traceback import uuid from dateutil import relativedelta as rdelta -from flask import escape, request +from flask import request from flask_babel import lazy_gettext as _ import geohash from geopy.point import Point @@ -368,7 +368,7 @@ class BaseViz(object): except Exception as e: logging.exception(e) if not self.error_message: - self.error_message = escape('{}'.format(e)) + self.error_message = '{}'.format(e) self.status = utils.QueryStatus.FAILED stacktrace = traceback.format_exc()