diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 3b636e8fa2..ef8c68ebb3 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -432,8 +432,6 @@ class SqlaTable(Model, BaseDatasource): from_sql = self.sql if template_processor: from_sql = template_processor.process_template(from_sql) - if db_engine_spec: - from_sql = db_engine_spec.escape_sql(from_sql) from_sql = sqlparse.format(from_sql, strip_comments=True) return TextAsFrom(sa.text(from_sql), []).alias('expr_qry') return self.get_sqla_table() diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py index 73f8677293..e026ccfb39 100644 --- a/superset/db_engine_specs.py +++ b/superset/db_engine_specs.py @@ -145,11 +145,6 @@ class BaseEngineSpec(object): BaseEngineSpec.df_to_db(**df_to_db_kwargs) - @classmethod - def escape_sql(cls, sql): - """Escapes the raw SQL""" - return sql - @classmethod def convert_dttm(cls, target_type, dttm): return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S')) @@ -552,10 +547,6 @@ class PrestoEngineSpec(BaseEngineSpec): uri.database = database return uri - @classmethod - def escape_sql(cls, sql): - return re.sub(r'%%|%', '%%', sql) - @classmethod def convert_dttm(cls, target_type, dttm): tt = target_type.upper()