From d74d3a87bb6e46eed6b57e76cb7bf5707ce27c9b Mon Sep 17 00:00:00 2001 From: Jessie R Date: Wed, 26 Jun 2024 03:25:21 +0700 Subject: [PATCH] fix: default logging (#27777) --- UPDATING.md | 2 ++ superset/config.py | 4 ++-- superset/utils/logging_configurator.py | 12 +----------- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index 1d2ffbf0ec..7ecc1a298d 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -47,6 +47,8 @@ assists people when migrating to a new version. set `SLACK_API_TOKEN` to fetch and serve Slack avatar links - [28134](https://github.com/apache/superset/pull/28134/) The default logging level was changed from DEBUG to INFO - which is the normal/sane default logging level for most software. +- [27777](https://github.com/apache/superset/pull/27777) Moves debug logging logic to config.py. + See `LOG_LEVEL` in `superset/config.py` for the recommended default. - [28205](https://github.com/apache/superset/pull/28205) The permission `all_database_access` now more clearly provides access to all databases, as specified in its name. Before it only allowed listing all databases in CRUD-view and dropdown and didn't provide access to data as it diff --git a/superset/config.py b/superset/config.py index 8256ca0dc0..e4dc202537 100644 --- a/superset/config.py +++ b/superset/config.py @@ -895,7 +895,7 @@ LOGGING_CONFIGURATOR = DefaultLoggingConfigurator() # Console Log Settings LOG_FORMAT = "%(asctime)s:%(levelname)s:%(name)s:%(message)s" -LOG_LEVEL = logging.INFO +LOG_LEVEL = logging.DEBUG if DEBUG else logging.INFO # --------------------------------------------------- # Enable Time Rotate Log Handler @@ -903,7 +903,7 @@ LOG_LEVEL = logging.INFO # LOG_LEVEL = DEBUG, INFO, WARNING, ERROR, CRITICAL ENABLE_TIME_ROTATE = False -TIME_ROTATE_LOG_LEVEL = logging.INFO +TIME_ROTATE_LOG_LEVEL = logging.DEBUG if DEBUG else logging.INFO FILENAME = os.path.join(DATA_DIR, "superset.log") ROLLOVER = "midnight" INTERVAL = 1 diff --git a/superset/utils/logging_configurator.py b/superset/utils/logging_configurator.py index ba4bf2117f..2d53d535cd 100644 --- a/superset/utils/logging_configurator.py +++ b/superset/utils/logging_configurator.py @@ -41,17 +41,7 @@ class DefaultLoggingConfigurator( # pylint: disable=too-few-public-methods if app_config["SILENCE_FAB"]: logging.getLogger("flask_appbuilder").setLevel(logging.ERROR) - # configure superset app logger - superset_logger = logging.getLogger("superset") - if debug_mode: - superset_logger.setLevel(logging.DEBUG) - else: - # In production mode, add log handler to sys.stderr. - superset_logger.addHandler(logging.StreamHandler()) - superset_logger.setLevel(logging.INFO) - - logging.getLogger("pyhive.presto").setLevel(logging.INFO) - + # basicConfig() will set up a default StreamHandler on stderr logging.basicConfig(format=app_config["LOG_FORMAT"]) logging.getLogger().setLevel(app_config["LOG_LEVEL"])