diff --git a/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx b/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx index b7e1a32181..94b7e2780b 100644 --- a/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx +++ b/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx @@ -159,7 +159,7 @@ describe('SavedQuery', () => { const closeBtn = screen.getByRole('button', { name: /close/i }); const saveDatasetHeader = screen.getByText(/save or overwrite dataset/i); const saveRadio = screen.getByRole('radio', { - name: /save as new untitled dataset/i, + name: /save as new untitled/i, }); const saveLabel = screen.getByText(/save as new/i); const saveTextbox = screen.getByRole('textbox'); diff --git a/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx b/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx index 4f88d6c9a1..554514f4db 100644 --- a/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx +++ b/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx @@ -26,9 +26,10 @@ import { Form, FormItem } from 'src/components/Form'; import Modal from 'src/components/Modal'; import SaveDatasetActionButton from 'src/SqlLab/components/SaveDatasetActionButton'; import { SaveDatasetModal } from 'src/SqlLab/components/SaveDatasetModal'; +import { getDatasourceAsSaveableDataset } from 'src/utils/datasourceUtils'; interface SaveQueryProps { - query: any; + query: QueryPayload; defaultLabel: string; onSave: (arg0: QueryPayload) => void; onUpdate: (arg0: QueryPayload) => void; @@ -177,7 +178,7 @@ export default function SaveQuery({ onHide={() => setShowSaveDatasetModal(false)} buttonTextOnSave={t('Save & Explore')} buttonTextOnOverwrite={t('Overwrite & Explore')} - datasource={query} + datasource={getDatasourceAsSaveableDataset(query)} /> ({ columns: source.columns, name: source?.datasource_name || source?.name || 'Untitled', - dbId: source.database.id, + dbId: source?.database?.id || source?.dbId, sql: source?.sql || '', schema: source?.schema, });