From c9e5fbb09b0910eba957c70ea9f7989559b108ee Mon Sep 17 00:00:00 2001
From: Grace Guo <grace.guo@airbnb.com>
Date: Tue, 6 Jun 2017 12:05:05 -0700
Subject: [PATCH] [dashboard]Add timeout message on Dashboard view (#2910)

Same as explore view, if query takes > 45 seconds not returned, we will show Query timeout warning message. Otherwise user will see 504 Gateway timeout error.
---
 .../assets/javascripts/modules/superset.js    | 38 +++++++++++--------
 superset/assets/visualizations/filter_box.css |  2 +-
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/superset/assets/javascripts/modules/superset.js b/superset/assets/javascripts/modules/superset.js
index 8f234395a3..acdfaa9861 100644
--- a/superset/assets/javascripts/modules/superset.js
+++ b/superset/assets/javascripts/modules/superset.js
@@ -4,6 +4,7 @@ import Mustache from 'mustache';
 import vizMap from '../../visualizations/main';
 import { getExploreUrl } from '../explore/exploreUtils';
 import { applyDefaultFormData } from '../explore/stores/store';
+import { QUERY_TIMEOUT_THRESHOLD } from '../constants';
 
 const utils = require('./utils');
 
@@ -123,9 +124,6 @@ const px = function () {
         controller.done(this);
       },
       getErrorMsg(xhr) {
-        if (xhr.statusText === 'timeout') {
-          return 'The request timed out';
-        }
         let msg = '';
         if (!xhr.responseText) {
           const status = xhr.status;
@@ -158,9 +156,14 @@ const px = function () {
           errHtml += `<div class="alert alert-danger">${errorMsg}</div>`;
         }
         if (xhr) {
-          const extendedMsg = this.getErrorMsg(xhr);
-          if (extendedMsg) {
-            errHtml += `<div class="alert alert-danger">${extendedMsg}</div>`;
+          if (xhr.statusText === 'timeout') {
+            errHtml += '<div class="alert alert-warning">' +
+              `Query timeout - visualization query are set to time out at ${QUERY_TIMEOUT_THRESHOLD / 1000} seconds.</div>`;
+          } else {
+            const extendedMsg = this.getErrorMsg(xhr);
+            if (extendedMsg) {
+              errHtml += `<div class="alert alert-danger">${extendedMsg}</div>`;
+            }
           }
         }
         container.html(errHtml);
@@ -205,15 +208,20 @@ const px = function () {
         token.find('img.loading').show();
         container.fadeTo(0.5, 0.25);
         container.css('height', this.height());
-        $.getJSON(this.jsonEndpoint(), (queryResponse) => {
-          try {
-            vizMap[formData.viz_type](this, queryResponse);
-            this.done(queryResponse);
-          } catch (e) {
-            this.error('An error occurred while rendering the visualization: ' + e);
-          }
-        }).fail((err) => {
-          this.error(err.responseText, err);
+        $.ajax({
+          url: this.jsonEndpoint(),
+          timeout: QUERY_TIMEOUT_THRESHOLD,
+          success: (queryResponse) => {
+            try {
+              vizMap[formData.viz_type](this, queryResponse);
+              this.done(queryResponse);
+            } catch (e) {
+              this.error('An error occurred while rendering the visualization: ' + e);
+            }
+          },
+          error: (err) => {
+            this.error(err.responseText, err);
+          },
         });
       },
       resize() {
diff --git a/superset/assets/visualizations/filter_box.css b/superset/assets/visualizations/filter_box.css
index af2c3071b4..e1b72f3bd7 100644
--- a/superset/assets/visualizations/filter_box.css
+++ b/superset/assets/visualizations/filter_box.css
@@ -3,7 +3,7 @@
     border: 1px superset black;
 }
 
-.dashboard .filter_box .slice_container > div {
+.dashboard .filter_box .slice_container > div:not(.alert) {
     padding-top: 0;
 }