From bd88e12b8b8c4bcdfdbadb4ae12dce32833281d7 Mon Sep 17 00:00:00 2001 From: Erik Ritter Date: Wed, 12 Aug 2020 15:27:29 -0700 Subject: [PATCH] feat: add extra column to tables and sql_metrics (#10592) --- ..._add_extra_column_to_tables_and_metrics.py | 40 +++++++++++++++++++ superset/tasks/slack_util.py | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 superset/migrations/versions/f120347acb39_add_extra_column_to_tables_and_metrics.py diff --git a/superset/migrations/versions/f120347acb39_add_extra_column_to_tables_and_metrics.py b/superset/migrations/versions/f120347acb39_add_extra_column_to_tables_and_metrics.py new file mode 100644 index 0000000000..face9ce73a --- /dev/null +++ b/superset/migrations/versions/f120347acb39_add_extra_column_to_tables_and_metrics.py @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Add extra column to tables and metrics + +Revision ID: f120347acb39 +Revises: f2672aa8350a +Create Date: 2020-08-12 10:01:43.531845 + +""" + +# revision identifiers, used by Alembic. +revision = "f120347acb39" +down_revision = "f2672aa8350a" + +import sqlalchemy as sa +from alembic import op + + +def upgrade(): + op.add_column("tables", sa.Column("extra", sa.Text(), nullable=True)) + op.add_column("sql_metrics", sa.Column("extra", sa.Text(), nullable=True)) + + +def downgrade(): + op.drop_column("tables", "extra") + op.drop_column("sql_metrics", "extra") diff --git a/superset/tasks/slack_util.py b/superset/tasks/slack_util.py index 865aa59782..64e992390d 100644 --- a/superset/tasks/slack_util.py +++ b/superset/tasks/slack_util.py @@ -26,7 +26,7 @@ from slack.web.slack_response import SlackResponse from superset import app # Globals -config = app.config # type: ignore +config = app.config logger = logging.getLogger("tasks.slack_util")