From b960843015096ada1527fcea3dfeaf337907363e Mon Sep 17 00:00:00 2001
From: Geido <60598000+geido@users.noreply.github.com>
Date: Tue, 11 May 2021 21:38:58 +0300
Subject: [PATCH] fix: Menu does not appear on scroll in Dashboard (#14566)

* Fix menu

* Fix test
---
 .../HeaderActionsDropdown/HeaderActionsDropdown.test.tsx      | 2 +-
 .../components/Header/HeaderActionsDropdown/index.jsx         | 2 +-
 superset-frontend/stylesheets/superset.less                   | 4 ----
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
index 039c1ef97c..a5f7bab11c 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
@@ -65,7 +65,7 @@ const editModeOnProps = {
 
 function setup(props: HeaderDropdownProps) {
   return (
-    <div className="dashboard">
+    <div className="dashboard-header">
       <HeaderActionsDropdown {...props} />
     </div>
   );
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
index 607fcdfd9d..9b9aefe03b 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
@@ -317,7 +317,7 @@ class HeaderActionsDropdown extends React.PureComponent {
         overlay={menu}
         trigger={['click']}
         getPopupContainer={triggerNode =>
-          triggerNode.closest(SCREENSHOT_NODE_SELECTOR)
+          triggerNode.closest('.dashboard-header')
         }
       >
         <DropdownButton id="save-dash-split-button" role="button">
diff --git a/superset-frontend/stylesheets/superset.less b/superset-frontend/stylesheets/superset.less
index 4c5cc224a3..477b8c199f 100644
--- a/superset-frontend/stylesheets/superset.less
+++ b/superset-frontend/stylesheets/superset.less
@@ -603,7 +603,3 @@ hr {
     top: 269px !important;
   }
 }
-
-.ant-dropdown.ant-dropdown-placement-bottomRight {
-  top: 133px !important;
-}