From b7e7ef283150837c2c1d78719c11e20424c67d87 Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Tue, 26 Oct 2021 17:25:49 -0700 Subject: [PATCH] Revert "fix: the calculated columns explicit type convert into date (#14813)" (#16950) This reverts commit 6bdbd2bf5059dac58e65cdf3fbafe618e182d907. --- superset/connectors/sqla/models.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 1f68dea2be..83abc27c27 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -338,8 +338,7 @@ class TableColumn(Model, BaseColumn, CertificationMixin): ], ) -> str: """Convert datetime object to a SQL expression string""" - dttm_type = self.type or ("DATETIME" if self.is_dttm else None) - sql = self.db_engine_spec.convert_dttm(dttm_type, dttm) if dttm_type else None + sql = self.db_engine_spec.convert_dttm(self.type, dttm) if self.type else None if sql: return sql