From b60938be4d89d0ffd9780be88bb0c0421584a1bf Mon Sep 17 00:00:00 2001 From: Vitor Avila <96086495+Vitor-Avila@users.noreply.github.com> Date: Wed, 14 Feb 2024 21:42:23 -0300 Subject: [PATCH] chore: bump firebolt-sqlalchemy to support service account auth (#27118) --- docs/docs/databases/firebolt.mdx | 11 +++++------ docs/docs/databases/installing-database-drivers.mdx | 2 +- setup.py | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/docs/docs/databases/firebolt.mdx b/docs/docs/databases/firebolt.mdx index 6a6986bdb7..14bfad6797 100644 --- a/docs/docs/databases/firebolt.mdx +++ b/docs/docs/databases/firebolt.mdx @@ -8,20 +8,19 @@ version: 1 ## Firebolt The recommended connector library for Firebolt is [firebolt-sqlalchemy](https://pypi.org/project/firebolt-sqlalchemy/). -Superset has been tested on `firebolt-sqlalchemy>=0.0.1`. The recommended connection string is: ``` -firebolt://{username}:{password}@{database} +firebolt://{username}:{password}@{database}?account_name={name} or -firebolt://{username}:{password}@{database}/{engine_name} +firebolt://{username}:{password}@{database}/{engine_name}?account_name={name} ``` -Here's a connection string example of Superset connecting to a Firebolt database: +It's also possible to connect using a service account: ``` -firebolt://email@domain:password@sample_database +firebolt://{client_id}:{client_secret}@{database}?account_name={name} or -firebolt://email@domain:password@sample_database/sample_engine +firebolt://{client_id}:{client_secret}@{database}/{engine_name}?account_name={name} ``` diff --git a/docs/docs/databases/installing-database-drivers.mdx b/docs/docs/databases/installing-database-drivers.mdx index f11b4ec5eb..fd8ad84166 100644 --- a/docs/docs/databases/installing-database-drivers.mdx +++ b/docs/docs/databases/installing-database-drivers.mdx @@ -45,7 +45,7 @@ Some of the recommended packages are shown below. Please refer to [setup.py](htt | [Elasticsearch](/docs/databases/elasticsearch) | `pip install elasticsearch-dbapi` | `elasticsearch+http://{user}:{password}@{host}:9200/` | | [Exasol](/docs/databases/exasol) | `pip install sqlalchemy-exasol` | `exa+pyodbc://{username}:{password}@{hostname}:{port}/my_schema?CONNECTIONLCALL=en_US.UTF-8&driver=EXAODBC` | | [Google Sheets](/docs/databases/google-sheets) | `pip install shillelagh[gsheetsapi]` | `gsheets://` | -| [Firebolt](/docs/databases/firebolt) | `pip install firebolt-sqlalchemy` | `firebolt://{username}:{password}@{database} or firebolt://{username}:{password}@{database}/{engine_name}` | +| [Firebolt](/docs/databases/firebolt) | `pip install firebolt-sqlalchemy` | `firebolt://{client_id}:{client_secret}@{database}/{engine_name}?account_name={name}` | | [Hologres](/docs/databases/hologres) | `pip install psycopg2` | `postgresql+psycopg2://:@/` | | [IBM Db2](/docs/databases/ibm-db2) | `pip install ibm_db_sa` | `db2+ibm_db://` | | [IBM Netezza Performance Server](/docs/databases/netezza) | `pip install nzalchemy` | `netezza+nzpy://:@/` | diff --git a/setup.py b/setup.py index 25352f94ab..97df81a695 100644 --- a/setup.py +++ b/setup.py @@ -163,7 +163,7 @@ setup( "exasol": ["sqlalchemy-exasol >= 2.4.0, <3.0"], "excel": ["xlrd>=1.2.0, <1.3"], "firebird": ["sqlalchemy-firebird>=0.7.0, <0.8"], - "firebolt": ["firebolt-sqlalchemy>=0.0.1"], + "firebolt": ["firebolt-sqlalchemy>=1.0.0, <2"], "gsheets": ["shillelagh[gsheetsapi]>=1.2.10, <2"], "hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"], "hive": [