From ad72ea53a1adf802b072235edc0ebb6e7d93e748 Mon Sep 17 00:00:00 2001 From: Stephen Liu <750188453@qq.com> Date: Tue, 31 May 2022 21:18:49 +0800 Subject: [PATCH] fix(legacy-plugin-chart-sunburst): chart broken when secondary metric is remove (#20223) --- .../controls/DndColumnSelectControl/DndMetricSelect.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx index db76f75fcf..0d9591a0c5 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx @@ -237,9 +237,9 @@ export const DndMetricSelect = (props: any) => { const valuesCopy = [...value]; valuesCopy.splice(index, 1); setValue(valuesCopy); - onChange(valuesCopy); + handleChange(valuesCopy); }, - [onChange, value], + [handleChange, value], ); const moveLabel = useCallback(