pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: dashboard iframe to markdown db migration (#11845) 

* fix: dashboard iframe to markdown db migration

* Update superset/migrations/versions/978245563a02_migrate_iframe_to_dash_markdown.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
This commit is contained in:
Daniel Vaz Gaspar 2020-12-01 20:50:35 +00:00 committed by GitHub
parent a5af2ade0a
commit ac9761c730
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
superset/migrations/versions/978245563a02_migrate_iframe_to_dash_markdown.py
View File

@ -132,6 +132,7 @@ def upgrade():
# find iframe chart position in metadata
# and replace it with markdown component
position_dict = json.loads(dashboard.position_json or "{}")
keys_to_remove = []
for key, chart_position in position_dict.items():
if (
chart_position
@ -145,7 +146,7 @@ def upgrade():
markdown = create_new_markdown_component(
chart_position, iframe_urls[iframe_id]
)
position_dict.pop(key)
keys_to_remove.append(key)
position_dict[markdown["id"]] = markdown
# add markdown to layout tree
@ -154,13 +155,13 @@ def upgrade():
children.remove(key)
children.append(markdown["id"])
dashboard.position_json = json.dumps(
position_dict,
indent=None,
separators=(",", ":"),
sort_keys=True,
)
session.merge(dashboard)
if keys_to_remove:
for key_to_remove in keys_to_remove:
del position_dict[key_to_remove]
dashboard.position_json = json.dumps(
position_dict, indent=None, separators=(",", ":"), sort_keys=True,
)
session.merge(dashboard)
# remove iframe, separator and markup charts
slices_to_remove = (