From aa53c1031215ece0fec7dd798ab113a3e012d910 Mon Sep 17 00:00:00 2001 From: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Date: Wed, 3 Aug 2022 12:12:56 -0300 Subject: [PATCH] Big Number Viz: (#20946) - When the value is zero we still render the percent change and suffix if present --- .../src/BigNumber/BigNumberWithTrendline/transformProps.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts index faf6271302..07ca77547b 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts @@ -125,8 +125,10 @@ export default function transformProps( if (compareIndex < sortedData.length) { const compareValue = sortedData[compareIndex][1]; // compare values must both be non-nulls - if (bigNumber !== null && compareValue !== null && compareValue !== 0) { - percentChange = (bigNumber - compareValue) / Math.abs(compareValue); + if (bigNumber !== null && compareValue !== null) { + percentChange = compareValue + ? (bigNumber - compareValue) / Math.abs(compareValue) + : 0; formattedSubheader = `${formatPercentChange( percentChange, )} ${compareSuffix}`;