From a5a4f1bcecb7866e2deb90b98267497a97937a11 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Mon, 11 Nov 2019 14:33:38 -0800 Subject: [PATCH] build: fix lint (#245) --- .../src/components/SuperChart.tsx | 5 +++-- .../packages/superset-ui-chart/src/index.ts | 12 +++--------- .../test/models/Registry.test.ts | 16 +++++++--------- .../src/encoders/createEncoderFactory.ts | 3 ++- .../src/fillers/completeAxisConfig.ts | 4 ++-- .../superset-ui-number-format/src/index.ts | 4 +--- .../superset-ui-query/src/types/Query.ts | 3 ++- 7 files changed, 20 insertions(+), 27 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/components/SuperChart.tsx b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/components/SuperChart.tsx index dd04295d81..48aaa77365 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/components/SuperChart.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/components/SuperChart.tsx @@ -162,8 +162,9 @@ export default class SuperChart extends React.PureComponent { } render() { - const { heightInfo, widthInfo, BoundingBox } = this.parseDimension(this - .props as PropsWithDefault); + const { heightInfo, widthInfo, BoundingBox } = this.parseDimension( + this.props as PropsWithDefault, + ); // If any of the dimension is dynamic, get parent's dimension if (widthInfo.isDynamic || heightInfo.isDynamic) { diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/index.ts index a009146aa4..3c09526c7e 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/index.ts @@ -7,17 +7,11 @@ export { default as createLoadableRenderer } from './components/createLoadableRe export { default as reactify } from './components/reactify'; export { default as SuperChart } from './components/SuperChart'; -export { - default as getChartBuildQueryRegistry, -} from './registries/ChartBuildQueryRegistrySingleton'; +export { default as getChartBuildQueryRegistry } from './registries/ChartBuildQueryRegistrySingleton'; export { default as getChartComponentRegistry } from './registries/ChartComponentRegistrySingleton'; -export { - default as getChartControlPanelRegistry, -} from './registries/ChartControlPanelRegistrySingleton'; +export { default as getChartControlPanelRegistry } from './registries/ChartControlPanelRegistrySingleton'; export { default as getChartMetadataRegistry } from './registries/ChartMetadataRegistrySingleton'; -export { - default as getChartTransformPropsRegistry, -} from './registries/ChartTransformPropsRegistrySingleton'; +export { default as getChartTransformPropsRegistry } from './registries/ChartTransformPropsRegistrySingleton'; export { default as ChartDataProvider } from './components/ChartDataProvider'; diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/models/Registry.test.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/models/Registry.test.ts index 7d629180da..8a5219dad8 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/models/Registry.test.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/models/Registry.test.ts @@ -252,15 +252,13 @@ describe('Registry', () => { registry.registerLoader('b', () => 'test2'); registry.registerLoader('c', () => Promise.resolve('test3')); - return registry - .entriesAsPromise() - .then(entries => - expect(entries).toEqual([ - { key: 'a', value: 'test1' }, - { key: 'b', value: 'test2' }, - { key: 'c', value: 'test3' }, - ]), - ); + return registry.entriesAsPromise().then(entries => + expect(entries).toEqual([ + { key: 'a', value: 'test1' }, + { key: 'b', value: 'test2' }, + { key: 'c', value: 'test3' }, + ]), + ); }); }); diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/encoders/createEncoderFactory.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/encoders/createEncoderFactory.ts index 14c52ed277..790aa64a9a 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/encoders/createEncoderFactory.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/encoders/createEncoderFactory.ts @@ -18,7 +18,8 @@ type CreateEncoderFactoryParams = { * if there are missing fields */ completeEncoding: (e: Partial>) => DeriveEncoding; - }); + } +); export default function createEncoderFactory( params: CreateEncoderFactoryParams, diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/fillers/completeAxisConfig.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/fillers/completeAxisConfig.ts index 833330c6e3..e9e4a92c83 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/fillers/completeAxisConfig.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-encodable/src/fillers/completeAxisConfig.ts @@ -17,7 +17,7 @@ function isChannelDefWithAxisSupport( export type CompleteAxisConfig = | false - | RequiredSome< + | (RequiredSome< Omit, | 'labelAngle' | 'labelFlush' @@ -29,7 +29,7 @@ export type CompleteAxisConfig = | 'titlePadding' > & { labelOverlap: LabelOverlapStrategy; - }; + }); export default function completeAxisConfig( channelType: ChannelType, diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-number-format/src/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-number-format/src/index.ts index 95cde2a2a4..aa8574aaef 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-number-format/src/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-number-format/src/index.ts @@ -9,6 +9,4 @@ export { export { default as createD3NumberFormatter } from './factories/createD3NumberFormatter'; export { default as createDurationFormatter } from './factories/createDurationFormatter'; -export { - default as createSiAtMostNDigitFormatter, -} from './factories/createSiAtMostNDigitFormatter'; +export { default as createSiAtMostNDigitFormatter } from './factories/createSiAtMostNDigitFormatter'; diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-query/src/types/Query.ts b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-query/src/types/Query.ts index 56f93073ca..af04416c2e 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-query/src/types/Query.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-query/src/types/Query.ts @@ -17,7 +17,8 @@ export type QueryObjectFilterClause = { } | { op: UnaryOperator; - }); + } +); export type QueryObjectMetric = { label: string;