From a413f796a68b0cdb656b3a35a552d407cd3cdfbb Mon Sep 17 00:00:00 2001 From: Jesse Yang Date: Thu, 26 Aug 2021 17:04:45 -0700 Subject: [PATCH] fix(explore): JS error for creating new metrics from columns (#16477) --- .../controls/DndColumnSelectControl/DndMetricSelect.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx index 0e71f18eac..2fcf53f8a8 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx @@ -186,9 +186,7 @@ export const DndMetricSelect = (props: any) => { const onNewMetric = useCallback( (newMetric: Metric) => { - const newValue = props.multi - ? [...value, newMetric.metric_name] - : [newMetric.metric_name]; + const newValue = props.multi ? [...value, newMetric] : [newMetric]; setValue(newValue); handleChange(newValue); },